oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: adding '...' appender to text columns that overflow
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: gui for adding macPool permissions.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Martin Mucha has uploaded a new change for review.
Change subject: webadmin: refactor—overgrown constructor
..
webadmin: refactor—overgrown constructor
- overgrown constructor split to smaller, single purpose methods
(I need to
Martin Mucha has uploaded a new change for review.
Change subject: webadmin: gui for adding macPool permissions.
..
webadmin: gui for adding macPool permissions.
Change-Id: Idb6b442e7eebce367b9008f4b9c1df9ade84745f
Signed-off-by
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: refactor—overgrown constructor
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
automat...@ovirt.org has posted comments on this change.
Change subject: restapi: Host Power-Management Refactor (#977674) - WIP
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url foun
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: adding '...' appender to text columns that overflow
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compi
Yedidyah Bar David has posted comments on this change.
Change subject: core: rewrite buildSequence using toposort
..
Patch Set 3:
> there is no sense in doing before/after and then priority as it breaks the
> before/after stat
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: adding '...' appender to text columns that overflow
..
Patch Set 1:
* Update tracker::#1122990::OK
* Check Bug-Url::OK
* Check Public Bug::#1122
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: adding '...' appender to text columns that overflow
..
webadmin: adding '...' appender to text columns that overflow
Using TextOverflow.ELLIPSIS style
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: adding '...' appender to text columns that overflow
..
Patch Set 3:
* Update tracker::#1122990::OK
* Check Bug-Url::OK
* Check Public Bug::#1122
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: adding '...' appender to text columns that overflow
..
Patch Set 3:
* Update tracker::#1122990::OK
* Set MODIFIED::bug 1122990#1122990IG
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: adding '...' appender to text columns that overflow
..
webadmin: adding '...' appender to text columns that overflow
Using TextOverflow.ELLIPSI
Tomas Jelinek has posted comments on this change.
Change subject: Fix watchdog configuration for localized webadmin
..
Patch Set 3: Code-Review+1
same for me, just please provide a proper BZ and I will give +2
--
To view, vis
Arik Hadas has posted comments on this change.
Change subject: core: cleanup - remove unused method
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32207
To unsubscribe, visit http://gerrit.ovirt.org/se
Tomas Jelinek has posted comments on this change.
Change subject: core: on clone vm the thin provisioned become clone provisioned
..
Patch Set 1:
AddVmAndCloneImageCommand.executeVmCommand() (which is the parent of the
CloneVm
automat...@ovirt.org has posted comments on this change.
Change subject: core,webadmin: wording. "... mac range." ——>"... MAC address
range."
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
Arik Hadas has posted comments on this change.
Change subject: core: Allow SD maintenance with suspended vms
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32201
To unsubscribe, visit http://gerrit.ovi
Martin Mucha has uploaded a new change for review.
Change subject: core,webadmin: wording. "... mac range." ——>"... MAC address
range."
..
core,webadmin: wording. "... mac range." ——>"... MAC address range."
Change-Id: I5225b2c
Alon Bar-Lev has posted comments on this change.
Change subject: core: rewrite buildSequence using toposort
..
Patch Set 3:
it is not matter now what is a reason, this is how it is working now, and this
cannot be changed withi
Yedidyah Bar David has posted comments on this change.
Change subject: core: rewrite buildSequence using toposort
..
Patch Set 3:
Is there a specific reason why priority is lower priority than before/after?
Not just that "it's
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: cleanup - remove unused method
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/3212
automat...@ovirt.org has posted comments on this change.
Change subject: core: cleanup - remove unused method
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Vered Volansky has posted comments on this change.
Change subject: core: cleanup - remove unused method
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32207
To unsubscribe, visit http://gerrit.ovirt.org/s
Vered Volansky has uploaded a new change for review.
Change subject: core: cleanup - remove unused method
..
core: cleanup - remove unused method
ImportVmCommnad.isDiskExists() is not used, therefore removed.
Change-Id: If71161
Yair Zaslavsky has posted comments on this change.
Change subject: core: Update hibernate-validator version
..
Patch Set 1: Code-Review+1
Ok, now I understand this is what jboss 7.1.1 is providing.
--
To view, visit http://ge
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Fix search to search properly for users by groups
..
Patch Set 2:
Hi Eli, sure:
We ran into the following scenario:
Using the generic-ldap provider we are
Alon Bar-Lev has posted comments on this change.
Change subject: core: Update hibernate-validator version
..
Patch Set 1:
> No packaging issues here?
what issue do you see?
--
To view, visit http://gerrit.ovirt.org/32198
To
Yair Zaslavsky has posted comments on this change.
Change subject: core: Update hibernate-validator version
..
Patch Set 1:
No packaging issues here?
--
To view, visit http://gerrit.ovirt.org/32198
To unsubscribe, visit http:
Allon Mureinik has posted comments on this change.
Change subject: core: ForceSelectSPM might fail
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32190
To unsubscribe, visit http://gerrit.ovirt.org/set
Allon Mureinik has posted comments on this change.
Change subject: core: Added validation on managed custom mount option
..
Patch Set 1: Code-Review-1
The same validation should also be done when editing a domain and/or a
conn
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Checking isProvisioned instead of the redundant entity
isDiscovered
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_c
automat...@ovirt.org has posted comments on this change.
Change subject: Checking isProvisioned instead of the redundant entity
isDiscovered
..
Patch Set 1:
* Update tracker::#1133540::OK
* Check Bug-Url::OK
* Check Public Bug
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Checking isProvisioned instead of the redundant entity
isDiscovered
..
Checking isProvisioned instead of the redundant entity isDiscovered
isDiscovered was a
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Make all disk size setting in DiskModel type safe
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_dao-uni
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: New disk dialog does not validate the size value
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: New disk dialog does not validate the size value
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_che
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Make all disk size setting in DiskModel type safe
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: New disk dialog does not validate the size value
..
Patch Set 1:
* Update tracker::#1115471::OK
* Check Bug-Url::OK
* Check Public Bug::#1115471
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: New disk dialog does not validate the size value
..
webadmin: New disk dialog does not validate the size value
The size field is defined as as an entity m
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: Make all disk size setting in DiskModel type safe
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Make all disk size setting in DiskModel type safe
..
webadmin: Make all disk size setting in DiskModel type safe
Since the size entity in DiskMode
Tal Nisan has posted comments on this change.
Change subject: webadmin: Make all disk size setting in DiskModel type safe
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/32195
To unsubscribe, visit http://
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: Make all disk size setting in DiskModel type safe
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url f
Tal Nisan has posted comments on this change.
Change subject: webadmin: New disk dialog does not validate the size value
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/32051
To unsubscribe, visit http://g
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: New disk dialog does not validate the size value
..
webadmin: New disk dialog does not validate the size value
The size field is defined as as an
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: New disk dialog does not validate the size value
..
Patch Set 4:
* Update tracker::#1115471::OK
* Check TR::#1115471::ERROR, 3.5.0 should not ma
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: add logging to SpmStopVDSCommand
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_merged/474/ : SUCCESS
ht
Alon Bar-Lev has posted comments on this change.
Change subject: core: rewrite buildSequence using toposort
..
Patch Set 3:
i guess it was still not clear... we cannot modify the ordering algorithm
throughout the major version
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: SpmStopOnIrs - set result
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_merged/473/ : SUCCESS
http://je
Alon Bar-Lev has posted comments on this change.
Change subject: core: rewrite buildSequence using toposort
..
Patch Set 3:
> I didn't see any design document.
the code is the design, the priority has second priority in orderi
Yedidyah Bar David has posted comments on this change.
Change subject: core: rewrite buildSequence using toposort
..
Patch Set 3:
> as I explained the priority is a hint per design, it is here to stay, at
> least in this major
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: disable 'Remove' for OVF store not in ILLEGAL status
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_m
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Added validation on managed custom mount option
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_check
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: isRemoveCommandAvailable() - removal of unneeded
booleans
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-
automat...@ovirt.org has posted comments on this change.
Change subject: core: Added validation on managed custom mount option
..
Patch Set 1:
* Update tracker::#1129597::OK
* Check Bug-Url::OK
* Check Public Bug::#1129597::OK,
Tal Nisan has uploaded a new change for review.
Change subject: core: Added validation on managed custom mount option
..
core: Added validation on managed custom mount option
When adding a new NFS/Posix storage server connection
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Allow SD maintenance with suspended vms
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: SanStorageModel - ensure discover proposal
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checks
Omer Frenkel has posted comments on this change.
Change subject: core: Allow SD maintenance with suspended vms
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32201
To unsubscribe, visit http://gerrit.ovir
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tools: StorageDomainOvfStoreCount config value
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_merged/470/ : SUC
automat...@ovirt.org has posted comments on this change.
Change subject: core: Allow SD maintenance with suspended vms
..
Patch Set 1:
* Update tracker::#1061194::OK
* Check Bug-Url::OK
* Check Public Bug::#1061194::OK, public
Omer Frenkel has uploaded a new change for review.
Change subject: core: Allow SD maintenance with suspended vms
..
core: Allow SD maintenance with suspended vms
Suspended vms are actually down, so not actively using the storage
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: SanStorageModel - ensure discover proposal
..
Patch Set 1:
* Update tracker::#1134867::OK
* Check Bug-Url::OK
* Check Public Bug::#1134867::OK,
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: SanStorageModel - ensure discover proposal
..
webadmin: SanStorageModel - ensure discover proposal
iSCSI storage dialog:
ensure that 'Discover Targets'
oVirt Jenkins CI Server has posted comments on this change.
Change subject: history: updated etl to check valid installation
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/ovirt-dwh_master_create-rpms_gerrit/37
Daniel Erez has posted comments on this change.
Change subject: webadmin: Make all disk size setting in DiskModel type safe
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32195
To unsubscribe, visit ht
automat...@ovirt.org has posted comments on this change.
Change subject: history: updated etl to check valid installation
..
Patch Set 9:
* Update tracker::#1118350::OK
--
To view, visit http://gerrit.ovirt.org/31871
To unsub
oVirt Jenkins CI Server has posted comments on this change.
Change subject: history: updated etl to check valid installation
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/ovirt-dwh_master_create-rpms_gerrit/36
Daniel Erez has posted comments on this change.
Change subject: webadmin: New disk dialog does not validate the size value
..
Patch Set 3: Code-Review+2
oops, didn't notice you changed it as well :) just please verify no view s
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: AddVmTemplate - check perms on target SDs
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_
automat...@ovirt.org has posted comments on this change.
Change subject: history: updated etl to check valid installation
..
Patch Set 8:
* Update tracker::#1118350::OK
--
To view, visit http://gerrit.ovirt.org/31871
To unsub
Daniel Erez has posted comments on this change.
Change subject: webadmin: New disk dialog does not validate the size value
..
Patch Set 3:
seems it should be fixed also in DisksAllocationItemView -> edit (line 163)
--
To view
Daniel Erez has posted comments on this change.
Change subject: webadmin: New disk dialog does not validate the size value
..
Patch Set 3: -Code-Review
--
To view, visit http://gerrit.ovirt.org/32051
To unsubscribe, visit http
Daniel Erez has posted comments on this change.
Change subject: webadmin: New disk dialog does not validate the size value
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32051
To unsubscribe, visit htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: create OVF store as non shareable on gluster domain
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_me
Alon Bar-Lev has posted comments on this change.
Change subject: core: rewrite buildSequence using toposort
..
Patch Set 3:
as I explained the priority is a hint per design, it is here to stay, at least
in this major.
--
To
automat...@ovirt.org has posted comments on this change.
Change subject: core: AddVmTemplate - check perms on target SDs
..
Patch Set 1:
* Update tracker::#961053::OK
* Check Bug-Url::OK
* Check Public Bug::#961053::OK, public
Daniel Erez has uploaded a new change for review.
Change subject: core: AddVmTemplate - check perms on target SDs
..
core: AddVmTemplate - check perms on target SDs
Make Template:
When VM contains disks, check permissions on eac
Alon Bar-Lev has posted comments on this change.
Change subject: core: Update hibernate-validator version
..
Patch Set 1: Code-Review+1
maybe one huge patch to sync all artifact :)
--
To view, visit http://gerrit.ovirt.org/32
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: ForceSelectSPM might fail
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle_gerrit/935/ :
SUCC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: disable 'Remove' for OVF store not in ILLEGAL status
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: isRemoveCommandAvailable() - removal of unneeded
booleans
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_c
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Adjust network panel height to fit arrows
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkst
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: SpmStopOnIrs - set result
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle_gerrit/934/ :
SUCC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: add logging to SpmStopVDSCommand
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle_gerrit/933/
Tal Nisan has posted comments on this change.
Change subject: core: ForceSelectSPM might fail
..
Patch Set 3:
There's a conflict in AuditLogType which reverts another patch, please fix
manually and reack
--
To view, visit ht
automat...@ovirt.org has posted comments on this change.
Change subject: core: ForceSelectSPM might fail
..
Patch Set 3:
* Update tracker::#1119852::OK
* Check Bug-Url::OK
* Check Public Bug::#1119852::OK, public bug
* Check Pr
Tal Nisan has submitted this change and it was merged.
Change subject: core: SpmStopOnIrs - set result
..
core: SpmStopOnIrs - set result
When executing SpmStopOnIrs we should set the return value to be
as the return value of t
automat...@ovirt.org has posted comments on this change.
Change subject: core: add logging to SpmStopVDSCommand
..
Patch Set 2:
* Update tracker::#1130766::OK
* Check TR::#1130766::OK
* Set MODIFIED::bug 1130766#1130766
automat...@ovirt.org has posted comments on this change.
Change subject: core: SpmStopOnIrs - set result
..
Patch Set 3:
* Update tracker::#1119852::OK
* Update tracker::#1130222::OK
* Set MODIFIED::bug 1119852#1119852I
Tal Nisan has submitted this change and it was merged.
Change subject: core: add logging to SpmStopVDSCommand
..
core: add logging to SpmStopVDSCommand
currently SpmStopVdsCommand performs nothing in case of tasks return by
the
automat...@ovirt.org has posted comments on this change.
Change subject: core: SpmStopOnIrs - set result
..
Patch Set 3:
* Update tracker::#1119852::OK
* Update tracker::#1130222::OK
* Check Bug-Url::OK
* Check Public Bug::#111
Tal Nisan has posted comments on this change.
Change subject: core: SpmStopOnIrs - set result
..
Patch Set 3:
Rerun-Hooks: all
--
To view, visit http://gerrit.ovirt.org/32193
To unsubscribe, visit http://gerrit.ovirt.org/sett
automat...@ovirt.org has posted comments on this change.
Change subject: core: SpmStopOnIrs - set result
..
Patch Set 3:
* Update tracker::#1119852::OK
* Update tracker::#1130222::OK
* Check Bug-Url::OK
* Check Public Bug::#111
mooli tayer has posted comments on this change.
Change subject: notifier: send sysUpTime in snmp notifications.
..
Patch Set 3:
> please re-confirm that upstream formal documentation is wrong and you are
> right[1]
>[1] http:/
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: isRemoveCommandAvailable() - removal of unneeded
booleans
..
Patch Set 2:
* Update tracker::#1131845::OK
* Check TR::#1131845::OK
* Set MODIFIE
automat...@ovirt.org has posted comments on this change.
Change subject: core: add logging to SpmStopVDSCommand
..
Patch Set 2:
* Update tracker::#1130766::OK
* Check Bug-Url::OK
* Check Public Bug::#1130766::OK, public bug
* C
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: disable 'Remove' for OVF store not in ILLEGAL status
..
Patch Set 2:
* Update tracker::#1131845::OK
* Check Bug-Url::OK
* Check Public Bug::#113
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: disable 'Remove' for OVF store not in ILLEGAL status
..
Patch Set 2:
* Update tracker::#1131845::OK
* Check TR::#1131845::OK
* Set MODIFIED::bug
1 - 100 of 390 matches
Mail list logo