[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: adding '...' appender to text columns that overflow

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: adding '...' appender to text columns that overflow .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_

[Engine-patches] Change in ovirt-engine[master]: webadmin: gui for adding macPool permissions.

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: gui for adding macPool permissions. .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

[Engine-patches] Change in ovirt-engine[master]: webadmin: refactor—overgrown constructor

2014-08-31 Thread mmucha
Martin Mucha has uploaded a new change for review. Change subject: webadmin: refactor—overgrown constructor .. webadmin: refactor—overgrown constructor - overgrown constructor split to smaller, single purpose methods (I need to

[Engine-patches] Change in ovirt-engine[master]: webadmin: gui for adding macPool permissions.

2014-08-31 Thread mmucha
Martin Mucha has uploaded a new change for review. Change subject: webadmin: gui for adding macPool permissions. .. webadmin: gui for adding macPool permissions. Change-Id: Idb6b442e7eebce367b9008f4b9c1df9ade84745f Signed-off-by

[Engine-patches] Change in ovirt-engine[master]: webadmin: refactor—overgrown constructor

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: refactor—overgrown constructor .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

[Engine-patches] Change in ovirt-engine[master]: restapi: Host Power-Management Refactor (#977674) - WIP

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: restapi: Host Power-Management Refactor (#977674) - WIP .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url foun

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding '...' appender to text columns that overflow

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: adding '...' appender to text columns that overflow .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compi

[Engine-patches] Change in otopi[master]: core: rewrite buildSequence using toposort

2014-08-31 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: core: rewrite buildSequence using toposort .. Patch Set 3: > there is no sense in doing before/after and then priority as it breaks the > before/after stat

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: adding '...' appender to text columns that overflow

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: adding '...' appender to text columns that overflow .. Patch Set 1: * Update tracker::#1122990::OK * Check Bug-Url::OK * Check Public Bug::#1122

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: adding '...' appender to text columns that overflow

2014-08-31 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: webadmin: adding '...' appender to text columns that overflow .. webadmin: adding '...' appender to text columns that overflow Using TextOverflow.ELLIPSIS style

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding '...' appender to text columns that overflow

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: adding '...' appender to text columns that overflow .. Patch Set 3: * Update tracker::#1122990::OK * Check Bug-Url::OK * Check Public Bug::#1122

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding '...' appender to text columns that overflow

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: adding '...' appender to text columns that overflow .. Patch Set 3: * Update tracker::#1122990::OK * Set MODIFIED::bug 1122990#1122990IG

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding '...' appender to text columns that overflow

2014-08-31 Thread alkaplan
Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: adding '...' appender to text columns that overflow .. webadmin: adding '...' appender to text columns that overflow Using TextOverflow.ELLIPSI

[Engine-patches] Change in ovirt-engine[master]: Fix watchdog configuration for localized webadmin

2014-08-31 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: Fix watchdog configuration for localized webadmin .. Patch Set 3: Code-Review+1 same for me, just please provide a proper BZ and I will give +2 -- To view, vis

[Engine-patches] Change in ovirt-engine[master]: core: cleanup - remove unused method

2014-08-31 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: cleanup - remove unused method .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32207 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: core: on clone vm the thin provisioned become clone provisioned

2014-08-31 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: core: on clone vm the thin provisioned become clone provisioned .. Patch Set 1: AddVmAndCloneImageCommand.executeVmCommand() (which is the parent of the CloneVm

[Engine-patches] Change in ovirt-engine[master]: core,webadmin: wording. "... mac range." ——>"... MAC address...

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core,webadmin: wording. "... mac range." ——>"... MAC address range." .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no

[Engine-patches] Change in ovirt-engine[master]: core: Allow SD maintenance with suspended vms

2014-08-31 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: Allow SD maintenance with suspended vms .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32201 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core,webadmin: wording. "... mac range." ——>"... MAC address...

2014-08-31 Thread mmucha
Martin Mucha has uploaded a new change for review. Change subject: core,webadmin: wording. "... mac range." ——>"... MAC address range." .. core,webadmin: wording. "... mac range." ——>"... MAC address range." Change-Id: I5225b2c

[Engine-patches] Change in otopi[master]: core: rewrite buildSequence using toposort

2014-08-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: rewrite buildSequence using toposort .. Patch Set 3: it is not matter now what is a reason, this is how it is working now, and this cannot be changed withi

[Engine-patches] Change in otopi[master]: core: rewrite buildSequence using toposort

2014-08-31 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: core: rewrite buildSequence using toposort .. Patch Set 3: Is there a specific reason why priority is lower priority than before/after? Not just that "it's

[Engine-patches] Change in ovirt-engine[master]: core: cleanup - remove unused method

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: cleanup - remove unused method .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/3212

[Engine-patches] Change in ovirt-engine[master]: core: cleanup - remove unused method

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: cleanup - remove unused method .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

[Engine-patches] Change in ovirt-engine[master]: core: cleanup - remove unused method

2014-08-31 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: core: cleanup - remove unused method .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/32207 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: core: cleanup - remove unused method

2014-08-31 Thread vvolansk
Vered Volansky has uploaded a new change for review. Change subject: core: cleanup - remove unused method .. core: cleanup - remove unused method ImportVmCommnad.isDiskExists() is not used, therefore removed. Change-Id: If71161

[Engine-patches] Change in ovirt-engine[master]: core: Update hibernate-validator version

2014-08-31 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Update hibernate-validator version .. Patch Set 1: Code-Review+1 Ok, now I understand this is what jboss 7.1.1 is providing. -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: aaa: Fix search to search properly for users by groups

2014-08-31 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: Fix search to search properly for users by groups .. Patch Set 2: Hi Eli, sure: We ran into the following scenario: Using the generic-ldap provider we are

[Engine-patches] Change in ovirt-engine[master]: core: Update hibernate-validator version

2014-08-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: Update hibernate-validator version .. Patch Set 1: > No packaging issues here? what issue do you see? -- To view, visit http://gerrit.ovirt.org/32198 To

[Engine-patches] Change in ovirt-engine[master]: core: Update hibernate-validator version

2014-08-31 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Update hibernate-validator version .. Patch Set 1: No packaging issues here? -- To view, visit http://gerrit.ovirt.org/32198 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: ForceSelectSPM might fail

2014-08-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: ForceSelectSPM might fail .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32190 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: core: Added validation on managed custom mount option

2014-08-31 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Added validation on managed custom mount option .. Patch Set 1: Code-Review-1 The same validation should also be done when editing a domain and/or a conn

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: Checking isProvisioned instead of the redundant entity isDis...

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Checking isProvisioned instead of the redundant entity isDiscovered .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.5_c

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: Checking isProvisioned instead of the redundant entity isDis...

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Checking isProvisioned instead of the redundant entity isDiscovered .. Patch Set 1: * Update tracker::#1133540::OK * Check Bug-Url::OK * Check Public Bug

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: Checking isProvisioned instead of the redundant entity isDis...

2014-08-31 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: Checking isProvisioned instead of the redundant entity isDiscovered .. Checking isProvisioned instead of the redundant entity isDiscovered isDiscovered was a

[Engine-patches] Change in ovirt-engine[master]: webadmin: Make all disk size setting in DiskModel type safe

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Make all disk size setting in DiskModel type safe .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_dao-uni

[Engine-patches] Change in ovirt-engine[master]: webadmin: New disk dialog does not validate the size value

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: New disk dialog does not validate the size value .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: New disk dialog does not validate the size value

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: New disk dialog does not validate the size value .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_che

[Engine-patches] Change in ovirt-engine[master]: webadmin: Make all disk size setting in DiskModel type safe

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Make all disk size setting in DiskModel type safe .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: New disk dialog does not validate the size value

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: New disk dialog does not validate the size value .. Patch Set 1: * Update tracker::#1115471::OK * Check Bug-Url::OK * Check Public Bug::#1115471

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: New disk dialog does not validate the size value

2014-08-31 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: webadmin: New disk dialog does not validate the size value .. webadmin: New disk dialog does not validate the size value The size field is defined as as an entity m

[Engine-patches] Change in ovirt-engine[master]: webadmin: Make all disk size setting in DiskModel type safe

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: Make all disk size setting in DiskModel type safe .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url

[Engine-patches] Change in ovirt-engine[master]: webadmin: Make all disk size setting in DiskModel type safe

2014-08-31 Thread tnisan
Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Make all disk size setting in DiskModel type safe .. webadmin: Make all disk size setting in DiskModel type safe Since the size entity in DiskMode

[Engine-patches] Change in ovirt-engine[master]: webadmin: Make all disk size setting in DiskModel type safe

2014-08-31 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: webadmin: Make all disk size setting in DiskModel type safe .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/32195 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: webadmin: Make all disk size setting in DiskModel type safe

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: Make all disk size setting in DiskModel type safe .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url f

[Engine-patches] Change in ovirt-engine[master]: webadmin: New disk dialog does not validate the size value

2014-08-31 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: webadmin: New disk dialog does not validate the size value .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/32051 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: webadmin: New disk dialog does not validate the size value

2014-08-31 Thread tnisan
Tal Nisan has submitted this change and it was merged. Change subject: webadmin: New disk dialog does not validate the size value .. webadmin: New disk dialog does not validate the size value The size field is defined as as an

[Engine-patches] Change in ovirt-engine[master]: webadmin: New disk dialog does not validate the size value

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: New disk dialog does not validate the size value .. Patch Set 4: * Update tracker::#1115471::OK * Check TR::#1115471::ERROR, 3.5.0 should not ma

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: add logging to SpmStopVDSCommand

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: add logging to SpmStopVDSCommand .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_merged/474/ : SUCCESS ht

[Engine-patches] Change in otopi[master]: core: rewrite buildSequence using toposort

2014-08-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: rewrite buildSequence using toposort .. Patch Set 3: i guess it was still not clear... we cannot modify the ordering algorithm throughout the major version

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: SpmStopOnIrs - set result

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: SpmStopOnIrs - set result .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_merged/473/ : SUCCESS http://je

[Engine-patches] Change in otopi[master]: core: rewrite buildSequence using toposort

2014-08-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: rewrite buildSequence using toposort .. Patch Set 3: > I didn't see any design document. the code is the design, the priority has second priority in orderi

[Engine-patches] Change in otopi[master]: core: rewrite buildSequence using toposort

2014-08-31 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: core: rewrite buildSequence using toposort .. Patch Set 3: > as I explained the priority is a hint per design, it is here to stay, at > least in this major

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: disable 'Remove' for OVF store not in ILLEGAL status

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: disable 'Remove' for OVF store not in ILLEGAL status .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_m

[Engine-patches] Change in ovirt-engine[master]: core: Added validation on managed custom mount option

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Added validation on managed custom mount option .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_check

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: isRemoveCommandAvailable() - removal of unneeded b...

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: isRemoveCommandAvailable() - removal of unneeded booleans .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-

[Engine-patches] Change in ovirt-engine[master]: core: Added validation on managed custom mount option

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Added validation on managed custom mount option .. Patch Set 1: * Update tracker::#1129597::OK * Check Bug-Url::OK * Check Public Bug::#1129597::OK,

[Engine-patches] Change in ovirt-engine[master]: core: Added validation on managed custom mount option

2014-08-31 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: core: Added validation on managed custom mount option .. core: Added validation on managed custom mount option When adding a new NFS/Posix storage server connection

[Engine-patches] Change in ovirt-engine[master]: core: Allow SD maintenance with suspended vms

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Allow SD maintenance with suspended vms .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_g

[Engine-patches] Change in ovirt-engine[master]: webadmin: SanStorageModel - ensure discover proposal

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: SanStorageModel - ensure discover proposal .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checks

[Engine-patches] Change in ovirt-engine[master]: core: Allow SD maintenance with suspended vms

2014-08-31 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Allow SD maintenance with suspended vms .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/32201 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: tools: StorageDomainOvfStoreCount config value

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: StorageDomainOvfStoreCount config value .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_merged/470/ : SUC

[Engine-patches] Change in ovirt-engine[master]: core: Allow SD maintenance with suspended vms

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Allow SD maintenance with suspended vms .. Patch Set 1: * Update tracker::#1061194::OK * Check Bug-Url::OK * Check Public Bug::#1061194::OK, public

[Engine-patches] Change in ovirt-engine[master]: core: Allow SD maintenance with suspended vms

2014-08-31 Thread ofrenkel
Omer Frenkel has uploaded a new change for review. Change subject: core: Allow SD maintenance with suspended vms .. core: Allow SD maintenance with suspended vms Suspended vms are actually down, so not actively using the storage

[Engine-patches] Change in ovirt-engine[master]: webadmin: SanStorageModel - ensure discover proposal

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: SanStorageModel - ensure discover proposal .. Patch Set 1: * Update tracker::#1134867::OK * Check Bug-Url::OK * Check Public Bug::#1134867::OK,

[Engine-patches] Change in ovirt-engine[master]: webadmin: SanStorageModel - ensure discover proposal

2014-08-31 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: webadmin: SanStorageModel - ensure discover proposal .. webadmin: SanStorageModel - ensure discover proposal iSCSI storage dialog: ensure that 'Discover Targets'

[Engine-patches] Change in ovirt-dwh[master]: history: updated etl to check valid installation

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: history: updated etl to check valid installation .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/ovirt-dwh_master_create-rpms_gerrit/37

[Engine-patches] Change in ovirt-engine[master]: webadmin: Make all disk size setting in DiskModel type safe

2014-08-31 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Make all disk size setting in DiskModel type safe .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32195 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-dwh[master]: history: updated etl to check valid installation

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: history: updated etl to check valid installation .. Patch Set 9: * Update tracker::#1118350::OK -- To view, visit http://gerrit.ovirt.org/31871 To unsub

[Engine-patches] Change in ovirt-dwh[master]: history: updated etl to check valid installation

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: history: updated etl to check valid installation .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/ovirt-dwh_master_create-rpms_gerrit/36

[Engine-patches] Change in ovirt-engine[master]: webadmin: New disk dialog does not validate the size value

2014-08-31 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: New disk dialog does not validate the size value .. Patch Set 3: Code-Review+2 oops, didn't notice you changed it as well :) just please verify no view s

[Engine-patches] Change in ovirt-engine[master]: core: AddVmTemplate - check perms on target SDs

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: AddVmTemplate - check perms on target SDs .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_

[Engine-patches] Change in ovirt-dwh[master]: history: updated etl to check valid installation

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: history: updated etl to check valid installation .. Patch Set 8: * Update tracker::#1118350::OK -- To view, visit http://gerrit.ovirt.org/31871 To unsub

[Engine-patches] Change in ovirt-engine[master]: webadmin: New disk dialog does not validate the size value

2014-08-31 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: New disk dialog does not validate the size value .. Patch Set 3: seems it should be fixed also in DisksAllocationItemView -> edit (line 163) -- To view

[Engine-patches] Change in ovirt-engine[master]: webadmin: New disk dialog does not validate the size value

2014-08-31 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: New disk dialog does not validate the size value .. Patch Set 3: -Code-Review -- To view, visit http://gerrit.ovirt.org/32051 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: webadmin: New disk dialog does not validate the size value

2014-08-31 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: New disk dialog does not validate the size value .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32051 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: create OVF store as non shareable on gluster domain

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: create OVF store as non shareable on gluster domain .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_me

[Engine-patches] Change in otopi[master]: core: rewrite buildSequence using toposort

2014-08-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: rewrite buildSequence using toposort .. Patch Set 3: as I explained the priority is a hint per design, it is here to stay, at least in this major. -- To

[Engine-patches] Change in ovirt-engine[master]: core: AddVmTemplate - check perms on target SDs

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: AddVmTemplate - check perms on target SDs .. Patch Set 1: * Update tracker::#961053::OK * Check Bug-Url::OK * Check Public Bug::#961053::OK, public

[Engine-patches] Change in ovirt-engine[master]: core: AddVmTemplate - check perms on target SDs

2014-08-31 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: core: AddVmTemplate - check perms on target SDs .. core: AddVmTemplate - check perms on target SDs Make Template: When VM contains disks, check permissions on eac

[Engine-patches] Change in ovirt-engine[master]: core: Update hibernate-validator version

2014-08-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: Update hibernate-validator version .. Patch Set 1: Code-Review+1 maybe one huge patch to sync all artifact :) -- To view, visit http://gerrit.ovirt.org/32

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: ForceSelectSPM might fail

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: ForceSelectSPM might fail .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle_gerrit/935/ : SUCC

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: disable 'Remove' for OVF store not in ILLEGAL status

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: disable 'Remove' for OVF store not in ILLEGAL status .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: isRemoveCommandAvailable() - removal of unneeded b...

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: isRemoveCommandAvailable() - removal of unneeded booleans .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.5_c

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adjust network panel height to fit arrows

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Adjust network panel height to fit arrows .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkst

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: SpmStopOnIrs - set result

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: SpmStopOnIrs - set result .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle_gerrit/934/ : SUCC

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: add logging to SpmStopVDSCommand

2014-08-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: add logging to SpmStopVDSCommand .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle_gerrit/933/

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: ForceSelectSPM might fail

2014-08-31 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: ForceSelectSPM might fail .. Patch Set 3: There's a conflict in AuditLogType which reverts another patch, please fix manually and reack -- To view, visit ht

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: ForceSelectSPM might fail

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: ForceSelectSPM might fail .. Patch Set 3: * Update tracker::#1119852::OK * Check Bug-Url::OK * Check Public Bug::#1119852::OK, public bug * Check Pr

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: SpmStopOnIrs - set result

2014-08-31 Thread tnisan
Tal Nisan has submitted this change and it was merged. Change subject: core: SpmStopOnIrs - set result .. core: SpmStopOnIrs - set result When executing SpmStopOnIrs we should set the return value to be as the return value of t

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: add logging to SpmStopVDSCommand

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: add logging to SpmStopVDSCommand .. Patch Set 2: * Update tracker::#1130766::OK * Check TR::#1130766::OK * Set MODIFIED::bug 1130766#1130766

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: SpmStopOnIrs - set result

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: SpmStopOnIrs - set result .. Patch Set 3: * Update tracker::#1119852::OK * Update tracker::#1130222::OK * Set MODIFIED::bug 1119852#1119852I

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: add logging to SpmStopVDSCommand

2014-08-31 Thread tnisan
Tal Nisan has submitted this change and it was merged. Change subject: core: add logging to SpmStopVDSCommand .. core: add logging to SpmStopVDSCommand currently SpmStopVdsCommand performs nothing in case of tasks return by the

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: SpmStopOnIrs - set result

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: SpmStopOnIrs - set result .. Patch Set 3: * Update tracker::#1119852::OK * Update tracker::#1130222::OK * Check Bug-Url::OK * Check Public Bug::#111

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: SpmStopOnIrs - set result

2014-08-31 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: SpmStopOnIrs - set result .. Patch Set 3: Rerun-Hooks: all -- To view, visit http://gerrit.ovirt.org/32193 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: SpmStopOnIrs - set result

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: SpmStopOnIrs - set result .. Patch Set 3: * Update tracker::#1119852::OK * Update tracker::#1130222::OK * Check Bug-Url::OK * Check Public Bug::#111

[Engine-patches] Change in ovirt-engine[master]: notifier: send sysUpTime in snmp notifications.

2014-08-31 Thread mtayer
mooli tayer has posted comments on this change. Change subject: notifier: send sysUpTime in snmp notifications. .. Patch Set 3: > please re-confirm that upstream formal documentation is wrong and you are > right[1] >[1] http:/

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: isRemoveCommandAvailable() - removal of unneeded b...

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: isRemoveCommandAvailable() - removal of unneeded booleans .. Patch Set 2: * Update tracker::#1131845::OK * Check TR::#1131845::OK * Set MODIFIE

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: add logging to SpmStopVDSCommand

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: add logging to SpmStopVDSCommand .. Patch Set 2: * Update tracker::#1130766::OK * Check Bug-Url::OK * Check Public Bug::#1130766::OK, public bug * C

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: disable 'Remove' for OVF store not in ILLEGAL status

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: disable 'Remove' for OVF store not in ILLEGAL status .. Patch Set 2: * Update tracker::#1131845::OK * Check Bug-Url::OK * Check Public Bug::#113

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: disable 'Remove' for OVF store not in ILLEGAL status

2014-08-31 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: disable 'Remove' for OVF store not in ILLEGAL status .. Patch Set 2: * Update tracker::#1131845::OK * Check TR::#1131845::OK * Set MODIFIED::bug

  1   2   3   4   >