Oved Ourfali has posted comments on this change.
Change subject: tools: support for deprecating config values.
..
Patch Set 4:
Martin - please verify.
--
To view, visit http://gerrit.ovirt.org/29295
To unsubscribe, visit http
automat...@ovirt.org has posted comments on this change.
Change subject: host-deploy: use cpio instead of tar for bundle transfer
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit http://gerrit.ovir
Alon Bar-Lev has abandoned this change.
Change subject: host-deploy: use cpio instead of tar for bundle transfer
..
Abandoned
the pyar is better solution
--
To view, visit http://gerrit.ovirt.org/17396
To unsubscribe, visit h
Moti Asayag has posted comments on this change.
Change subject: tools: support for deprecating config values.
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29295
To unsubscribe, visit http://gerrit.ov
automat...@ovirt.org has posted comments on this change.
Change subject: tools: support for deprecating config values.
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: core: Fix potential NPE
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit http://ge
Oved Ourfali has posted comments on this change.
Change subject: core: Fix potential NPE
..
Patch Set 4: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22283
To unsubscribe, visit http://gerrit.ovirt.org/se
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Fix potential NPE
..
core: Fix potential NPE
Fix a potential NPE around setting task status.
This issue was reported by coverity
Change-Id: I9f82f
Oved Ourfali has posted comments on this change.
Change subject: core: Adding some ctors tests.
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29391
To unsubscribe, visit http://gerrit.ovirt.org/settin
Oved Ourfali has posted comments on this change.
Change subject: tools: support for deprecating config values.
..
Patch Set 3:
Moti - can you ack?
--
To view, visit http://gerrit.ovirt.org/29295
To unsubscribe, visit http://g
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Comment in IrsProxyData
..
core: Comment in IrsProxyData
Fixed a comment in IrsProxyData.handleSpmStatusResult:
1. Grammar fix: intentional->inten
automat...@ovirt.org has posted comments on this change.
Change subject: core: Use equals in IrsProxyData
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Use equals in IrsProxyData
..
core: Use equals in IrsProxyData
Replaced "spmVdsId != selectedVds.argvalue.getId()" with
"!spmVdsId.equals(selectedV
Oved Ourfali has posted comments on this change.
Change subject: core: Comment in IrsProxyData
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28448
To unsubscribe, visit http://gerrit.ovirt.org/setting
automat...@ovirt.org has posted comments on this change.
Change subject: core: Comment in IrsProxyData
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit htt
Oved Ourfali has posted comments on this change.
Change subject: core: Use equals in IrsProxyData
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28449
To unsubscribe, visit http://gerrit.ovirt.org/sett
automat...@ovirt.org has posted comments on this change.
Change subject: core: Fix potential NPE
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
Oved Ourfali has posted comments on this change.
Change subject: core: Change duplicate audit log values to unique ones
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29740
To unsubscribe, visit http:/
Oved Ourfali has posted comments on this change.
Change subject: core: Remove unused query types in VdcQueryType
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29793
To unsubscribe, visit http://gerrit
Oved Ourfali has posted comments on this change.
Change subject: core: Add uniqueness test to AuditLogValue
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29741
To unsubscribe, visit http://gerrit.ovir
Oved Ourfali has posted comments on this change.
Change subject: core: Remove static member initialization from a config value
..
Patch Set 4:
Tal - please verify+merge.
--
To view, visit http://gerrit.ovirt.org/29778
To unsu
Oved Ourfali has posted comments on this change.
Change subject: core: Remove unused action types in VdcActionType
..
Patch Set 4:
Tal - can you verify+merge?
--
To view, visit http://gerrit.ovirt.org/29777
To unsubscribe, vi
Oved Ourfali has posted comments on this change.
Change subject: core: Change duplicate action type values to unique ones
..
Patch Set 4:
Tal - can you verify+ merge?
--
To view, visit http://gerrit.ovirt.org/29776
To unsubsc
Oved Ourfali has posted comments on this change.
Change subject: core, userportal: Cannot add AD group to a new VM from the user
portal
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29818
To unsubscr
Oved Ourfali has posted comments on this change.
Change subject: core, userportal: Cannot add AD group to a new VM from the user
portal
..
Patch Set 3:
requires backport to 3.5 and 3.4 branches.
--
To view, visit http://gerr
automat...@ovirt.org has posted comments on this change.
Change subject: core, userportal: Cannot add AD group to a new VM from the user
portal
..
Patch Set 3:
* Update tracker::#1114041::OK
* Check Bug-Url::OK
* Check Public
Oved Ourfali has posted comments on this change.
Change subject: webadmin: Keep validation/event message if there is an iso
update to ovirt node host
..
Patch Set 5: Code-Review+1
findbugs doesn't seem related.
Alexander - ple
Oved Ourfali has posted comments on this change.
Change subject: engine : Command Executor should persist command before
submitting to threadpool
..
Patch Set 5: Code-Review+1
(1 comment)
just one question to make sure we're
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Use equals in IrsProxyData
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12562/ :
SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Comment in IrsProxyData
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12561/ :
SUCCESS
h
Allon Mureinik has posted comments on this change.
Change subject: core: move getNewMaster to ReconstructMasterDomain
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28444
To unsubscribe, visit http://g
Allon Mureinik has posted comments on this change.
Change subject: core: encapsulate isLastMaster logic
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28445
To unsubscribe, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: core: decouple recovery and reconstruct master domain
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28443
To unsubscribe, visit http:
Allon Mureinik has posted comments on this change.
Change subject: core: create ReconstructMasterDomain validators
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/28624/5/backend/manager/modules/bll/src/test/java/org/o
Allon Mureinik has posted comments on this change.
Change subject: core: create ReconstructMasterDomain validators
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28624
To unsubscribe, visit http://gerr
Allon Mureinik has posted comments on this change.
Change subject: core: remove unneeded _newMasterStorageDomainId
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28442
To unsubscribe, visit http://gerr
Allon Mureinik has posted comments on this change.
Change subject: core: spm local in DeactivateStorageDomainCommand
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28441
To unsubscribe, visit http://ge
Allon Mureinik has posted comments on this change.
Change subject: core: early domain check in electNewMaster
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28229
To unsubscribe, visit http://gerrit.ov
Allon Mureinik has posted comments on this change.
Change subject: core: fix getNewMaster duringReconstruct flag
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28336
To unsubscribe, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: early pool check in electNewMaster
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28228
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: simplify isInactive handling in deactivation
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29159
To unsubscribe, visit http://g
Allon Mureinik has posted comments on this change.
Change subject: core: simplify connectAndRefreshAllUpHosts
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28335
To unsubscribe, visit http://gerrit.ov
Allon Mureinik has posted comments on this change.
Change subject: core: Use equals in IrsProxyData
..
Patch Set 2: Verified+1
Rebased
--
To view, visit http://gerrit.ovirt.org/28449
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: fix ReconstructMasterDomainCommand constructor
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/30047
To unsubscribe, visit http:/
Allon Mureinik has posted comments on this change.
Change subject: core: Added VM memory validation on snapshot
..
Patch Set 4:
(7 comments)
Generally +1, see minor comments inside.
Also, jenkins seems to complain the test fa
Allon Mureinik has posted comments on this change.
Change subject: core: Comment in IrsProxyData
..
Patch Set 2: Verified+1
Rebased
--
To view, visit http://gerrit.ovirt.org/28448
To unsubscribe, visit http://gerrit.ovirt.org
automat...@ovirt.org has posted comments on this change.
Change subject: core: Use equals in IrsProxyData
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: core: Comment in IrsProxyData
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Allon Mureinik has posted comments on this change.
Change subject: core: Adding log when retrieving entities from tar
..
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.ovirt.org/#/c/30101/1//COMMIT_MSG
Commit Message:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: cluster sorting
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_merged/55/ : SUCCESS
--
To view,
Allon Mureinik has posted comments on this change.
Change subject: core: Use audit log only when failed to use retrieve command.
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30061
To unsubscribe, vis
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: host tab sorting
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_merged/54/ : SUCCESS
--
To view
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: user main tab sorting
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_merged/53/ : SUCCESS
--
To
Allon Mureinik has posted comments on this change.
Change subject: core: remove 'final' keyword from private methods
..
Patch Set 3: Code-Review+1
pending +1 from a frontend maintainer.
--
To view, visit http://gerrit.ovirt.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Event tab sorting
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_merged/52/ : SUCCESS
--
To vie
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine,userportal,webadmin: configurable unsupported locales
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs
Arik Hadas has posted comments on this change.
Change subject: core: add managed virtio-serial devices on upgrade
..
Patch Set 2: -Verified
--
To view, visit http://gerrit.ovirt.org/29840
To unsubscribe, visit http://gerrit.ov
Arik Hadas has posted comments on this change.
Change subject: core: update blank template origin type
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/30111
To unsubscribe, visit http://gerrit.ovirt.org
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: cluster sorting
..
webadmin: cluster sorting
- Implemented sorting in cluster main tab
- Implemented sorting in cluster sub tabs.
- Fixed bug that
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: cluster sorting
..
Patch Set 3:
* Update tracker::#1119873::OK
* Check TR::#1119873::ERROR, --- should match ^3.[543210].*
--
To view, visit h
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: host tab sorting
..
webadmin: host tab sorting
- Implemented sorting in hosts main tab
- Implemented sorting in hosts sub tabs.
- Did NOT implem
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: host tab sorting
..
Patch Set 2:
* Update tracker::#1119873::OK
* Set MODIFIED::bug 1119873#1119873IGNORE, not all related patches are
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: user main tab sorting
..
Patch Set 2:
* Update tracker::#1119873::OK
* Set MODIFIED::bug 1119873#1119873IGNORE, not all related patches
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: user main tab sorting
..
webadmin: user main tab sorting
- Implemented sorting on Users main tab
- No sorting on email.
- Implemented sorting on
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: Event tab sorting
..
Patch Set 2:
* Update tracker::#1119873::OK
* Set MODIFIED::bug 1119873#1119873IGNORE, not all related patches are
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Event tab sorting
..
webadmin: Event tab sorting
- Implemented sorting for Events main tab
- Not implemented for event id, cluster.
Change-Id:
automat...@ovirt.org has posted comments on this change.
Change subject: engine,userportal,webadmin: configurable unsupported locales
..
Patch Set 2:
* Update tracker::#1096525::OK
* Set MODIFIED::bug 1096525#1096525IGN
Tal Nisan has submitted this change and it was merged.
Change subject: engine,userportal,webadmin: configurable unsupported locales
..
engine,userportal,webadmin: configurable unsupported locales
- Added UnsupportedDisplayedLoc
oVirt Jenkins CI Server has posted comments on this change.
Change subject: frontend: Refactor Vm Behavior classes
..
Patch Set 5: -Code-Review -Verified
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: cluster sorting
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/30124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: user main tab sorting
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/30125
To unsubscribe, visit http://gerrit.ovirt.org/sett
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: host tab sorting
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/30126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Event tab sorting
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/30127
To unsubscribe, visit http://gerrit.ovirt.org/settings
Vojtech Szocs has posted comments on this change.
Change subject: engine,userportal,webadmin: configurable unsupported locales
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/30122
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: frontend: Refactor Vm Behavior classes
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Event tab sorting
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle_gerrit/90/ :
SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: host tab sorting
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle_gerrit/89/ :
SUCCESS
h
Alexander Wels has posted comments on this change.
Change subject: webadmin: host tab sorting
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/30126
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Alexander Wels has posted comments on this change.
Change subject: webadmin: Event tab sorting
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/30127
To unsubscribe, visit http://gerrit.ovirt.org/settings
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: Event tab sorting
..
Patch Set 1:
* Update tracker::#1119873::OK
* Check Bug-Url::OK
* Check Public Bug::#1119873::OK, public bug
* Check Produc
Alexander Wels has uploaded a new change for review.
Change subject: webadmin: Event tab sorting
..
webadmin: Event tab sorting
- Implemented sorting for Events main tab
- Not implemented for event id, cluster.
Change-Id: I02
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: host tab sorting
..
Patch Set 1:
* Update tracker::#1119873::OK
* Check Bug-Url::OK
* Check Public Bug::#1119873::OK, public bug
* Check Product
Alexander Wels has uploaded a new change for review.
Change subject: webadmin: host tab sorting
..
webadmin: host tab sorting
- Implemented sorting in hosts main tab
- Implemented sorting in hosts sub tabs.
- Did NOT implement
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: user main tab sorting
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle_gerrit/88/ :
SUCCE
Alexander Wels has posted comments on this change.
Change subject: webadmin: user main tab sorting
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/30125
To unsubscribe, visit http://gerrit.ovirt.org/settin
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: user main tab sorting
..
Patch Set 1:
* Update tracker::#1119873::OK
* Check Bug-Url::OK
* Check Public Bug::#1119873::OK, public bug
* Check Pr
Alexander Wels has uploaded a new change for review.
Change subject: webadmin: user main tab sorting
..
webadmin: user main tab sorting
- Implemented sorting on Users main tab
- No sorting on email.
- Implemented sorting on Us
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: cluster sorting
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle_gerrit/87/ :
SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: cluster sorting
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle_gerrit/86/ :
SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: allow read-only for VirtIO-SCSI DirectLUN disks
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_ger
Alexander Wels has posted comments on this change.
Change subject: webadmin: cluster sorting
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/30124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: cluster sorting
..
Patch Set 2: -Verified
* Update tracker::#1119873::OK
* Check Bug-Url::OK
* Check Public Bug::#1119873::OK, public bug
* Chec
Alexander Wels has uploaded a new change for review.
Change subject: webadmin: cluster sorting
..
webadmin: cluster sorting
- Implemented sorting in cluster main tab
- Implemented sorting in cluster sub tabs.
- Fixed bug that wo
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: cluster sorting
..
Patch Set 1: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is required
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine,userportal,webadmin: configurable unsupported locales
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_c
Ondřej Macháček has posted comments on this change.
Change subject: aaa: Fixing search to search by authz
..
Patch Set 7:
Hi Yair,
will this fix also
https://bugzilla.redhat.com/show_bug.cgi?id=1118251 ?
Please take a look at
Daniel Erez has uploaded a new change for review.
Change subject: core: allow read-only for VirtIO-SCSI DirectLUN disks
..
core: allow read-only for VirtIO-SCSI DirectLUN disks
In order to support read-only property for VirtIO-S
automat...@ovirt.org has posted comments on this change.
Change subject: core: allow read-only for VirtIO-SCSI DirectLUN disks
..
Patch Set 1:
* Update tracker::#1118847::OK
* Check Bug-Url::OK
* Check Public Bug::#1118847::OK,
automat...@ovirt.org has posted comments on this change.
Change subject: engine,userportal,webadmin: configurable unsupported locales
..
Patch Set 1:
* Update tracker::#1096525::OK
* Check Bug-Url::OK
* Check Public Bug::#10965
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine,userportal,webadmin: configurable unsupported locales
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-
1 - 100 of 792 matches
Mail list logo