Oved Ourfali has submitted this change and it was merged. Change subject: core: Use equals in IrsProxyData ......................................................................
core: Use equals in IrsProxyData Replaced "spmVdsId != selectedVds.argvalue.getId()" with "!spmVdsId.equals(selectedVds.argvalue.getId())". As Guids are objects and not primitives, they should be compared with equals for equality, and not with == for identity. Change-Id: I23b751e35d87aa83ca02a41fcd3680519da143b6 Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23b751e35d87aa83ca02a41fcd3680519da143b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
