Allon Mureinik has posted comments on this change. Change subject: core: create ReconstructMasterDomain validators ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/28624/5/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommandTest.java: Line 67: doReturn(storagePoolValidator).when(cmd).createStoragePoolValidator(); Line 68: Line 69: } Line 70: Line 71: public void testCanDoActionDomainInProcess(StorageDomainStatus status) { JUnit 3 defines a test method as a public void method who's name starts with "test", and some old runners will fail on such methods. Can you rename it please? Perhaps assertCanDoActionDomainInProcess(StorageDomainStatus status) ? Line 72: storagePoolIsoMap.setStatus(status); Line 73: Line 74: CanDoActionTestUtils.runAndAssertCanDoActionFailure(cmd, Line 75: VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_STATUS_ILLEGAL2); -- To view, visit http://gerrit.ovirt.org/28624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b8c4727336c5df28f06566f7cb05c1871fcb000 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
