[Engine-patches] Change in ovirt-engine[master]: core: VdsManager - no need to cache config values

2014-07-12 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: VdsManager - no need to cache config values .. Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/27375/9/backend/manager/modules/vdsbroker/src/main/java/or

[Engine-patches] Change in ovirt-engine[master]: core: monitoring - split VDS and VMs monitoring apart

2014-07-12 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: monitoring - split VDS and VMs monitoring apart .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/27920/5/backend/manager/modules/vdsbroker/src/test/jav

[Engine-patches] Change in ovirt-engine[master]: core: VdsManger - rename fields to fit convention

2014-07-12 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: VdsManger - rename fields to fit convention .. Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/27378/11/backend/manager/modules/vdsbroker/src/main/java/

[Engine-patches] Change in ovirt-engine[master]: core: VdsManger - rename fields to fit convention

2014-07-12 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: VdsManger - rename fields to fit convention .. Patch Set 11: (2 comments) http://gerrit.ovirt.org/#/c/27378/11/backend/manager/modules/vdsbroker/src/main/java

[Engine-patches] Change in ovirt-engine[master]: core: added missing constructor

2014-07-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: added missing constructor .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12263/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: added missing constructor

2014-07-12 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: added missing constructor .. Patch Set 1: * Update tracker::#1117810::OK -- To view, visit http://gerrit.ovirt.org/29985 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: added missing constructor

2014-07-12 Thread oourfali
Oved Ourfali has abandoned this change. Change subject: core: added missing constructor .. Abandoned -- To view, visit http://gerrit.ovirt.org/29985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: a

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: added missing constructor

2014-07-12 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: added missing constructor .. Patch Set 1: * Update tracker::#1117810::OK -- To view, visit http://gerrit.ovirt.org/29986 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: added missing constructor

2014-07-12 Thread oourfali
Oved Ourfali has abandoned this change. Change subject: core: added missing constructor .. Abandoned -- To view, visit http://gerrit.ovirt.org/29986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: a

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: added missing constructor

2014-07-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: added missing constructor .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle_gerrit/37/ : SUCCE

[Engine-patches] Change in ovirt-engine[master]: webadmin: introduce disk profiles

2014-07-12 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: introduce disk profiles .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/29672/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/e

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core : [AAA] NPE is raised when searching user in domain by ...

2014-07-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core : [AAA] NPE is raised when searching user in domain by lastname .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.5_

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: added missing constructor

2014-07-12 Thread oourfali
Oved Ourfali has uploaded a new change for review. Change subject: core: added missing constructor .. core: added missing constructor Change-Id: I06314d2d1fc3ab88504230b3cb7caa4545a0d0d2 Bug-Url: https://bugzilla.redhat.com/1117

[Engine-patches] Change in ovirt-engine[master]: core: added missing constructor

2014-07-12 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: added missing constructor .. Patch Set 1: * Update tracker::#1117810::OK * Check Bug-Url::OK * Check Public Bug::#1117810::OK, public bug * Check Pr

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: added missing constructor

2014-07-12 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: added missing constructor .. Patch Set 1: * Update tracker::#1117810::OK * Check Bug-Url::OK * Check Public Bug::#1117810::OK, public bug * Check Pr

[Engine-patches] Change in ovirt-engine[master]: core: added missing constructor

2014-07-12 Thread oourfali
Oved Ourfali has uploaded a new change for review. Change subject: core: added missing constructor .. core: added missing constructor Change-Id: I06314d2d1fc3ab88504230b3cb7caa4545a0d0d2 Bug-Url: https://bugzilla.redhat.com/1117

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core : [AAA] NPE is raised when searching user in domain by ...

2014-07-12 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core : [AAA] NPE is raised when searching user in domain by lastname .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29984 To unsubscrib

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core : [AAA] NPE is raised when searching user in domain by ...

2014-07-12 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core : [AAA] NPE is raised when searching user in domain by lastname .. Patch Set 1: * Update tracker::#1117240::OK * Check Bug-Url::OK * Check Public Bu

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core : [AAA] NPE is raised when searching user in domain by ...

2014-07-12 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: core : [AAA] NPE is raised when searching user in domain by lastname .. core : [AAA] NPE is raised when searching user in domain by lastname NPE when searching

[Engine-patches] Change in ovirt-dwh[ovirt-engine-dwh-3.4]: packaging: Added release notes

2014-07-12 Thread sradco
Shirly Radco has posted comments on this change. Change subject: packaging: Added release notes .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/29983 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-dwh[ovirt-engine-dwh-3.4]: packaging: Added release notes

2014-07-12 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: packaging: Added release notes .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/29983 To unsubscribe

[Engine-patches] Change in ovirt-dwh[ovirt-engine-dwh-3.4]: packaging: Added release notes

2014-07-12 Thread sradco
Shirly Radco has posted comments on this change. Change subject: packaging: Added release notes .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/29983 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-dwh[ovirt-engine-dwh-3.4]: packaging: Added release notes

2014-07-12 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: packaging: Added release notes .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/29983 To unsubscribe

[Engine-patches] Change in ovirt-dwh[ovirt-engine-dwh-3.4]: packaging: Added release notes

2014-07-12 Thread sradco
Shirly Radco has uploaded a new change for review. Change subject: packaging: Added release notes .. packaging: Added release notes Change-Id: I6959b3d1eaeb616d9ac4aef52a88553e8ee0be2a Signed-off-by: Shirly Radco --- M ovirt-en

[Engine-patches] Change in ovirt-engine[master]: aaa: reactivate user

2014-07-12 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: reactivate user .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29974/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUse

[Engine-patches] Change in ovirt-engine[master]: aaa: reactivate user

2014-07-12 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: reactivate user .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29974/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserC

[Engine-patches] Change in ovirt-engine[master]: aaa: reactivate user

2014-07-12 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: reactivate user .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29974/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUse

[Engine-patches] Change in ovirt-engine[master]: aaa: reactivate user

2014-07-12 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: reactivate user .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29974/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserC

[Engine-patches] Change in ovirt-engine[master]: aaa: reactivate user

2014-07-12 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: reactivate user .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29974/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUse

[Engine-patches] Change in ovirt-engine[master]: aaa: reactivate user

2014-07-12 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: reactivate user .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29974/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserC

[Engine-patches] Change in ovirt-engine[master]: aaa: reactivate user

2014-07-12 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: reactivate user .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29974/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUse

[Engine-patches] Change in ovirt-engine[master]: core: Add space validation when creating snapshot

2014-07-12 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Add space validation when creating snapshot .. Patch Set 7: -Code-Review Actually, IIUC, you're missing the size calculation for the memory volume. For r

[Engine-patches] Change in ovirt-engine[master]: aaa: reactivate user

2014-07-12 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: reactivate user .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29974/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserC

[Engine-patches] Change in ovirt-engine[master]: aaa: reactivate user

2014-07-12 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: reactivate user .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29974/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUse

[Engine-patches] Change in ovirt-engine[master]: aaa: reactivate user

2014-07-12 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: reactivate user .. Patch Set 1: see the this code in sync that should probably be shared: DirectoryUtils.flatGroups(principal);$

[Engine-patches] Change in ovirt-engine[master]: aaa: reactivate user

2014-07-12 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: reactivate user .. Patch Set 1: so store of DirectoryUser is something you want to share? this always store active, never inactive, right? and it should be

[Engine-patches] Change in ovirt-engine[master]: aaa: reactivate user

2014-07-12 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: reactivate user .. Patch Set 1: If you disagree that re-adding a user should allow also to re-activating it, then there is no point in the refactor introd

[Engine-patches] Change in ovirt-engine[master]: aaa: reactivate user

2014-07-12 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: reactivate user .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29974/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserC

[Engine-patches] Change in ovirt-engine[master]: aaa: reactivate user

2014-07-12 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: reactivate user .. Patch Set 1: Hi, I still do not understand why at AddUser we need to reactivate, sysadmin will not add a user that already been added.

[Engine-patches] Change in ovirt-engine[master]: aaa: fix flatGroups recursive

2014-07-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: fix flatGroups recursive .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_merged/8332/ : SUCCESS http:

[Engine-patches] Change in ovirt-engine[master]: engine: profiles MLA support

2014-07-12 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: engine: profiles MLA support .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29671 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: fix coverity issue

2014-07-12 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: fix coverity issue .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29970 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: fix Live Merge logging

2014-07-12 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: fix Live Merge logging .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29971 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: aaa: reactivate user

2014-07-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: reactivate user .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12262/ : SUCCESS http://jen

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: aaa: fix flatGroups recursive

2014-07-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: fix flatGroups recursive .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle_gerrit/35/ : SUCCESS