Yair Zaslavsky has posted comments on this change. Change subject: aaa: reactivate user ......................................................................
Patch Set 1: If you disagree that re-adding a user should allow also to re-activating it, then there is no point in the refactor introduced at DirectoryUtils, and no code change should occur there. And for "reactiveAndSync" - well, feel free to suggest a better name. I saw that basically the code of a. flat groups b. get db group ids c. active if user is in active d. store in db can be shared between LoginUserCommand and AddUsrCommand. -- To view, visit http://gerrit.ovirt.org/29974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556d8da48a858ce193865e84fb6c7cb4043a8e5b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
