Alon Bar-Lev has posted comments on this change.

Change subject: aaa: reactivate user
......................................................................


Patch Set 1:

Hi,

I still do not understand why at AddUser we need to reactivate, sysadmin will 
not add a user that already been added.

Worse case he will remove and add, which will be valid sequence even without 
this change.

For the login, the term sync and reactivate is somewhat confusing, it is store 
user actually, and I think that considering the above no change within 
DirectoryUtils should be made.

What am I missing?

-- 
To view, visit http://gerrit.ovirt.org/29974
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I556d8da48a858ce193865e84fb6c7cb4043a8e5b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to