Yair Zaslavsky has posted comments on this change.
Change subject: utils: introduce universal utilities (uutils)
..
Patch Set 1:
ok, i gave this list from a quick glance at utils package.
we can advance if you think you added a
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Fix type-casting warnings in
ClusterManageNetworkPopupView and re-arrange it.
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: frontend: Fix incorrect text wrap
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_merge/150/ :
SUCC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Generalize console shortcut config values
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_3.4.0_update_db_to_master_ge
Liran Zelkha has posted comments on this change.
Change subject: core: Host's Compatibility Version doesn't match the Cluster's
Compatibility Version
..
Patch Set 10: Verified+1
--
To view, visit http://gerrit.ovirt.org/2606
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Store rest api session id in http session
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Generalize console shortcut config values
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/593
Alona Kaplan has posted comments on this change.
Change subject: webadmin: removed caching from EnumTranslator.
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26048
To unsubscribe, visit http://gerrit.
Arik Hadas has submitted this change and it was merged.
Change subject: engine: Generalize console shortcut config values
..
engine: Generalize console shortcut config values
This patch generalizes configuration names for short
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Generalize console shortcut config values
..
Patch Set 2:
* #1083766::Update tracker: OK
* #1083766::Set MODIFIED: IGNORE, not oVirt prod but Red
Arik Hadas has posted comments on this change.
Change subject: engine: Generalize console shortcut config values
..
Patch Set 2: Code-Review+2 Verified+1
--
To view, visit http://gerrit.ovirt.org/26880
To unsubscribe, visit ht
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Generalize console shortcut config values
..
Patch Set 2:
* #1083766::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engin
Arik Hadas has posted comments on this change.
Change subject: engine: Generalize console shortcut config values
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26880
To unsubscribe, visit http://gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tools: Add runtime log4j setup to engine-config
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/1737
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Distinguish between manual fence resulted..
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_merge
automat...@ovirt.org has posted comments on this change.
Change subject: core: Add common methods for runtime log4j setup
..
Patch Set 2:
* #1063901::Update tracker: OK
* #1083411::Update tracker: OK
* #1063901::Set MODIFIED: I
Oved Ourfali has posted comments on this change.
Change subject: tools: Add runtime log4j setup to engine-config
..
Patch Set 2:
please re-review + re-verify.
--
To view, visit http://gerrit.ovirt.org/26821
To unsubscribe, vi
automat...@ovirt.org has posted comments on this change.
Change subject: tools: Add runtime log4j setup to engine-config
..
Patch Set 2:
* #1063901::Update tracker: OK
* #1063901::Bug-Url: Correct product oVirt
* #1063901::Bug-
Oved Ourfali has submitted this change and it was merged.
Change subject: tools: Remove EngineConfigCLIParser instance variable from
EngineConfig
..
tools: Remove EngineConfigCLIParser instance variable from EngineConfig
Remov
automat...@ovirt.org has posted comments on this change.
Change subject: tools: Remove EngineConfigCLIParser instance variable from
EngineConfig
..
Patch Set 2:
* #1063901::Update tracker: OK
* #1063901::Set MODIFIED: IGNORE,
automat...@ovirt.org has posted comments on this change.
Change subject: tools: Remove logging when parsing args in engine-manage-domains
..
Patch Set 2:
* #1083411::Update tracker: OK
* #1083411::Set MODIFIED: IGNORE, not oVir
automat...@ovirt.org has posted comments on this change.
Change subject: tools: Remove debug log when parsing args in engine-config
..
Patch Set 2:
* #1063901::Update tracker: OK
* #1063901::Set MODIFIED: IGNORE, not all relate
Oved Ourfali has submitted this change and it was merged.
Change subject: tools: Remove logging when parsing args in engine-manage-domains
..
tools: Remove logging when parsing args in engine-manage-domains
Removes log messages
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Add common methods for runtime log4j setup
..
core: Add common methods for runtime log4j setup
Adds Log4jUtils class which contains methods for run
Oved Ourfali has submitted this change and it was merged.
Change subject: tools: Remove debug log when parsing args in engine-config
..
tools: Remove debug log when parsing args in engine-config
Removes debug log messages when
automat...@ovirt.org has posted comments on this change.
Change subject: frontend: Fix incorrect text wrap
..
Patch Set 2:
* #1080322::Update tracker: OK
* #1080322::Set MODIFIED: IGNORE, not oVirt prod but Red Hat Enterprise
Oved Ourfali has submitted this change and it was merged.
Change subject: frontend: Fix incorrect text wrap
..
frontend: Fix incorrect text wrap
In Japanese, caption for remaping control-alt-del is broken into two
lines.
Chang
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: Store rest api session id in http session
..
Patch Set 3:
* #1077448::Update tracker: OK
* #1077448::Target Release: OK
* #1077448::Set MODIFIED
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Store rest api session id in http session
..
webadmin: Store rest api session id in http session
- REST API stores a session id for the UI plug
automat...@ovirt.org has posted comments on this change.
Change subject: core: Distinguish between manual fence resulted..
..
Patch Set 2:
* #1083750::Update tracker: OK
* #1083750::Set MODIFIED: IGNORE, not oVirt prod but Red
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Distinguish between manual fence resulted..
..
core: Distinguish between manual fence resulted..
Distinguish between manual fence resulted from u
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Remove dynamic query from Configure Local Storage
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_te
automat...@ovirt.org has posted comments on this change.
Change subject: core: Host's Compatibility Version doesn't match the Cluster's
Compatibility Version
..
Patch Set 10:
* #1077110::Update tracker: OK
* Bug-Url: IGNORE,
Liran Zelkha has posted comments on this change.
Change subject: webadmin: Remove dynamic query from Configure Local Storage
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/26545
To unsubscribe, visit http
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: Remove dynamic query from Configure Local Storage
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitor
Liran Zelkha has posted comments on this change.
Change subject: webadmin: Remove dynamic query from Configure Local Storage
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26545/2/frontend/webadmin/modules/uicommonweb
Vered Volansky has posted comments on this change.
Change subject: engine: Improve iSCSI Bond CDA validation
..
Patch Set 1: Code-Review+1
(5 comments)
http://gerrit.ovirt.org/#/c/26931/1/backend/manager/modules/bll/src/main/j
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored branch (ovirt-e
Einav Cohen has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/26939
To unsubscribe, visit http://gerrit.ovirt.org
Einav Cohen has uploaded a new change for review.
Change subject: webadmin, userportal: translations update
..
webadmin, userportal: translations update
pulled translation from Zanata oVirt project, master version.
Change-Id: I
Einav Cohen has posted comments on this change.
Change subject: webadmin: Respect line break suggestion in CJK locales
..
Patch Set 1:
@Alex/Greg - can you please review as well?
[I verified on Firefox, in Chrome it doesn't wo
Einav Cohen has posted comments on this change.
Change subject: webadmin: Respect line break suggestion in CJK locales
..
Patch Set 1: Verified+1 Code-Review+1
looks good to me. screen-shots of before and after:
http://i.imgur.
Itamar Heim has posted comments on this change.
Change subject: engine,webadmin: various coverity issues
..
Patch Set 1:
please fix the commit message to say something meaningful on what was fixed,
rather than pointers to some
Project:
http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/
Build:
http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/1814/
Build Number: 1814
Build Status: Fixed
Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/26513
-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Distinguish between manual fence resulted..
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [RFE] Allow to perform fence operations from...
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/5
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [RFE] Allow to perform fence operations from...
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merg
Eli Mesika has posted comments on this change.
Change subject: [RFE] Allow to perform fence operations from...
..
Patch Set 3: Code-Review+2 Verified+1
--
To view, visit http://gerrit.ovirt.org/26513
To unsubscribe, visit http
automat...@ovirt.org has posted comments on this change.
Change subject: [RFE] Allow to perform fence operations from...
..
Patch Set 3:
* #1054778::Update tracker: OK
* #1054778::Target Release: OK
* #1054778::Set MODIFIED: FA
Eli Mesika has submitted this change and it was merged.
Change subject: [RFE] Allow to perform fence operations from...
..
[RFE] Allow to perform fence operations from...
[RFE] Allow to perform fence operations from a host in a
automat...@ovirt.org has posted comments on this change.
Change subject: [RFE] Allow to perform fence operations from...
..
Patch Set 3:
* #1054778::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-
Eli Mesika has posted comments on this change.
Change subject: [RFE] Allow to perform fence operations from...
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26513
To unsubscribe, visit http://gerrit.o
automat...@ovirt.org has posted comments on this change.
Change subject: core: Distinguish between manual fence resulted..
..
Patch Set 2:
* #1083750::Update tracker: OK
* #1083750::Bug-Url: SKIPPED, not oVirt product but Red
Eli Mesika has posted comments on this change.
Change subject: core: Distinguish between manual fence resulted..
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26743
To unsubscribe, visit http://gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ovirt-node-plugin-vdsm: Bump release to 0.1.2-0
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-node-plugin-vdsm-layered/25/ : SU
automat...@ovirt.org has posted comments on this change.
Change subject: ovirt-node-plugin-vdsm: Bump release to 0.1.2-0
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit http://gerrit.ovirt.org/269
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: ovirt-node-plugin-vdsm: Bump release to 0.1.2-0
..
ovirt-node-plugin-vdsm: Bump release to 0.1.2-0
- spec: remove uneeded sed's (BZ#1088218
Douglas Schilling Landgraf has posted comments on this change.
Change subject: ovirt-node-plugin-vdsm: Bump release to 0.1.2-0
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26938
To unsubsc
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ovirt-node-plugin-vdsm: Bump release to 0.1.2-0
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-node-plugin-vdsm-layered/23/ : SU
automat...@ovirt.org has posted comments on this change.
Change subject: ovirt-node-plugin-vdsm: Bump release to 0.1.2-0
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit http://gerrit.ovirt.org/269
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ovirt-node-plugin-vdsm: Bump release to 0.1.2-0
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-node-plugin-vdsm-layered/22/ : SU
automat...@ovirt.org has posted comments on this change.
Change subject: ovirt-node-plugin-vdsm: Bump release to 0.1.2-0
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit http://gerrit.ovirt.org/269
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: ovirt-node-plugin-vdsm: Bump release to 0.1.2-0
..
ovirt-node-plugin-vdsm: Bump release to 0.1.2-0
Change-Id: I3a63fbb45bf6fc2888daa3f636094a90e2a6
Juan Hernandez has posted comments on this change.
Change subject: restapi: Add CSRF protection filter
..
Patch Set 2:
I don't know if the JavaScript engine is excluded by default in Gentoo. If it
is I would consider it a bug.
Alon Bar-Lev has posted comments on this change.
Change subject: restapi: Add CSRF protection filter
..
Patch Set 2:
> The JavaScript engine isn't optional in any version of OpenJDK that I'm aware
> of.
see [1].
I understand
Juan Hernandez has posted comments on this change.
Change subject: restapi: Add CSRF protection filter
..
Patch Set 2:
The JavaScript engine isn't optional in any version of OpenJDK that I'm aware
of.
Masking an IP address is
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: introducing the new extension api
..
Patch Set 34:
(1 comment)
http://gerrit.ovirt.org/#/c/26435/34/backend/manager/modules/extensions-api-root/extensions-a
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: introducing the new extension api
..
Patch Set 34:
(1 comment)
http://gerrit.ovirt.org/#/c/26435/34/backend/manager/modules/extensions-api-root/extensions-a
Alon Bar-Lev has posted comments on this change.
Change subject: restapi: Add CSRF protection filter
..
Patch Set 2:
jscript is optional component of openjdk, I do not believe that for masking ip
address it worth to use option
automat...@ovirt.org has posted comments on this change.
Change subject: core: switched ScopedMacPoolManager to use one pool per data
center.
..
Patch Set 4:
* #1078844::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: handle potential rollbacks
..
Patch Set 5: -Code-Review -Verified
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: move mac pool classes to own package
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/5932/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: fixed javadoc&generics
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/5933/ :
SUCCESS
http:/
automat...@ovirt.org has posted comments on this change.
Change subject: core: handle potential rollbacks
..
Patch Set 5:
* #1078844::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check mer
automat...@ovirt.org has posted comments on this change.
Change subject: core: move mac pool classes to own package
..
Patch Set 5:
* #1078844::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
*
automat...@ovirt.org has posted comments on this change.
Change subject: core: fixed javadoc&generics
..
Patch Set 5:
* #1078844::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: MacPoolManager-->ScopedMacPoolManager
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/5929/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: fixed javadoc&generics
..
Patch Set 4: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: handle potential rollbacks
..
Patch Set 4: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: scoped mac pool manager
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/5927/ :
FAILURE
http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: move mac pool classes to own package
..
Patch Set 4: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_master_uni
automat...@ovirt.org has posted comments on this change.
Change subject: core: move mac pool classes to own package
..
Patch Set 4:
* #1078844::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
*
automat...@ovirt.org has posted comments on this change.
Change subject: core: fixed javadoc&generics
..
Patch Set 4:
* #1078844::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged
automat...@ovirt.org has posted comments on this change.
Change subject: core: handle potential rollbacks
..
Patch Set 4:
* #1078844::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check mer
automat...@ovirt.org has posted comments on this change.
Change subject: core: scoped mac pool manager
..
Patch Set 2:
* #1078844::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged
automat...@ovirt.org has posted comments on this change.
Change subject: core: MacPoolManager-->ScopedMacPoolManager
..
Patch Set 4:
* #1078844::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Simplify "combine" implementation in LinkHelper
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-t
Juan Hernandez has posted comments on this change.
Change subject: restapi: Add CustomProperties member to HostNIC
..
Patch Set 3:
There is nothing wrong with this patch, but I would like to avoid using the
"custom_properties"
Sergey Gotliv has posted comments on this change.
Change subject: restapi: Add REST API support for iSCSI multipathing
..
Patch Set 3:
(3 comments)
You are right, I will add tests.
http://gerrit.ovirt.org/#/c/26225/3/backend/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Simplify "combine" implementation in LinkHelper
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Simplify "combine" implementation in LinkHelper
..
restapi: Simplify "combine" implementation in LinkHelper
Change-Id: I21615f3036083fef2f83cc
automat...@ovirt.org has posted comments on this change.
Change subject: restapi: Simplify "combine" implementation in LinkHelper
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED: IGNORE, no Bug-Url fou
Juan Hernandez has posted comments on this change.
Change subject: restapi: Simplify "combine" implementation in LinkHelper
..
Patch Set 2: Code-Review+2
Thanks Sergey.
--
To view, visit http://gerrit.ovirt.org/26935
To unsub
automat...@ovirt.org has posted comments on this change.
Change subject: restapi: Simplify "combine" implementation in LinkHelper
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Bug-Url: IGNORE, not in a monitored
Sergey Gotliv has posted comments on this change.
Change subject: restapi: Simplify "combine" implementation in LinkHelper
..
Patch Set 2: Verified+1
Rebase.
--
To view, visit http://gerrit.ovirt.org/26935
To unsubscribe, vis
Juan Hernandez has posted comments on this change.
Change subject: restapi: Add flag to detect kdump before fencing
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26721
To unsubscribe, visit http://ger
Juan Hernandez has posted comments on this change.
Change subject: restapi: Add kdump config status to Host
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26485
To unsubscribe, visit http://gerrit.ovir
Juan Hernandez has posted comments on this change.
Change subject: restapi: Simplify "combine" implementation in LinkHelper
..
Patch Set 1:
Sergey, can you please rebase this change so that it has no dependencies, then
we can
Juan Hernandez has posted comments on this change.
Change subject: restapi: Simplify "combine" implementation in LinkHelper
..
Patch Set 1: Code-Review+2
Ah, you are right, I was looking at the wrong branch. This class has been
Juan Hernandez has posted comments on this change.
Change subject: restapi: spice: expose support to control the user data transfer
..
Patch Set 15: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26365
To unsubscribe,
1 - 100 of 157 matches
Mail list logo
