Einav Cohen has posted comments on this change.

Change subject: webadmin: Respect line break suggestion in CJK locales
......................................................................


Patch Set 1: Verified+1 Code-Review+1

looks good to me. screen-shots of before and after:
http://i.imgur.com/22PdSow.png

before this patch: if the first line runs out of room, it cuts the word at the 
character at the end of that line, no matter what that character is. 

with this patch: if the first line runs out of room, it will cut the word only 
at "allowed" characters, e.g. zero-width space. this allows to better control 
where words will be cut in case their container is too narrow to contain them 
in a single line.

-- 
To view, visit http://gerrit.ovirt.org/26927
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7737dfdfc8dc4e6be2dd632f14c022d11cdd976
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to