Alon Bar-Lev has posted comments on this change. Change subject: restapi: Add CSRF protection filter ......................................................................
Patch Set 2: > The JavaScript engine isn't optional in any version of OpenJDK that I'm aware > of. see [1]. I understand the motivation, however I do not think that adding jscript usage for engine customization for extension is a local decision for restapi. in this case I truly think that simple netmask should be sufficient. we should have single mechanism to extend the engine, we are now working on the extension interface for the engine which should provide single methodology of extending the engine[2], one of the implementations can delegate to jscript the logic. [1] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-java/icedtea/icedtea-7.2.4.7.ebuild?revision=1.1&view=markup#l236 [2] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-java/icedtea/icedtea-7.2.4.7.ebuild?revision=1.1&view=markup#l236 -- To view, visit http://gerrit.ovirt.org/26578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68f03eeefe5bcb1956036b4a80fef4400c467346 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
