[Engine-patches] Change in ovirt-engine[master]: utils: introduce universal utilities (uutils)

2014-04-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: introduce universal utilities (uutils) .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26924/1/backend/manager/modules/utils/src/main/java/org/ovi

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 22: No, next is bug fixing :) I have more tests to perform. -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: utils: introduce universal utilities (uutils)

2014-04-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: utils: introduce universal utilities (uutils) .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26924/1/backend/manager/modules/utils/src/main/java/org/o

[Engine-patches] Change in ovirt-engine[master]: utils: introduce universal utilities (uutils)

2014-04-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: utils: introduce universal utilities (uutils) .. Patch Set 1: I am in favor of the idea. I think that anything that can be stripped out so others may enjoy it i

[Engine-patches] Change in ovirt-engine[master]: restapi: [WIP] Add REST API support for iSCSI multipathing

2014-04-19 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: restapi: [WIP] Add REST API support for iSCSI multipathing .. Patch Set 2: (1 comment) Patch is still not complete. 1. I'll improve commit message. 2. rsdl_met

[Engine-patches] Change in ovirt-engine[master]: restapi: [WIP] Add REST API support for iSCSI multipathing

2014-04-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: [WIP] Add REST API support for iSCSI multipathing .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_e

[Engine-patches] Change in ovirt-engine[master]: restapi: [WIP] Add REST API support for iSCSI multipathing

2014-04-19 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: restapi: [WIP] Add REST API support for iSCSI multipathing .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26225/1/backend/manager/modules/restapi/inter

[Engine-patches] Change in ovirt-engine[master]: restapi: [WIP] Add REST API support for iSCSI multipathing

2014-04-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: restapi: [WIP] Add REST API support for iSCSI multipathing .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitore

[Engine-patches] Change in ovirt-engine[master]: utils: introduce universal utilities (uutils)

2014-04-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: introduce universal utilities (uutils) .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/589

[Engine-patches] Change in ovirt-engine[master]: utils: introduce universal utilities (uutils)

2014-04-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: introduce universal utilities (uutils) .. Patch Set 1: yair, what do you think? -- To view, visit http://gerrit.ovirt.org/26924 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: utils: introduce universal utilities (uutils)

2014-04-19 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: utils: introduce universal utilities (uutils) .. utils: introduce universal utilities (uutils) a package of packages that may be split out of engine, not directl

[Engine-patches] Change in ovirt-engine[master]: utils: introduce universal utilities (uutils)

2014-04-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: utils: introduce universal utilities (uutils) .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovi

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 22: I think all these should be moved to builtin extensions or not used, or duplicated with sim

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 22: I think you can now also remove maven dependency of engine core classes within builtin and

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 22: (1 comment) Nice! So what is next? apply accounting? http://gerrit.ovirt.org/#/c/26602/22

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 22: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_ge

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 22: 1. deleted extensionsold package 2. fixed search -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 22: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored bra

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 21: great, now you can delete the extensionsold package? -- To view, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-19 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 21: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 21: fixed recursion to use single StringBuilder. Fixed usage of Long->Integer . -- To view,

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-19 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 21: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored bra

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 15: (1 comment) http://gerrit.ovirt.org/#/c/26602/15/backend/manager/modules/builtin-extensio

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 19: (1 comment) http://gerrit.ovirt.org/#/c/26602/19/backend/manager/modules/builtin-extensio

[Engine-patches] Change in ovirt-dwh[master]: packaging: setup: Ask whether to backup the database

2014-04-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Ask whether to backup the database .. Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/26082/7/packaging/setup/plugins/ovirt-engine-setup/

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 20: am I wrong regarding the string buffer and query construction? -- To view, visit http://ge