Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Ask whether to backup the database ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/26082/7/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py: Line 54: Line 55: def abort(self): Line 56: if ( Line 57: self._parent.environment[ Line 58: odwhcons.DBEnv.RESTORE_BACKUP_LATE > I don't mind asking, but it's against our convention to ask during such a l ask during customization... do you want to enforce integrity during setup or defer restore. how does it violate convention? Line 59: ] and Line 60: self._parent._backup Line 61: ): Line 62: self._parent._needRollback = True Line 58: odwhcons.DBEnv.RESTORE_BACKUP_LATE Line 59: ] and Line 60: self._parent._backup Line 61: ): Line 62: self._parent._needRollback = True > Because in principle we can have more logic at this point. An example I tho this logic can be done before creating this transaction object. Line 63: self._parent.logger.warning( Line 64: _('Rollback of DWH database postponed to Stage "Clean up"') Line 65: ) Line 66: else: -- To view, visit http://gerrit.ovirt.org/26082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e113bddaeeb71b00f5a524db0be3a24fa6f9907 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
