Alon Bar-Lev has posted comments on this change. Change subject: utils: introduce universal utilities (uutils) ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26924/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java: Line 20: import org.ovirt.engine.core.common.config.ConfigValues; Line 21: import org.ovirt.engine.core.utils.EngineLocalConfig; Line 22: import org.ovirt.engine.core.uutils.ssh.OpenSSHUtils; Line 23: Line 24: public class EngineEncryptionUtils { > But what about this class? can't people benefit if it will be in uutils as this is *BAD* class, bad implementation, and specific for engine... Line 25: Line 26: private static final Log log = LogFactory.getLog(EngineEncryptionUtils.class); Line 27: Line 28: private static final File keystoreFile; -- To view, visit http://gerrit.ovirt.org/26924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb5dab40276b3363dbd8f2bbba15933b67c5f220 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
