Sahina Bose has posted comments on this change.
Change subject: engine: Remove gluster hooks from db when no servers in cluster
..
Patch Set 1:
http://gerrit.ovirt.org/21754 - posted for testing the command
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Rm GetDiskAlignmentCommand.serialVersionUUID
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Add no-arg constructor to Parameters classes
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_3.3_la
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Add no-argument constructor check
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_3.3_latest_gerrit
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: NPE on new/edit pool
..
Patch Set 5: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21541
To unsubscribe, visit http://gerrit.ovir
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: NPE on new/edit pool
..
webadmin: NPE on new/edit pool
If no DC was up, the new/edit dialog pool failed on NPE.
Similar issue was also on the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Remove mockStorageGuidList
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/2034/
: S
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove HandlersFactory.createVmPoolHandler
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_g
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: NPE on new/edit pool
..
Patch Set 4: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21541
To unsubscribe, visit http://gerrit.ovir
Moti Asayag has posted comments on this change.
Change subject: core: rm JobRepository unused methods
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21747
To unsubscribe, visit http://gerrit.ovirt.org/
Moti Asayag has posted comments on this change.
Change subject: core: AttachNetworkToVdsGroupTest.getNetworkList
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21749
To unsubscribe, visit http://gerrit
Moti Asayag has posted comments on this change.
Change subject: core: rm VmInterfaceManagerTest.createNewNetwork
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21748
To unsubscribe, visit http://gerrit
Itamar Heim has submitted this change and it was merged.
Change subject: core: Add no-arg constructor to Parameters classes
..
core: Add no-arg constructor to Parameters classes
This is required in order to avoid potential seri
Itamar Heim has submitted this change and it was merged.
Change subject: core: Add no-argument constructor check
..
core: Add no-argument constructor check
This patch adds NoArgConstructorCheck to ensure all classes in backend
Oved Ourfali has posted comments on this change.
Change subject: core: ExternalTrustStoreInitializer.FILE_URL_PREFIX
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21750
To unsubscribe, visit http://ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: GetDiskAlignmentCommand.getStorageDomainDao
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_
Allon Mureinik has posted comments on this change.
Change subject: core: rm CommandContext.serialVersionUUID
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21746
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: AttachNetworkToVdsGroupTest.getNetworkList
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21749
To unsubscribe, visit http://gerrit
Gilad Chaplik has posted comments on this change.
Change subject: core: rename method to lowercase in SchedulingManager
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21664
To unsubscribe, v
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: rename method to lowercase in SchedulingManager
..
core: rename method to lowercase in SchedulingManager
Change-Id: I9ac3f31b6ffd2d291be6d48342827
Gilad Chaplik has posted comments on this change.
Change subject: core: rm unused Quotable interface
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21752
To unsubscribe, visit http://gerrit.ovirt.org/s
Allon Mureinik has posted comments on this change.
Change subject: core: rm VmInterfaceManagerTest.createNewNetwork
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21748
To unsubscribe, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: rm JobRepository unused methods
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21747
To unsubscribe, visit http://gerrit.ovirt.org/
Allon Mureinik has posted comments on this change.
Change subject: core: ExternalTrustStoreInitializer.FILE_URL_PREFIX
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21750
To unsubscribe, visit http://ger
Allon Mureinik has posted comments on this change.
Change subject: core: rm unused SessionDataContainer.containsKey
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21753
To unsubscribe, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: rm unused Quotable interface
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21752
To unsubscribe, visit http://gerrit.ovirt.org/set
Alon Bar-Lev has posted comments on this change.
Change subject: gluster: enable glusterd service forcefully
..
Patch Set 1:
As far as I understand the handling of glusterd should be removed from here
into vdsm pre-start as an
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: NPE on new/edit pool
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/2031/
: SUC
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup OpenStackImageProviderProxy
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21751
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: Make LdapQueryExecution immutable
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21686
To unsubscribe, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: core: remove unused EmptyAttributeMapper class
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21681
To unsubscribe, visit http://gerrit.o
Allon Mureinik has submitted this change and it was merged.
Change subject: core: GetDiskAlignmentCommand.getStorageDomainDao
..
core: GetDiskAlignmentCommand.getStorageDomainDao
Removed the unused GetDiskAlignmentCommand.getSt
Allon Mureinik has posted comments on this change.
Change subject: core: rm unused LdapQueryExecutionBuilder.build
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21687
To unsubscribe, visit http://gerrit.
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused empty method in VdsHandler
..
core: Remove unused empty method in VdsHandler
Change-Id: Iad3736231a24947f896169eace0758bc8d1048a8
S
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused ctors from RHDSRootDSE
..
Patch Set 3: Verified+1
@Roy - done.
--
To view, visit http://gerrit.ovirt.org/21692
To unsubscribe, visit http:
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused method from DirectorySearcher
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21680
To unsubscribe, visit http://gerri
Allon Mureinik has submitted this change and it was merged.
Change subject: core: rm RemoveVmHibernationVolumeCommand consts
..
core: rm RemoveVmHibernationVolumeCommand consts
Removed constants that were migrated to VmCommand
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused GSSAPContextSource class
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21682
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: Make LdapCredentials immutable
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21685
To unsubscribe, visit http://gerrit.ovirt.org/s
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused ctors from DefaultRootDSE
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21679
To unsubscribe, visit http://gerrit.ov
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused ctors from IPARootDSE
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21683
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused QueryData.type property
..
core: Remove unused QueryData.type property
This property is saved in the object but never used afterwar
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused code from ADRootDSE
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21678
To unsubscribe, visit http://gerrit.ovirt.or
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove mockStorageGuidList
..
core: Remove mockStorageGuidList
CommonVmPoolWithVmsCommandTestAbstract.mockStorageGuidList(List)
is unused and sho
Allon Mureinik has posted comments on this change.
Change subject: core: rm LdapSearhcExceptionHandler.handleTimeout
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21689
To unsubscribe, visit http://gerri
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Rm GetDiskAlignmentCommand.serialVersionUUID
..
core: Rm GetDiskAlignmentCommand.serialVersionUUID
Since commands are no longer Serializable, the
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused TagsHandler methods
..
core: Remove unused TagsHandler methods
Change-Id: I01e44ce5e7f71f8c2c32d1dbf8969e8c50824966
Signed-off-by:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: CommonPoolWithVms.isVmPoolNameValidLength
..
core: CommonPoolWithVms.isVmPoolNameValidLength
Patch 540a75e0f7bc4b9ed879471d3d830d575c6d6060 remov
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused ctors from ITDSRootDSE
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21684
To unsubscribe, visit http://gerrit.ovirt
Allon Mureinik has submitted this change and it was merged.
Change subject: core: remove HandlersFactory.createVmPoolHandler
..
core: remove HandlersFactory.createVmPoolHandler
Remove unused method.
Change-Id: I5033305edcf4bc1
Allon Mureinik has posted comments on this change.
Change subject: core: rm unused LdapQueryInfo class
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21688
To unsubscribe, visit http://gerrit.ovirt.org/se
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused interface LDAPServer
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21690
To unsubscribe, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: Immutable MultipleLdapQueryExecutionFormatter
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21691
To unsubscribe, visit http://ger
Allon Mureinik has submitted this change and it was merged.
Change subject: core: rm VmTemplateHandler.MarkVmTemplateAsIllegal
..
core: rm VmTemplateHandler.MarkVmTemplateAsIllegal
This method was unused and should thus be remo
Allon Mureinik has posted comments on this change.
Change subject: core: Rm GetDiskAlignmentCommand.serialVersionUUID
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21669
To unsubscribe, vis
Sahina Bose has uploaded a new change for review.
Change subject: engine: Unit test for RemoveVdsCommand
..
engine: Unit test for RemoveVdsCommand
Added unit tests for RemoveVdsCommand's execute
method
Change-Id: Ice3e8b7ee1e35
Allon Mureinik has posted comments on this change.
Change subject: core: Remove mockStorageGuidList
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21668
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: CommonPoolWithVms.isVmPoolNameValidLength
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21667
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: GetDiskAlignmentCommand.getStorageDomainDao
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21670
To unsubscribe, visi
Allon Mureinik has submitted this change and it was merged.
Change subject: core: rm unused class WindowsErrorsTranslationMap
..
core: rm unused class WindowsErrorsTranslationMap
Change-Id: If2a185c9c5154427cd50231141a3c38585df
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused QueryData.type property
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21672
To unsubscribe, visit http
Allon Mureinik has posted comments on this change.
Change subject: core: rm RemoveVmHibernationVolumeCommand consts
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21673
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: remove HandlersFactory.createVmPoolHandler
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21671
To unsubscribe, visit
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused interface Scorable
..
core: Remove unused interface Scorable
Change-Id: Iee297de0bdd2c07ff784acc2bd5b32e59da2435c
Signed-off-by: Al
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused empty method in VdsHandler
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21675
To unsubscribe, visit h
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused TagsHandler methods
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21674
To unsubscribe, visit http://g
Allon Mureinik has posted comments on this change.
Change subject: core: rm VmTemplateHandler.MarkVmTemplateAsIllegal
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21676
To unsubscribe, vis
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: unlock VM on failure to migrate it to server
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master
Allon Mureinik has posted comments on this change.
Change subject: core: rm unused class WindowsErrorsTranslationMap
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21677
To unsubscribe, visi
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused interface Scorable
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21693
To unsubscribe, visit http://ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: show bricks status in volumes table
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerr
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused interface Scorable
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21693
To unsubscribe, visit http://ge
Allon Mureinik has uploaded a new change for review.
Change subject: core: AttachNetworkToVdsGroupTest.getNetworkList
..
core: AttachNetworkToVdsGroupTest.getNetworkList
Removed unused method.
Change-Id: I90ea9ca806d500e07c8896
Allon Mureinik has uploaded a new change for review.
Change subject: core: ExternalTrustStoreInitializer.FILE_URL_PREFIX
..
core: ExternalTrustStoreInitializer.FILE_URL_PREFIX
Remove unused constant.
Change-Id: I8df083543c95d1d
Allon Mureinik has uploaded a new change for review.
Change subject: core: rm VmInterfaceManagerTest.createNewNetwork
..
core: rm VmInterfaceManagerTest.createNewNetwork
Removed unused method.
Change-Id: I74d12f9d5968450a116701
Allon Mureinik has uploaded a new change for review.
Change subject: core: rm unused SessionDataContainer.containsKey
..
core: rm unused SessionDataContainer.containsKey
Change-Id: I9ab7dee562e32657983c11b41189aee884f2880e
Signe
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup OpenStackImageProviderProxy
..
core: Cleanup OpenStackImageProviderProxy
Remove unused methods.
Change-Id: I675fb052b310746dceee0314d7ec2201386e
Allon Mureinik has uploaded a new change for review.
Change subject: core: rm unused Quotable interface
..
core: rm unused Quotable interface
Change-Id: Id3ec01d83eb98c5bf35aba5a4ebe4e68adab454c
Signed-off-by: Allon Mureinik
--
Allon Mureinik has uploaded a new change for review.
Change subject: core: rm CommandContext.serialVersionUUID
..
core: rm CommandContext.serialVersionUUID
Commit 3600344aa41e559ef6fa145c910e82421b194c13 changed CommandContext
t
Allon Mureinik has uploaded a new change for review.
Change subject: core: rm JobRepository unused methods
..
core: rm JobRepository unused methods
Remove various unused update methods from JobRepository and its
implementation.
Allon Mureinik has posted comments on this change.
Change subject: core: rename method to lowercase in DbUserCacheManager
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21663
To unsubscribe, visit http
Allon Mureinik has posted comments on this change.
Change subject: core: rename method to lowercase in SchedulingManager
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21664
To unsubscribe, visit http:
Allon Mureinik has posted comments on this change.
Change subject: core: further handling of unmanaged disk devices
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21731
To unsubscribe, visit http://ger
Allon Mureinik has posted comments on this change.
Change subject: core: further handling of unmanaged disk devices
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21731
To unsubscribe, visit http://ger
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: NPE on new/edit pool
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21541
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: simplify MigrateVmCommand#getAuditLogTypeValue
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21721
To unsubscribe, visit http:/
Arik Hadas has posted comments on this change.
Change subject: core: remove HandlersFactory.createVmPoolHandler
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21671
To unsubscribe, visit http://gerrit.
Arik Hadas has posted comments on this change.
Change subject: core: unlock VM on failure to migrate it to server
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21723
To unsubscribe, visit http://gerrit.o
Sahina Bose has posted comments on this change.
Change subject: engine: Remove gluster hooks from db when no servers in cluster
..
Patch Set 1:
Good point regarding adding test cases for command. There's some refactoring
neede
Allon Mureinik has posted comments on this change.
Change subject: core: remove HandlersFactory.createVmPoolHandler
..
Patch Set 1:
The damn thing is still used.
Trimming this function is a no-brainer, while removing the whole
Vered Volansky has posted comments on this change.
Change subject: engine: Simplify AddExistingFileStorageDomainCommand
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21323
To unsubscribe, visit http:/
Allon Mureinik has posted comments on this change.
Change subject: core: [Fix] Add host hotplug support checks
..
Patch Set 9:
Omer/Roy - any objections to merge this?
--
To view, visit http://gerrit.ovirt.org/21266
To unsubs
Liron Ar has posted comments on this change.
Change subject: core,webadmin: add isVm and isTemplate methods to VmEntityType
..
Patch Set 2: Code-Review+1
(1 comment)
I suggest to have an helper methods in Disk to reduce the nu
Arik Hadas has posted comments on this change.
Change subject: core: fix audit log on migration rerun failure case
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21722
To unsubscribe, visit http://gerrit.
Arik Hadas has posted comments on this change.
Change subject: core: simplify MigrateVmCommand#getAuditLogTypeValue
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21721
To unsubscribe, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: frontend: ignore "class too big" findbug on ApplicationConstants
..
Patch Set 1:
Two (and a half) differences:
1. I'm not sure home much physical memory the Jen
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: allow bricks in root partition
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/20
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin : hide virt-related fields in cluster add network
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster:fix remove brick validator
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/2026/
:
Kanagaraj M has posted comments on this change.
Change subject: webadmin: show bricks status in volumes table
..
Patch Set 2:
(1 comment)
File
frontend/webadmin/modules/web
1 - 100 of 654 matches
Mail list logo
