Allon Mureinik has posted comments on this change.

Change subject: frontend: ignore "class too big" findbug on ApplicationConstants
......................................................................


Patch Set 1:

Two (and a half) differences:
1. I'm not sure home much physical memory the Jenkins slaves hare.
1.5. Continuing the point on (1), I'm not sure what the -Xms -Xmx parameters 
there are.
2. Maven's FindBugs plugin by default /forks/ on each module. I have no idea 
how Jenkin's FindBugs pluging behaves in that regard.

This patch essentially disables a safety threshold built into FindBugs (a 
stupid one, IMHO, but still). Before merging it, I want to make sure it will 
not cause problems in the CI environment.

-- 
To view, visit http://gerrit.ovirt.org/21699
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9e2672cda097af1e0bd43a4cc37671e14c483fa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to