Allon Mureinik has uploaded a new change for review.
Change subject: core: rm JobRepository unused methods
......................................................................
core: rm JobRepository unused methods
Remove various unused update methods from JobRepository and its
implementation.
Change-Id: I0cfb2c69cb81546521ec60b8c02e980dca988efb
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java
2 files changed, 0 insertions(+), 43 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/47/21747/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java
index 7adcdd8..bf5cc84 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java
@@ -1,6 +1,5 @@
package org.ovirt.engine.core.bll.job;
-import java.util.Date;
import java.util.List;
import org.ovirt.engine.core.common.action.VdcActionType;
@@ -38,24 +37,6 @@
* The {@link Job} entity to persist (can't be
<code>null</code>).
*/
void saveJob(Job job);
-
- /**
- * Updates an existing {@link Job} entity with data from the given
instance.
- *
- * @param step
- * The {@link Job} instance, containing data to update (can't
be <code>null</code>).
- */
- void updateJob(final Job job);
-
- /**
- * Updates {@link Job} entity with the last update time of a given instance
- *
- * @param jobId
- * the id of the job instance which should be updated
- * @param lastUpdateTime
- * the last date when the Job was modified
- */
- void updateJobLastUpdateTime(Guid jobId, Date lastUpdateTime);
/**
* Retrieves the {@link Job} entity with the given id.
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java
index 62a57b9..1f51f660 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java
@@ -95,30 +95,6 @@
}
@Override
- public void updateJob(final Job job) {
- TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
-
- @Override
- public Void runInTransaction() {
- jobDao.update(job);
- return null;
- }
- });
- }
-
- @Override
- public void updateJobLastUpdateTime(final Guid jobId, final Date
lastUpdateTime) {
- TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
-
- @Override
- public Void runInTransaction() {
- jobDao.updateJobLastUpdateTime(jobId, lastUpdateTime);
- return null;
- }
- });
- }
-
- @Override
public Job getJob(final Guid jobId) {
Job job = jobDao.get(jobId);
if (job != null) {
--
To view, visit http://gerrit.ovirt.org/21747
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0cfb2c69cb81546521ec60b8c02e980dca988efb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
