Ramesh N has posted comments on this change.
Change subject: engine: Return Volume Rebalance status on rebalance stop
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/19109
To unsubscribe, visit http://gerr
Allon Mureinik has posted comments on this change.
Change subject: core: Disallow force select SPM when Data Center is not up
..
Patch Set 6:
(1 comment)
File
backend/manag
Vinzenz Feenstra has posted comments on this change.
Change subject: agent: Fix python-2.4 compatibility
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19148
To unsubscribe, visit http://gerrit.ovirt.o
Vinzenz Feenstra has posted comments on this change.
Change subject: Packaging: Add the missing dependencies
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18889
To unsubscribe, visit http://gerrit.ovi
Sergey Gotliv has posted comments on this change.
Change subject: engine: Engine has to delete image from DB after VDSM removed it
..
Patch Set 1:
(1 comment)
File
backend/
Sergey Gotliv has posted comments on this change.
Change subject: engine: Add audit log messages to GetAlignmentScanCommand
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/19136
To unsubscribe, visit http:
Sergey Gotliv has posted comments on this change.
Change subject: engine: Add audit log messages to GetAlignmentScanCommand
..
Patch Set 2:
I fixed messages due to Cheryn review.
--
To view, visit http://gerrit.ovirt.org/1913
Sergey Gotliv has posted comments on this change.
Change subject: engine: Add audit log messages to GetAlignmentScanCommand
..
Patch Set 1:
(2 comments)
File
backend/manage
Mike Kolesnik has posted comments on this change.
Change subject: engine: Added profile logging to VM run/VNIC plug
..
Patch Set 3:
(1 comment)
File
backend/manager/modules
Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Gluster volume rebalance status entities
..
Patch Set 24:
(2 comments)
File
backend/manager/
Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Query for gluster volume rebalance status
..
Patch Set 15:
(1 comment)
File
backend/manager/
Itamar Heim has posted comments on this change.
Change subject: packaging: enable overriding default value of an option with
commandline
..
Patch Set 2:
is this still relevant?
--
To view, visit http://gerrit.ovirt.org/9115
Itamar Heim has abandoned this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Abandoned
no activity in a while, though will be happy if licensing is resolved.
otherwise, may
Itamar Heim has abandoned this change.
Change subject: packaging: validate MAC addresses range provided by the user
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/8670
To unsubscribe, visit http://gerrit.ovirt.org/sett
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Engine has to delete image from DB after VDSM removed it
..
engine: Engine has to delete image from DB after VDSM removed it
Engine has to delete image
Yair Zaslavsky has posted comments on this change.
Change subject: engine: application touches a file to detect un orderly shutdown
..
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19102
To unsubscribe,
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine: application touches a file to detect un orderly shutdown
..
engine: application touches a file to detect un orderly shutdown
Used to diagnose u
Vitor de Lima has uploaded a new change for review.
Change subject: packaging: Virtual DMI decode package
..
packaging: Virtual DMI decode package
This introduces a subpackage which provides the dmidecode dependency
in platforms
Arik Hadas has uploaded a new change for review.
Change subject: core: lock VM for whole live snapshot process
..
core: lock VM for whole live snapshot process
VM was used to be locked for the entire live snapshot process only i
Arik Hadas has uploaded a new change for review.
Change subject: core: revert the existing solution for bz 878041
..
core: revert the existing solution for bz 878041
Before having the auto-start VMs runner job, the problem of HA
Yair Zaslavsky has posted comments on this change.
Change subject: engine: application touches a file to detect un orderly shutdown
..
Patch Set 11: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19102
To u
Arik Hadas has uploaded a new change for review.
Change subject: core: trigger auto-start VMs runner job after live snapshot
operation
..
core: trigger auto-start VMs runner job after live snapshot operation
Since live snapshot
Yair Zaslavsky has uploaded a new change for review.
Change subject: Revert "engine : VdsUpdateRuntimeInfo updates the data of a
specific VDS."
..
Revert "engine : VdsUpdateRuntimeInfo updates the data of a specific VDS."
This
Yair Zaslavsky has posted comments on this change.
Change subject: Revert "engine : VdsUpdateRuntimeInfo updates the data of a
specific VDS."
..
Patch Set 1: Verified+1 Code-Review+2
Verified by running some CI jobs with Eyal
Yair Zaslavsky has submitted this change and it was merged.
Change subject: Revert "engine : VdsUpdateRuntimeInfo updates the data of a
specific VDS."
..
Revert "engine : VdsUpdateRuntimeInfo updates the data of a specific VDS.
Juan Hernandez has posted comments on this change.
Change subject: core: Avoid XSS in RedirectServlet
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19153
To unsubscribe, visit http://gerrit.ovirt.org/
Juan Hernandez has posted comments on this change.
Change subject: core: Avoid XSS in RedirectServlet
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19152
To unsubscribe, visit http://gerrit.ovirt.org/
Juan Hernandez has posted comments on this change.
Change subject: core: Avoid XSS in RedirectServlet
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19155
To unsubscribe, visit http://gerrit.ovirt.org/
Juan Hernandez has posted comments on this change.
Change subject: core: Avoid XSS in RedirectServlet
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19156
To unsubscribe, visit http://gerrit.ovirt.org/
Allon Mureinik has posted comments on this change.
Change subject: core: Disallow force select SPM when Data Center is not up
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19123
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: core: move unplugged disks while VM is running
..
Patch Set 1:
(7 comments)
File
backend/manager/modules/bll
Daniel Erez has uploaded a new change for review.
Change subject: rest: VirtIO-SCSI enabled flag
..
rest: VirtIO-SCSI enabled flag
* Added 'virtio_scsi_enabled' boolean to VM/Template resources (api.xsd).
* Set 'VirtioScsiEnable
Einav Cohen has posted comments on this change.
Change subject: engine: sort domain list query results
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18727
To unsubscribe, visit http://gerrit.ovirt.org
Einav Cohen has posted comments on this change.
Change subject: webadmin: Host interface manual refresh
..
Patch Set 1:
(1 comment)
Commit Message
Line 11: - Added manual re
Einav Cohen has submitted this change and it was merged.
Change subject: engine: sort domain list query results
..
engine: sort domain list query results
Changed the domain list query results to be sorted alphabetically, with
t
Daniel Erez has posted comments on this change.
Change subject: webadmin: unescape cell tooltips string values
..
Patch Set 2:
Hmm, do you mean something similar to SafeHtmlWithSafeHtmlTooltipColumn as I've
suggested? I.e. do
Daniel Erez has posted comments on this change.
Change subject: webadmin: unescape cell tooltips string values
..
Patch Set 2:
Hmm, do you mean something similar to SafeHtmlWithSafeHtmlTooltipColumn as I've
suggested? I.e. do
Yaniv Bronhaim has posted comments on this change.
Change subject: engine: application touches a file to detect un orderly shutdown
..
Patch Set 10: Code-Review+1
(1 comment)
...
Daniel Erez has posted comments on this change.
Change subject: webadmin: unescape cell tooltips string values
..
Patch Set 2:
Hmm, do you mean something similar to SafeHtmlWithSafeHtmlTooltipColumn as I've
suggested? I.e. do
Yaniv Bronhaim has posted comments on this change.
Change subject: API: editing host add and update fields - exposing all stored
ssh fields
..
Patch Set 5:
Michael: What is need to be done for final verification for that?
--
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Updated user information in OpenLDAP are not
propagated to engine
..
Patch Set 5:
No need for all the changes with DbUserCacheManager?
Strange, it rea
Yaniv Bronhaim has posted comments on this change.
Change subject: engine: application touches a file to detect un orderly shutdown
..
Patch Set 10:
(1 comment)
Commit Messa
Frank Kobzik has posted comments on this change.
Change subject: engine: Cache spice support for os/compatibility version
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/19137
To unsubscribe, visit http://
Oved Ourfali has posted comments on this change.
Change subject: build: ovirt-hosted-engine-setup-1.0.0-0.3.beta
..
Patch Set 14: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18064
To unsubscribe, visit http://gerri
Omer Frenkel has posted comments on this change.
Change subject: restapi: Update VM pool fail with NPE
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19142
To unsubscribe, visit http://gerrit.ovirt.org
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: unescape cell tooltips string values
..
Patch Set 2:
For SafeHtmlCellWithTooltip, I think the answer to "is SafeHtml value in
getTooltip method alread
Oved Ourfali has posted comments on this change.
Change subject: ux: describe better how to reboot VM
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18909
To unsubscribe, visit http://gerrit.ovirt.org/
Eli Mesika has posted comments on this change.
Change subject: core: Adding job with auto_cleared false...
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19144
To unsubscribe, visit http://gerrit.ovirt.or
Oved Ourfali has posted comments on this change.
Change subject: man: few fixes in documentation
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18929
To unsubscribe, visit http://gerrit.ovirt.org/setti
Eli Mesika has uploaded a new change for review.
Change subject: core: Adding job with auto_cleared false...
..
core: Adding job with auto_cleared false...
Adding job with auto_cleared false, not working correct
v_is_auto_clear
Oved Ourfali has posted comments on this change.
Change subject: packaging: setup: correctly parse stroage domain info
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19115
To unsubscribe, visit http://
Oved Ourfali has posted comments on this change.
Change subject: bin: support --vm-status option
..
Patch Set 7:
(1 comment)
see minor comment.
File src/bin/hosted-engine.i
Tal Nisan has posted comments on this change.
Change subject: core: Disallow force select SPM when Data Center is not up
..
Patch Set 6:
Ok, since the validator also saves the need to add another VdcBllMessage I've
moved to us
Frank Kobzik has posted comments on this change.
Change subject: engine: Cache spice support for os/compatibility version
..
Patch Set 2:
Deleted unused osRepository function hasSpiceSupport and related code.
--
To view, visi
Omer Frenkel has posted comments on this change.
Change subject: core: share a tranlation table of osinfo with DWH
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17767
To unsubscribe, visit http://gerr
Yaniv Dary has posted comments on this change.
Change subject: core: share a tranlation table of osinfo with DWH
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17767
To unsubscribe, visit http://gerrit
Greg Sheremeta has posted comments on this change.
Change subject: engine: sort domain list query results
..
Patch Set 3: Verified+1
Einav, I believe this is ready for merge.
--
To view, visit http://gerrit.ovirt.org/18727
To
Greg Sheremeta has posted comments on this change.
Change subject: engine: sort domain list query results
..
Patch Set 2:
(1 comment)
Commit Message
Line 3: AuthorDate: 2013
Tomas Jelinek has posted comments on this change.
Change subject: engine: nullify EmulatedMachine field only on cluster level
change
..
Patch Set 4:
(1 comment)
File
front
Tomas Jelinek has posted comments on this change.
Change subject: webadmin,userportal: do not add default nic on edit vm
..
Patch Set 4: Verified+1
addressed comments
--
To view, visit http://gerrit.ovirt.org/17315
To unsubsc
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Retain gluster task id on volume when task completes
..
Patch Set 4: -Code-Review
Can you please elaborate more in the commit msg?
Now that I took a sec
Yair Zaslavsky has posted comments on this change.
Change subject: gluster: Gluster volume rebalance status entities
..
Patch Set 24: Code-Review+1
(2 comments)
Minor comments
.
Allon Mureinik has posted comments on this change.
Change subject: core, engine: SCSI CD-ROM on PPC64 VMs
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18622
To unsubscribe, visit http://gerrit.ovirt.
Tal Nisan has posted comments on this change.
Change subject: core: Disallow force select SPM when Data Center is not up
..
Patch Set 5:
(1 comment)
File
backend/manager/mo
Tal Nisan has posted comments on this change.
Change subject: core: Disallow force select SPM when Data Center is not up
..
Patch Set 5:
(1 comment)
File
backend/manager/mo
Allon Mureinik has posted comments on this change.
Change subject: core: rename methods to lowercase in storage commands
..
Patch Set 2: Verified+1 Code-Review+2
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: Disallow force select SPM when Data Center is not up
..
Patch Set 5:
(1 comment)
File
backend/manag
Allon Mureinik has posted comments on this change.
Change subject: core, engine: SCSI CD-ROM on PPC64 VMs
..
Patch Set 1:
Looks OK to me.
Omer/Roy?
--
To view, visit http://gerrit.ovirt.org/18622
To unsubscribe, visit http://
mooli tayer has posted comments on this change.
Change subject: engine: application touches a file to detect un orderly shutdown
..
Patch Set 10: Verified+1
--
To view, visit http://gerrit.ovirt.org/19102
To unsubscribe, visit
Allon Mureinik has submitted this change and it was merged.
Change subject: core: rename methods to lowercase in storage commands
..
core: rename methods to lowercase in storage commands
Change-Id: Ic90230c11cf11fe510c803c69ffa
Allon Mureinik has posted comments on this change.
Change subject: core: Disallow force select SPM when Data Center is not up
..
Patch Set 5:
(2 comments)
File
backend/mana
Allon Mureinik has posted comments on this change.
Change subject: core: rename ExecuteQuery to executeQuery
..
Patch Set 1:
(1 comment)
Commit Message
Line 4: Commit: A
Tal Nisan has posted comments on this change.
Change subject: core: Disallow force select SPM when Data Center is not up
..
Patch Set 5:
(1 comment)
File
backend/manager/mo
Allon Mureinik has posted comments on this change.
Change subject: core: Disallow force select SPM when Data Center is not up
..
Patch Set 5: Code-Review-1
(1 comment)
File
Daniel Erez has posted comments on this change.
Change subject: webadmin: unescape cell tooltips string values
..
Patch Set 2:
Not sure since htmlEscapeAllowEntities also escapes a string, but just leaving
not double-escape ta
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Retain gluster task id on volume when task completes
..
Patch Set 4: Code-Review+1
needs rebasing, but looks good.
--
To view, visit http://gerrit.ovi
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Support for gluster task monitoring
..
Patch Set 7:
(2 comments)
File
backend/manager/modules/bll
Allon Mureinik has posted comments on this change.
Change subject: core: rename methods to lowercase in storage commands
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19139
To unsubscribe, visit http:
Allon Mureinik has posted comments on this change.
Change subject: core: rename ExecuteQuery to executeQuery
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19138
To unsubscribe, visit http://gerrit.ovi
Yair Zaslavsky has posted comments on this change.
Change subject: gluster:VDS command to get gluster tasks list
..
Patch Set 5: Code-Review+1
(1 comment)
Minor comment + please resolve conflicts and rebase.
Looks good besides
Roy Golan has posted comments on this change.
Change subject: engine: nullify EmulatedMachine field only on cluster level
change
..
Patch Set 4:
(2 comments)
File
frontend
Roy Golan has posted comments on this change.
Change subject: engine: nullify EmulatedMachine field only on cluster level
change
..
Patch Set 3:
(1 comment)
File
backend/m
Frank Kobzik has posted comments on this change.
Change subject: engine: Cache spice support for os/compatibility version
..
Patch Set 1:
Note: if this patch is to be merged, HasSpiceSupport query should be removed,
since ther
Allon Mureinik has submitted this change and it was merged.
Change subject: core: fix not closing statement resource leak
..
core: fix not closing statement resource leak
Fix a resource leak caused by not closing a statement by
Allon Mureinik has posted comments on this change.
Change subject: core: fix not closing statement resource leak
..
Patch Set 2: Verified+1 Code-Review+2
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/190
Frank Kobzik has uploaded a new change for review.
Change subject: engine: Cache spice support for os/compatibility version
..
engine: Cache spice support for os/compatibility version
Patch 31903bda17f97c2d785238b3d0d557d3c24f40
Sergey Gotliv has posted comments on this change.
Change subject: engine: Add audit log messages to GetAlignmentScanCommand
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19136
To unsubscribe, visit http:
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Add audit log messages to GetAlignmentScanCommand
..
engine: Add audit log messages to GetAlignmentScanCommand
Change-Id: I4400aea34bd848416e67b7bb77a92
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ExternalSchedulerDiscoveryResult map iter
..
core: ExternalSchedulerDiscoveryResult map iter
Replaced keySet() iteration with entrySet() iteratio
Allon Mureinik has posted comments on this change.
Change subject: core: ExternalSchedulerDiscoveryResult map iter
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, no code changes
--
To view, visit http://gerrit.ovirt.org/18
Allon Mureinik has posted comments on this change.
Change subject: core: move unplugged disks while VM is running
..
Patch Set 1:
@Cheryn, please take a look at
backend/manager/modules/dal/src/main/resources/bundles/AppErrors.
Allon Mureinik has posted comments on this change.
Change subject: core: move unplugged disks while VM is running
..
Patch Set 1:
(7 comments)
File
backend/manager/modules/
Allon Mureinik has submitted this change and it was merged.
Change subject: core: AddTemplate: Remove unused dest sd handling
..
core: AddTemplate: Remove unused dest sd handling
Change-Id I523814cd3c1f64c1ae40624ba50f239f2ceba
Allon Mureinik has posted comments on this change.
Change subject: core: AddTemplate: Remove unused dest sd handling
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org
Yair Zaslavsky has posted comments on this change.
Change subject: core: PM options for secondary agent are not saved
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19119
To unsubscribe, visit http://g
Yair Zaslavsky has posted comments on this change.
Change subject: core: rename TemplateUser role
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18779
To unsubscribe, visit http://gerrit.ovirt.org/sett
Yair Zaslavsky has posted comments on this change.
Change subject: engine : VdsUpdateRuntimeInfo updates the data of a specific
VDS.
..
Patch Set 27: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/16066
To
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine : VdsUpdateRuntimeInfo updates the data of a specific
VDS.
..
engine : VdsUpdateRuntimeInfo updates the data of a specific VDS.
This change mig
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing job dao test
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19131
To unsubscribe, visit http://gerrit.ovirt.or
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fixing job dao test
..
core: Fixing job dao test
Job dao test relies that the first job
is always the same - this assumption may
cause a test to
1 - 100 of 236 matches
Mail list logo
