Tomas Jelinek has posted comments on this change.

Change subject: engine: nullify EmulatedMachine field only on cluster level 
change
......................................................................


Patch Set 4:

(1 comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
Line 289:         obj.setStoragePoolId(instance.getStoragePoolId());
Line 290:         
obj.setmax_vds_memory_over_commit(instance.getmax_vds_memory_over_commit());
Line 291:         obj.setCountThreadsAsCores(instance.getCountThreadsAsCores());
Line 292:         obj.setEmulatedMachine(instance.getEmulatedMachine());
Line 293:         
obj.setDetectEmulatedMachine(instance.isDetectEmulatedMachine());
it is - look at the ClusterListModel.onSaveInternalWithModel
Is there a chance that the server does not send it to the client as a result of 
the search query?
Line 294: 
Line 295:         return obj;
Line 296:     }
Line 297: 


-- 
To view, visit http://gerrit.ovirt.org/18898
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ffb180cfcd56c50b9bc228c0043e6fd5fee1c58
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to