Yair Zaslavsky has posted comments on this change.
Change subject: gluster:VDS command to get gluster tasks list
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Minor comment + please resolve conflicts and rebase.
Looks good besides that.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterTasksListReturnForXmlRpc.java
Line 36: }
Line 37:
Line 38: Map<String, Object> tasksMap = (Map<String, Object>)
innerMap.get(TASKS_LIST);
Line 39: if (tasksMap != null) {
Line 40: Iterator<Entry<String, Object>>
iter=tasksMap.entrySet().iterator();
not that critical , but why not
for (Entry<String,object> entry: tasksMa.entrySet() ) instead of using
iterator?
Line 41: while (iter.hasNext()) {
Line 42: Entry<String, Object> entry=iter.next();
Line 43: tasks.add(getTask(entry.getKey(),(Map<String,
Object>)entry.getValue()));
Line 44: }
--
To view, visit http://gerrit.ovirt.org/15972
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf9c1075cd7b27adcbbff8d71de183f40a02eea
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
