[Engine-patches] Change in ovirt-engine[master]: HostGeneralModel: improve "node has upgrade" logic

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: HostGeneralModel: improve "node has upgrade" logic .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checksty

[Engine-patches] Change in ovirt-engine[master]: HostGeneralModel: improve "node has upgrade" logic

2013-07-19 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: HostGeneralModel: improve "node has upgrade" logic .. Patch Set 6: I would prefer that you didn't submit this I will provide a new version. -- To

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: bridge: attempt to rollback if bridge creation failed

2013-07-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: vdsm: bridge: attempt to rollback if bridge creation failed .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17124

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: bridge: attempt to rollback if bridge creation failed

2013-07-19 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: bridge: attempt to rollback if bridge creation failed .. vdsm: bridge: attempt to rollback if bridge creation failed Currently vdsm-bootstrap, host

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: bridge: attempt to rollback if bridge creation failed

2013-07-19 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: vdsm: bridge: attempt to rollback if bridge creation failed .. vdsm: bridge: attempt to rollback if bridge creation failed Currently vdsm-bootstrap, host-deploy,

[Engine-patches] Change in ovirt-engine[master]: packaging: logging: port notifier to logrotate

2013-07-19 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: logging: port notifier to logrotate .. packaging: logging: port notifier to logrotate Change-Id: If0c14f88fdca4ac61e22a1e2585e2cf163b3dbbd Signed-off-

[Engine-patches] Change in ovirt-engine[master]: packaging: services: move defaults to services

2013-07-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: services: move defaults to services .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17122 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: packaging: introduce the ovirt-engine-lib package

2013-07-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: introduce the ovirt-engine-lib package .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17121 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: bin: added --console command

2013-07-19 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: bin: added --console command .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17114 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: make column width persistent

2013-07-19 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: make column width persistent .. Patch Set 1: (3 inline comments) File frontend/webad

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Frontend refactor

2013-07-19 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: Frontend refactor .. Patch Set 6: Looks good to me, approved > @Vojtech/Derez - are there any remaining issues that Alex should address? I

[Engine-patches] Change in ovirt-engine[master]: core: i18n welcome page with branding

2013-07-19 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: core: i18n welcome page with branding .. Patch Set 7: Looks good to me, approved Patch looks good. Regarding commons-io, I agree with Alex, didn't find any usag

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: make column width persistent

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal, webadmin: make column width persistent .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checksty

[Engine-patches] Change in ovirt-engine[master]: engine: Add GetVnicProfilesByDataCenterIdQuery

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add GetVnicProfilesByDataCenterIdQuery .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g

[Engine-patches] Change in mom[master]: Add list in policy

2013-07-19 Thread liumbj
Mei Liu has posted comments on this change. Change subject: Add list in policy .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/17102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType

[Engine-patches] Change in ovirt-engine[master]: core: i18n welcome page with branding

2013-07-19 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: core: i18n welcome page with branding .. Patch Set 7: @Vojtech - can you please re-review this patch? thanks. -- To view, visit http://gerrit.ovirt.org/16359 To

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Frontend refactor

2013-07-19 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: Frontend refactor .. Patch Set 6: @Vojtech/Derez - are there any remaining issues that Alex should address? -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Upgrade GWT SDK and related modules

2013-07-19 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Upgrade GWT SDK and related modules .. Patch Set 4: Submitted new patch set that fixes the error "The client does not have field _loginResu

[Engine-patches] Change in ovirt-engine[master]: webadmin: Prevent SystemTree from losing selection

2013-07-19 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: Prevent SystemTree from losing selection .. webadmin: Prevent SystemTree from losing selection There are basically two listeners for SystemTreeModel's

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Upgrade GWT SDK and related modules

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin,userportal: Upgrade GWT SDK and related modules .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_ch

[Engine-patches] Change in ovirt-engine[master]: engine: Fix potential NumberFormatException in OsRepositoryI...

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Fix potential NumberFormatException in OsRepositoryImpl .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_com

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix NPE in HostListModel

2013-07-19 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: Fix NPE in HostListModel .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17116 To unsubscri

[Engine-patches] [oVirt Jenkins] ovirt-mom_create_rpms - Build # 106 - Still Failing!

2013-07-19 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-mom_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-mom_create_rpms/106/ Build Number: 106 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: webadmin: Prevent SystemTree from losing selection

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Prevent SystemTree from losing selection .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checksty

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix NPE in HostListModel

2013-07-19 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: Fix NPE in HostListModel .. webadmin: Fix NPE in HostListModel This patch fixes a potential NPE regarding "SSH username" field. Change-Id: I5ef7002d8

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix NPE in HostListModel

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Fix NPE in HostListModel .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/2459/

[Engine-patches] Change in ovirt-engine[master]: engine: Fix potential NumberFormatException in OsRepositoryI...

2013-07-19 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: engine: Fix potential NumberFormatException in OsRepositoryImpl .. engine: Fix potential NumberFormatException in OsRepositoryImpl Added NumberFormatException c

[Engine-patches] Change in ovirt-engine[master]: webadmin: Prevent SystemTree from losing selection

2013-07-19 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: Prevent SystemTree from losing selection .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: bin: extended hosted-engine capabilities

2013-07-19 Thread sbonazzo
Sandro Bonazzola has uploaded a new change for review. Change subject: bin: extended hosted-engine capabilities .. bin: extended hosted-engine capabilities added --vm-destroy for destroying the vm added --start-pool for starting

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: bin: extended hosted-engine capabilities

2013-07-19 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: bin: extended hosted-engine capabilities .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17113 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: engine: Add GetVmsByVnicProfileIdQuery

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add GetVmsByVnicProfileIdQuery .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/24

[Engine-patches] Change in ovirt-engine[master]: engine: Add GetTemplatesByVnicProfileIdQuery

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add GetTemplatesByVnicProfileIdQuery .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ger

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: bin: added --console command

2013-07-19 Thread sbonazzo
Sandro Bonazzola has uploaded a new change for review. Change subject: bin: added --console command .. bin: added --console command Added --console switch to hosted-engine command. Refactored some plugins for having all require

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: bin: extended hosted-engine capabilities

2013-07-19 Thread iheim
Itamar Heim has posted comments on this change. Change subject: bin: extended hosted-engine capabilities .. Patch Set 1: (1 inline comment) Commit Message Line 5: CommitDate:

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: ignore sack cache populate errors

2013-07-19 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: ignore sack cache populate errors .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: [wip] packaging: setup: additional host support

2013-07-19 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: [wip] packaging: setup: additional host support .. Patch Set 2: Verified not breaking first host installation. Need more testing on second host. -- To view,

[Engine-patches] Change in ovirt-engine[master]: core: Move toByteArray() from GuidUtils to Guid

2013-07-19 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Move toByteArray() from GuidUtils to Guid .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17101

[Engine-patches] Change in ovirt-engine[master]: engine: Refactor VnicProfile row mapper

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Refactor VnicProfile row mapper .. Patch Set 4: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit

[Engine-patches] Change in ovirt-engine[master]: engine: Introduce VnicProfileView and its DAO

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Introduce VnicProfileView and its DAO .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge

[Engine-patches] Change in ovirt-engine[master]: engine: Add GetVnicProfilesByNetworkIdQuery

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add GetVnicProfilesByNetworkIdQuery .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ger

[Engine-patches] Change in ovirt-engine[master]: engine: Create a vnic profile implicitly when adding network

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Create a vnic profile implicitly when adding network .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compil

[Engine-patches] Change in ovirt-engine[master]: webadmin: add VnicProfile as main tab

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add VnicProfile as main tab .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/244

[Engine-patches] Change in ovirt-engine[master]: engine, webadmin: Remove network name from NetworkInterface

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine,webadmin: Remove network name from NetworkInterface .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_

[Engine-patches] Change in ovirt-engine[master]: webadmin: network profiles

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: network profiles .. Patch Set 8: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/2454/ : FAI

[Engine-patches] Change in ovirt-engine[master]: engine: Refactor VnicProfile row mapper

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Refactor VnicProfile row mapper .. Patch Set 5: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit

[Engine-patches] Change in ovirt-engine[master]: engine, webadmin: Remove network name from NetworkInterface

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine,webadmin: Remove network name from NetworkInterface .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_

[Engine-patches] Change in ovirt-engine[master]: engine: Add GetVnicProfilesByDataCenterIdQuery

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add GetVnicProfilesByDataCenterIdQuery .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g

[Engine-patches] Change in ovirt-engine[master]: engine, webadmin: Remove network name from NetworkInterface

2013-07-19 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: engine,webadmin: Remove network name from NetworkInterface .. engine,webadmin: Remove network name from NetworkInterface The purpose of the patch is to lay the gr

[Engine-patches] Change in ovirt-engine[master]: engine: Introduce VnicProfileView and its DAO

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Introduce VnicProfileView and its DAO .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge

[Engine-patches] Change in ovirt-engine[master]: engine: Add GetTemplatesByVnicProfileIdQuery

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add GetTemplatesByVnicProfileIdQuery .. Patch Set 6: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g

[Engine-patches] Change in ovirt-engine[master]: engine: Add rename logging capability to UpdateVnic

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add rename logging capability to UpdateVnic .. Patch Set 8: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_check

[Engine-patches] Change in ovirt-engine[master]: webadmin: network profiles

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: network profiles .. Patch Set 7: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/2443/ : FAI

[Engine-patches] Change in ovirt-engine[master]: webadmin: add VnicProfile as main tab

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add VnicProfile as main tab .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/243

[Engine-patches] Change in ovirt-engine[master]: engine: Add audit log messages for vnic profile commands

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add audit log messages for vnic profile commands .. Patch Set 8: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_

[Engine-patches] Change in ovirt-engine[master]: engine: Add GetVmsByVnicProfileIdQuery

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add GetVmsByVnicProfileIdQuery .. Patch Set 6: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/

[Engine-patches] Change in otopi[master]: packagers: yum: ignore sack cache populate errors

2013-07-19 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: yum: ignore sack cache populate errors .. packagers: yum: ignore sack cache populate errors for some reason yum when going to cache only mode

[Engine-patches] Change in otopi[master]: packagers: yum: ignore sack cache populate errors

2013-07-19 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packagers: yum: ignore sack cache populate errors .. packagers: yum: ignore sack cache populate errors for some reason yum when going to cache only mode tries to

[Engine-patches] Change in ovirt-engine[master]: engine: Prevent modifying port mirroring if used by vms

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Prevent modifying port mirroring if used by vms .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_c

[Engine-patches] Change in ovirt-engine[master]: engine: Create a vnic profile implicitly when adding network

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Create a vnic profile implicitly when adding network .. Patch Set 7: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_comp

[Engine-patches] Change in ovirt-engine[master]: engine: Modify custom properties type to map

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Modify custom properties type to map .. Patch Set 8: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g

[Engine-patches] Change in ovirt-engine[master]: engine: Add GetVnicProfilesByNetworkIdQuery

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add GetVnicProfilesByNetworkIdQuery .. Patch Set 9: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: ignore sack cache populate errors

2013-07-19 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: setup: ignore sack cache populate errors .. packaging: setup: ignore sack cache populate errors for some reason yum when going to cache only mode trie

[Engine-patches] Change in ovirt-engine[master]: engine: Prevent modifying port mirroring if used by vms

2013-07-19 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: engine: Prevent modifying port mirroring if used by vms .. engine: Prevent modifying port mirroring if used by vms The patch prevents updating the port mirroring

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: ignore sack cache populate errors

2013-07-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: ignore sack cache populate errors .. Patch Set 1: Verified sync with otopi -- To view, visit http://gerrit.ovirt.org/17108 To unsubscribe, vis

[Engine-patches] Change in otopi[master]: packagers: yum: ignore sack cache populate errors

2013-07-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packagers: yum: ignore sack cache populate errors .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17107 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: engine: renamed validatePinningAndMigration to validateMigra...

2013-07-19 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: engine: renamed validatePinningAndMigration to validateMigrationRules .. Patch Set 1: Looks good to me, but someone else must approve (2 inline comments)

[Engine-patches] Change in ovirt-engine[master]: engine: Fix typo in setter name

2013-07-19 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: engine: Fix typo in setter name .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17022 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: Initial support for alternative architectures

2013-07-19 Thread vitor . lima
Vitor de Lima has posted comments on this change. Change subject: core: Initial support for alternative architectures .. Patch Set 1: (3 inline comments) File backend/manage

[Engine-patches] Change in ovirt-engine[master]: core: Remove password from LdapUser

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Remove password from LdapUser .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/2432/

[Engine-patches] Change in ovirt-engine[master]: core: Remove password from LdapUser

2013-07-19 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Remove password from LdapUser .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17103 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] Change in ovirt-engine[master]: core: Remove password from LdapUser

2013-07-19 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Remove password from LdapUser .. core: Remove password from LdapUser This attribute is no longer used. Change-Id: Ie3390bbbd5fe92c70861ff6dc12435e37d391

[Engine-patches] Change in ovirt-engine[master]: core: Add external identifier to DbUser

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add external identifier to DbUser .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/2

[Engine-patches] Change in ovirt-engine[master]: core: Add external identifier to DbUser

2013-07-19 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Add external identifier to DbUser .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/15749 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in mom[master]: [WIP]Add list in policy

2013-07-19 Thread liumbj
Mei Liu has uploaded a new change for review. Change subject: [WIP]Add list in policy .. [WIP]Add list in policy Change-Id: If46896db09fa1e0a36a77a6b50e103b2f15a4926 Signed-off-by: MeiLiu --- M mom/Policy/Parser.py M tests/Pars

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: upgrade firewalld config

2013-07-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: upgrade firewalld config .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17027 To uns

[Engine-patches] Change in ovirt-engine[master]: packaging: spec: avoid breaking firewalld

2013-07-19 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: spec: avoid breaking firewalld .. Patch Set 5: Verified Rebased -- To view, visit http://gerrit.ovirt.org/17002 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: packaging: spec: avoid breaking firewalld

2013-07-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: spec: avoid breaking firewalld .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17002 To unsu

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: upgrade firewalld config

2013-07-19 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: upgrade firewalld config .. Patch Set 4: Verified Rebased -- To view, visit http://gerrit.ovirt.org/17027 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core: Move toByteArray() from GuidUtils to Guid

2013-07-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Move toByteArray() from GuidUtils to Guid .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_

[Engine-patches] Change in ovirt-engine[master]: core: Move toByteArray() from GuidUtils to Guid

2013-07-19 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Move toByteArray() from GuidUtils to Guid .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17101 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: Move toByteArray() from GuidUtils to Guid

2013-07-19 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Move toByteArray() from GuidUtils to Guid .. core: Move toByteArray() from GuidUtils to Guid This method will soon be needed from classes that are in the

[Engine-patches] Change in otopi[master]: network: firewalld: fix service disabling

2013-07-19 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: network: firewalld: fix service disabling .. network: firewalld: fix service disabling fixed a typo in constant naming fixed default initialization of FI

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: upgrade firewalld config

2013-07-19 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: upgrade firewalld config .. Patch Set 3: I would prefer that you didn't submit this need to rebase against http://gerrit.ovirt.org/17099 --

[Engine-patches] Change in otopi[master]: network: firewalld: fix service disabling

2013-07-19 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: network: firewalld: fix service disabling .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17099 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in otopi[master]: network: firewalld: fix service disabling

2013-07-19 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: network: firewalld: fix service disabling .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17099 To unsubscribe, visit http:/

[Engine-patches] Change in otopi[master]: network: firewalld: fix service disabling

2013-07-19 Thread sbonazzo
Sandro Bonazzola has uploaded a new change for review. Change subject: network: firewalld: fix service disabling .. network: firewalld: fix service disabling fixed a typo in constant naming fixed default initialization of FIREWA