Sandro Bonazzola has uploaded a new change for review.
Change subject: network: firewalld: fix service disabling
......................................................................
network: firewalld: fix service disabling
fixed a typo in constant naming
fixed default initialization of FIREWALLD_DISABLE_SERVICES
avoiding iteration error on boolean value.
Change-Id: I112e51bb69e10875f34ffb6ae3966b1d38e328ba
Signed-off-by: Sandro Bonazzola <sbona...@redhat.com>
---
M src/otopi/constants.py
M src/plugins/otopi/network/firewalld.py
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/otopi refs/changes/99/17099/1
diff --git a/src/otopi/constants.py b/src/otopi/constants.py
index 0f5acb7..343c687 100644
--- a/src/otopi/constants.py
+++ b/src/otopi/constants.py
@@ -154,7 +154,7 @@
FIREWALLD_ENABLE = 'NETWORK/firewalldEnable'
FIREWALLD_AVAILABLE = 'NETWORK/firewalldAvailable'
FIREWALLD_SERVICE_PREFIX = 'NETWORK_FIREWALLD_SERVICE/'
- FIREWALLD_DISBALE_SERVICES = 'NETWORK/firewalldDisableServices'
+ FIREWALLD_DISABLE_SERVICES = 'NETWORK/firewalldDisableServices'
@util.export
diff --git a/src/plugins/otopi/network/firewalld.py
b/src/plugins/otopi/network/firewalld.py
index 765d553..838c024 100644
--- a/src/plugins/otopi/network/firewalld.py
+++ b/src/plugins/otopi/network/firewalld.py
@@ -39,7 +39,7 @@
Environment:
NetEnv.FIREWALLD_ENABLE -- enable firewalld update
NetEnv.FIREWALLD_SERVICE_PREFIX -- services key=service value=content
- NetEnv.FIREWALLD_DISBALE_SERVICES -- list of services to be disabled
+ NetEnv.FIREWALLD_DISABLE_SERVICES -- list of services to be disabled
"""
@@ -139,8 +139,8 @@
False
)
self.environment.setdefault(
- constants.NetEnv.FIREWALLD_DISBALE_SERVICES,
- False
+ constants.NetEnv.FIREWALLD_DISABLE_SERVICES,
+ []
)
@plugin.event(
@@ -228,7 +228,7 @@
#
for zone in self._get_zones():
for service in self.environment[
- constants.NetEnv.FIREWALLD_DISBALE_SERVICES
+ constants.NetEnv.FIREWALLD_DISABLE_SERVICES
]:
self.execute(
(
--
To view, visit http://gerrit.ovirt.org/17099
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I112e51bb69e10875f34ffb6ae3966b1d38e328ba
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
