Itamar Heim has posted comments on this change.

Change subject: bin: extended hosted-engine capabilities
......................................................................


Patch Set 1: (1 inline comment)

....................................................
Commit Message
Line 5: CommitDate: 2013-07-19 15:47:24 +0200
Line 6: 
Line 7: bin: extended hosted-engine capabilities
Line 8: 
Line 9: added --vm-destroy for destroying the vm
i would read "destroy" as delete the VM, not just the running instance (which i 
know libvirt uses).
so iiuc, this will only stop the instance, hence i suggest naming it vm-stop.
Line 10: added --start-pool for starting the storage pool
Line 11: 
Line 12: If the pool is down, the VM will not start due to
Line 13: missing volume. Then you have to destroy the VM


-- 
To view, visit http://gerrit.ovirt.org/17113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea0755188efe0dfe1f61da762d3b0f290b8efd2c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Lev Veyde <lve...@gmail.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to