Allon Mureinik has posted comments on this change.
Change subject: findbugs: use StringBuilder in a for loop
..
Patch Set 1: I would prefer that you didn't submit this
(20 inline comments)
.
Allon Mureinik has posted comments on this change.
Change subject: tools: Proper error testing in EngineConfigCLITest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14424
To unsubscribe, visit http://gerrit.
Allon Mureinik has posted comments on this change.
Change subject: core: Removed std from EncryptionUtilsTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14423
To unsubscribe, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: core: Removed std from KDCLocatorTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14422
To unsubscribe, visit http://gerrit.ovirt.org/set
Allon Mureinik has posted comments on this change.
Change subject: core: Remove stdout from SimpleAuthenticationCheck
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14421
To unsubscribe, visit http://gerrit.
Allon Mureinik has posted comments on this change.
Change subject: core: Remove SearchQueryFormatter.main(String[])
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14420
To unsubscribe, visit http://gerrit.ov
Allon Mureinik has uploaded a new change for review.
Change subject: core: Removed std from EncryptionUtilsTest
..
core: Removed std from EncryptionUtilsTest
Removed printing of results with System.out.println - this is no way t
Allon Mureinik has uploaded a new change for review.
Change subject: tools: Proper error testing in EngineConfigCLITest
..
tools: Proper error testing in EngineConfigCLITest
Converted the error tests in EngineConfigCLITest to th
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove stdout from SimpleAuthenticationCheck
..
core: Remove stdout from SimpleAuthenticationCheck
Removed an old System.out.println call from the class
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove SearchQueryFormatter.main(String[])
..
core: Remove SearchQueryFormatter.main(String[])
SearchQueryFormatter seems to have an old main(String[]) f
Allon Mureinik has uploaded a new change for review.
Change subject: core: Removed std from KDCLocatorTest
..
core: Removed std from KDCLocatorTest
Removed printing of results with System.out.println - this is no way to
handle r
Allon Mureinik has posted comments on this change.
Change subject: core: DirectorySearcherTest proper failures
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14419
To unsubscribe, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: Fix testGetRootDSENoServers
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14418
To unsubscribe, visit http://gerrit.ovirt.org/setting
Allon Mureinik has posted comments on this change.
Change subject: core: Remove DirectorySearcherTest's @BeforeClass
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14417
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: Reduce timeout in DiretorySearcherTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14416
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove DirectorySearcherTest's @BeforeClass
..
core: Remove DirectorySearcherTest's @BeforeClass
This is a POJO test, there is no need to interact with J
Allon Mureinik has uploaded a new change for review.
Change subject: core: Reduce timeout in DiretorySearcherTest
..
core: Reduce timeout in DiretorySearcherTest
Reduced timeout to 1 millisecond instead of 1 second.
The timeout
Allon Mureinik has uploaded a new change for review.
Change subject: core: Fix testGetRootDSENoServers
..
core: Fix testGetRootDSENoServers
Since urls is a zero length list, urls.get(0) throws an
IndexOutOfBoundsException.
This
Allon Mureinik has uploaded a new change for review.
Change subject: core: DirectorySearcherTest proper failures
..
core: DirectorySearcherTest proper failures
Used the proper JUnit 4 syntax for failures - @Test with the expecte
Allon Mureinik has posted comments on this change.
Change subject: core: Remove comparators' empty default ctors
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14415
To unsubscribe, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: Replace FQCNs with imports for comparators
..
Patch Set 2: Verified
Fixed typo in commit message, no code changes
--
To view, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: corei: Replace FQCNs with imports for comparators
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14414
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: Removed comparators' Compare methods
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14413
To unsubscribe, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: core: LexoNumericComparator to comparators pkg
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14412
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: Unused field from SimpleAuthenticationCheck
..
Patch Set 2:
ping?
--
To view, visit http://gerrit.ovirt.org/13870
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has uploaded a new change for review.
Change subject: core: Removed comparators' Compare methods
..
core: Removed comparators' Compare methods
This is probably a leftover from the C# days.
In java, comparators hav
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove comparators' empty default ctors
..
core: Remove comparators' empty default ctors
Removed empty implementation of the default constructor througho
Allon Mureinik has uploaded a new change for review.
Change subject: core: LexoNumericComparator to comparators pkg
..
core: LexoNumericComparator to comparators pkg
Moved LexoNumericComparator to the comparators package, like a
Allon Mureinik has uploaded a new change for review.
Change subject: corei: Replace FQCNs with imports for comparators
..
corei: Replace FQCNs with imports for comparators
Replaced FQCN references with imports throughout the com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove FieldsInVDCConfigXmlToSQL
..
core: Remove FieldsInVDCConfigXmlToSQL
The FieldsInVDCConfigXmlToSQL is no longer in use, and should be
remov
Allon Mureinik has posted comments on this change.
Change subject: core: Remove FieldsInVDCConfigXmlToSQL
..
Patch Set 4: Verified; Looks good to me, approved
Rebased, no changes
--
To view, visit http://gerrit.ovirt.org/14191
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix redundant space in DB upgrade output
..
core: Fix redundant space in DB upgrade output
The run_file function only receives one argument, so $
Allon Mureinik has posted comments on this change.
Change subject: core: Fix redundant space in DB upgrade output
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes
--
To view, visit http://gerrit.ov
Allon Mureinik has posted comments on this change.
Change subject: [WIP] core: Introducing findbugs filter to bll module
..
Patch Set 3:
This patch has been lying here for a couple of weeks, and got three +1s - I
think it's go
Allon Mureinik has posted comments on this change.
Change subject: [WIP] core: Introducing findbugs filter to bll module
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14110
To unsubscribe,
Ravi Nori has posted comments on this change.
Change subject: engine : Use infinispan to cache data
..
Patch Set 3:
rebased on 235864112ad12afdadeafe711c9029b38a27981b
Will work on your comment
--
To view, visit http://gerrit
Alon Bar-Lev has posted comments on this change.
Change subject: notifier: use LocalConfig as configuration file
..
Patch Set 3: Verified
rebase/reorder to ease review
--
To view, visit http://gerrit.ovirt.org/14376
To unsubsc
Alon Bar-Lev has posted comments on this change.
Change subject: notifier: handle port correctly
..
Patch Set 3: Verified
rebase/reorder to ease review
--
To view, visit http://gerrit.ovirt.org/14375
To unsubscribe, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: notifier: switch to log4j
..
Patch Set 3: Verified
rebase/reorder to ease review
--
To view, visit http://gerrit.ovirt.org/14377
To unsubscribe, visit http://ger
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: serve root customizable location resources
..
Patch Set 4: Verified
rebase/reorder to ease review
--
To view, visit http://gerrit.ovirt.org/14354
To u
Alon Bar-Lev has posted comments on this change.
Change subject: pki: move configuration from vdc_options to EngineLocalConfig
..
Patch Set 8: Verified
rebase/reorder to ease review
--
To view, visit http://gerrit.ovirt.org/14
Alon Bar-Lev has posted comments on this change.
Change subject: core: config: support sensitive keys
..
Patch Set 3: Verified
rebase/reorder to ease review
--
To view, visit http://gerrit.ovirt.org/14353
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: core: split LocalConfig to allow code reuse
..
Patch Set 3: Verified
rebase/reorder to ease review
--
To view, visit http://gerrit.ovirt.org/14374
To unsubscribe
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: move all packaging related to packaging
..
Patch Set 5: Verified
rebase/reorder to ease review
--
To view, visit http://gerrit.ovirt.org/14302
To unsu
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine.conf: add quotes to selected keys
..
Patch Set 3: Verified
rebase/reorder to ease review
--
To view, visit http://gerrit.ovirt.org/14352
To uns
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: enigne-service: cleanup to ease reuse
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14372
To unsubscribe, visit http://gerrit.ovir
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: enigne-service: cleanup to ease reuse
..
Patch Set 3:
rebase/reorder to ease review
--
To view, visit http://gerrit.ovirt.org/14372
To unsubscribe, vi
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: cleanup spec file
..
Patch Set 3: Verified
rebase/reorder to ease review
--
To view, visit http://gerrit.ovirt.org/14373
To unsubscribe, visit http://
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: Fix repeated logins due to UI plugin REST API
heartbeat
..
webadmin: Fix repeated logins due to UI plugin REST API heartbeat
This patch addresses a p
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: cleanup spec file
..
Patch Set 2: Verified
Rebase
--
To view, visit http://gerrit.ovirt.org/14373
To unsubscribe, visit http://gerrit.ovirt.org/settin
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: enigne-service: cleanup to ease reuse
..
Patch Set 2: Verified
Rebase
--
To view, visit http://gerrit.ovirt.org/14372
To unsubscribe, visit http://ger
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: move all packaging related to packaging
..
Patch Set 4: Verified
Rebase
--
To view, visit http://gerrit.ovirt.org/14302
To unsubscribe, visit http://g
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: serve root customizable location resources
..
Patch Set 3: Verified
Rebase
--
To view, visit http://gerrit.ovirt.org/14354
To unsubscribe, visit http:
Alon Bar-Lev has posted comments on this change.
Change subject: pki: move configuration from vdc_options to LocalConfig
..
Patch Set 7: Verified
Readd GetCACertificateQuery removed, I thought that only *Command are using
this
Vojtech Szocs has posted comments on this change.
Change subject: userportal: prevent an error dialog in login page
..
Patch Set 1:
Looks good to me.
--
To view, visit http://gerrit.ovirt.org/14392
To unsubscribe, visit http:/
Vojtech Szocs has posted comments on this change.
Change subject: userportal: prevent an error dialog in login page
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin
Einav Cohen has posted comments on this change.
Change subject: userportal: prevent an error dialog in login page
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/m
Einav Cohen has posted comments on this change.
Change subject: userportal: prevent an error dialog in login page
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/m
Vojtech Szocs has posted comments on this change.
Change subject: userportal: prevent an error dialog in login page
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin
Vojtech Szocs has posted comments on this change.
Change subject: webdamin: make the right side of vm->interface sub tab resizable
..
Patch Set 3: Looks good to me, approved
Rebased and updated:
Added 'EntityModelCellTable.add
Einav Cohen has submitted this change and it was merged.
Change subject: core: update splash page locales
..
core: update splash page locales
After merging patch http://gerrit.ovirt.org/#/c/14356/, adjusting the
splash page to
Einav Cohen has posted comments on this change.
Change subject: core: update splash page locales
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/14409
To unsubscribe, visi
Einav Cohen has posted comments on this change.
Change subject: core: update splash page locales
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/root/src/mai
Alexander Wels has posted comments on this change.
Change subject: core: update splash page locales
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/root/src/
Einav Cohen has posted comments on this change.
Change subject: core: update splash page locales
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/root/src/mai
Alexander Wels has posted comments on this change.
Change subject: core: update splash page locales
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
...
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Support column resizing for all tables
..
webadmin,userportal: Support column resizing for all tables
This patch moves column resiz
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Support column resizing for all tables
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14341
To unsubsc
Einav Cohen has posted comments on this change.
Change subject: webadmin,userportal: Support column resizing for all tables
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14341
To unsubscri
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Support column resizing for all tables
..
Patch Set 3: Verified
Rebased, included Daniel's suggestion from patch set 2, here's a list of
ch
Vojtech Szocs has posted comments on this change.
Change subject: core: update splash page locales
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14409
To unsubscribe, visit http://gerrit.o
Einav Cohen has posted comments on this change.
Change subject: core: update splash page locales
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14409
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Einav Cohen has uploaded a new change for review.
Change subject: core: update splash page locales
..
core: update splash page locales
After merging patch http://gerrit.ovirt.org/#/c/14356/, adjusting the
splash page to conform
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal,webadmin: bring back change CD menu to SPICE console
..
userportal,webadmin: bring back change CD menu to SPICE console
This has been lost while movi
Laszlo Hornyak has uploaded a new change for review.
Change subject: engine: search cleanup (1/N)
..
engine: search cleanup (1/N)
A small cleanup in the constructors of BaseAutoCompleter.
Change-Id: Id9ed66b776b82ab68f550833d9e
Laszlo Hornyak has uploaded a new change for review.
Change subject: engine: search remove redundant constructor param (2/N)
..
engine: search remove redundant constructor param (2/N)
Removed a parameter from AutoCompletionField
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Support column resizing for all tables
..
Patch Set 2: (1 inline comment)
File
fronten
Alexander Wels has posted comments on this change.
Change subject: webadmin: Element IDs in Assign Tags and Role dialogs
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Laszlo Hornyak has posted comments on this change.
Change subject: engine: entity snapshot valiadation
..
Patch Set 4:
ping. Can this patch go?
--
To view, visit http://gerrit.ovirt.org/13694
To unsubscribe, visit http://gerri
Laszlo Hornyak has posted comments on this change.
Change subject: engine: replace some parameter classes with IdQueryParameters
..
Patch Set 3:
ping
--
To view, visit http://gerrit.ovirt.org/14260
To unsubscribe, visit http:/
Einav Cohen has posted comments on this change.
Change subject: userportal: prevent an error dialog in login page
..
Patch Set 1: Verified
I tested the patch, and the user portal doesn't show an error-pop-up upon login
failure
Shireesh Anjal has posted comments on this change.
Change subject: engine: Improved duplicate host validation
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14402
To unsubscribe, visit http://gerrit.ovirt.or
Tomas Jelinek has posted comments on this change.
Change subject: userportal: changed Spice to SPICE
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/modules/uicomm
Michal Skrivanek has posted comments on this change.
Change subject: userportal: changed Spice to SPICE
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/modules/uic
Shireesh Anjal has posted comments on this change.
Change subject: engine: Refactoring AddVdsCommand#canDoAction()
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14401
To unsubscribe, visit http://gerrit.ovi
Shireesh Anjal has uploaded a new change for review.
Change subject: engine: Improved duplicate host validation
..
engine: Improved duplicate host validation
Currently, the validation in AddVdsCommand#canDoAction() checks if the
Shireesh Anjal has uploaded a new change for review.
Change subject: engine: Refactoring AddVdsCommand#canDoAction()
..
engine: Refactoring AddVdsCommand#canDoAction()
to use failCanDoAction(), saving few lines of code. Also mad
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal: changed Spice to SPICE
..
userportal: changed Spice to SPICE
Removed the hardcoded Spice string from ConsoleProtocol.
Change-Id: I7e610d12a2966ccff
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Disabling WAN options for SPICE doesn't work
..
frontend: Disabling WAN options for SPICE doesn't work
SPICE -> Enable WAN options causes 16bi
Tomas Jelinek has posted comments on this change.
Change subject: frontend: Disabling WAN options for SPICE doesn't work
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14398
To un
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Spice is always available
..
frontend: Spice is always available
This patch removes the method ConsoleUtils.isSpiceAvailable because it is no
Tomas Jelinek has posted comments on this change.
Change subject: frontend: Spice is always available
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14390
To unsubscribe, visit ht
Tomas Jelinek has posted comments on this change.
Change subject: frontend: Spice is always available
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14390
To unsubscribe, visit http://gerri
Michal Skrivanek has posted comments on this change.
Change subject: frontend: Disabling WAN options for SPICE doesn't work
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Frank Kobzik has uploaded a new change for review.
Change subject: frontend: Disabling WAN options for SPICE doesn't work
..
frontend: Disabling WAN options for SPICE doesn't work
SPICE -> Enable WAN options causes 16bit color d
Arik Hadas has posted comments on this change.
Change subject: engine: Ability to assign multiple VMs from a pool to single
user
..
Patch Set 6: (1 inline comment)
Commit Me
Tomas Jelinek has posted comments on this change.
Change subject: engine: custom properties: allow '=' in regex
..
Patch Set 3: Looks good to me, but someone else must approve
hi Gilad, after a quick look at the sources it seem
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Added encodingvalidator.sh to validation list
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Added generic DB validations before the upgrade
..
Patch Set 17: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
99 matches
Mail list logo
