Vojtech Szocs has posted comments on this change. Change subject: userportal: prevent an error dialog in login page ......................................................................
Patch Set 1: (1 inline comment) .................................................... File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java Line 768 Line 769 Line 770 Line 771 Line 772 Maybe I am missing something, but "translateErrors(failed)" just modifies "failed" - for each VdcReturnValueBase element, updates "CanDoActionMessages". Since "failed" is scoped only to "if (...)" block, isn't "failed" itself redundant? In other words, IIUC "translateErrors(failed)" doesn't have any side effects, and "failed" lives only in scope of "if (...)" block.. -- To view, visit http://gerrit.ovirt.org/14392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib240214df319a0122ebcac82bf2b96d608997432 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
