Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Support column resizing for all tables ......................................................................
Patch Set 3: Verified Rebased, included Daniel's suggestion from patch set 2, here's a list of changes since last time: * EntityModelCellTable: added Javadoc to methods which shadow original signature semantics (replacing 'footerString' with 'width' argument of same type), so that callers are aware of this * EntityModelCellTable: 'addColumn(Column,String,String)' now uses addColumnAndSetWidth() which does the same thing in one line of code * ElementIdCellTable: setElementId() now also updates existing columns * ColumnResizeCellTable: new method 'addColumn(Column,SafeHtml) --> for consistency with method below * ColumnResizeCellTable: new method 'addColumn(Column,SafeHtml,String) --> as suggested by Daniel Regarding element IDs for table cells, I think we should revisit current strategy in future - instead of setting ID on cell content, we should set ID directly on TD/TH element, preferably in a generic (cell-agnostic) way. -- To view, visit http://gerrit.ovirt.org/14341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic69b597d7c5f2330cef5a93bc8812494af731734 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
