Allon Mureinik has posted comments on this change.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
Patch Set 1:
Looks great to me, but I won't give +2 on a frontend patch.
@Daniel - feel free to
Allon Mureinik has posted comments on this change.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
Patch Set 1: Looks good to me, but someone else must approve
Looks great to me, but I won't give
Lior Vernia has posted comments on this change.
Change subject: webadmin: Rewrote Setup Networks operation logic
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/13775
To unsubscribe, visit http://gerrit.ovirt
Lior Vernia has posted comments on this change.
Change subject: webadmin: Rewrote Setup Networks operation logic
..
Patch Set 6: (1 inline comment)
File
frontend/webadmin/mo
Sahina Bose has posted comments on this change.
Change subject: engine: Refactoring GlusterManager
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/13944
To unsubscribe, visit http://gerrit.ovirt.org/settings
Lior Vernia has posted comments on this change.
Change subject: webadmin: Rewrote Setup Networks operation logic
..
Patch Set 6: (1 inline comment)
File
frontend/webadmin/mo
Sahina Bose has posted comments on this change.
Change subject: engine: VDS command - gluster hooks list
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/13831
To unsubscribe, visit http://gerrit.ovirt.org/set
Lior Vernia has posted comments on this change.
Change subject: webadmin: Rewrote Setup Networks operation logic
..
Patch Set 6: (8 inline comments)
File
frontend/webadmin/m
Sahina Bose has posted comments on this change.
Change subject: engine: adding vds_gluster table and dao operations
..
Patch Set 3: (2 inline comments)
File backend/manager/d
Sahina Bose has posted comments on this change.
Change subject: engine: VDS command to get gluster host UUID
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13941
To uns
Mike Kolesnik has posted comments on this change.
Change subject: engine: remve command serialVersionUid fields
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
You have a typo in the comment
Daniel Erez has posted comments on this change.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Daniel Erez has posted comments on this change.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Daniel Erez has posted comments on this change.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Mike Kolesnik has posted comments on this change.
Change subject: engine: TimeoutBase does not have to be serialized
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1394
Vered Volansky has posted comments on this change.
Change subject: core: Upgrade DC should not log failure on update process.
..
Patch Set 1: (1 inline comment)
File
backend
Sahina Bose has posted comments on this change.
Change subject: engine: VDS command - gluster hooks list
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/13831
To unsubscribe, visit http://gerrit.ovirt.org/set
Sahina Bose has posted comments on this change.
Change subject: engine: Refactoring GlusterManager
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/13944
To unsubscribe, visit http://gerrit.ovirt.org/settings
Doron Fediuck has posted comments on this change.
Change subject: core: NPE in add quota via rest
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14028
To unsubscribe, v
Doron Fediuck has posted comments on this change.
Change subject: restapi: disabling POST & DELETE implementations for quota
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: split service to allow code reuse
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14154
To unsubscribe, visit http:/
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: move generated code out of main
source
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14153
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: rename service directory to services
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14152
To unsubscribe, visit htt
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: move service out of fedora into own
directory
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14151
To unsubscribe,
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: split service to allow code reuse
..
packaging: engine-service: split service to allow code reuse
this will allow to reuse effort to i
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: move generated code out of main
source
..
packaging: engine-service: move generated code out of main source
this ease maintenance, as
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: move service out of fedora into own
directory
..
packaging: engine-service: move service out of fedora into own directory
service is
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: rename service directory to services
..
packaging: engine-service: rename service directory to services
we are about to have more than
Gilad Chaplik has posted comments on this change.
Change subject: engine: watchdog - frontend
..
Patch Set 5:
Other watchdog features that you can add:
must (IMHO):
* Adding watchdog data in vm general subtab
* Enabling watchdo
Gilad Chaplik has posted comments on this change.
Change subject: engine: watchdog - DB and logic changes
..
Patch Set 5: (20 inline comments)
great patch !
minor comments
F
Gilad Chaplik has posted comments on this change.
Change subject: engine: watchdog - frontend
..
Patch Set 5: (7 inline comments)
nice patch, some comments
File
frontend/we
Alexander Wels has uploaded a new change for review.
Change subject: webadmin: generic no items to display message
..
webadmin: generic no items to display message
- Changed the no XX to display message to a generic
no items to
Laszlo Hornyak has abandoned this change.
Change subject: engine: watchdog - logic changes [wip]
..
Patch Set 4: Abandoned
aquashed to prev patch
--
To view, visit http://gerrit.ovirt.org/13058
To unsubscribe, visit http://ger
Gilad Chaplik has posted comments on this change.
Change subject: core,webadmin: Show Pools tab based on tree
..
Patch Set 4:
A nice follow-up patch is adding pools (with icon - good luck with that :) ) to
the tree
--
To view
Gilad Chaplik has posted comments on this change.
Change subject: engine: filtering search based on Application Mode
..
Patch Set 4: (3 inline comments)
File
backend/manager
Tal Nisan has posted comments on this change.
Change subject: core: Upgrade DC should not log failure on update process.
..
Patch Set 1: (1 inline comment)
File
backend/mana
Alexander Wels has uploaded a new change for review.
Change subject: core: disable unit test that fails as root
..
core: disable unit test that fails as root
- Disabled a unit test that fails when run as root
as root is always a
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Added generic DB validations before the upgrade
..
Patch Set 11: (4 inline comments)
File backend/
Alexander Wels has posted comments on this change.
Change subject: userportal: prestarted VMs not updated
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14148
To unsubs
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Propagate error message when quering for LDAP
users/groups
..
Patch Set 2: (1 inline comment)
File
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/881/
Build Number: 881
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal: prestarted VMs not updated
..
userportal: prestarted VMs not updated
Have a pool with prestarted VMs. Take a VM from it in user portal.
The result
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Upgrade DC should not log failure on update process.
..
core: Upgrade DC should not log failure on update process.
When VDSM fails to run the verb upgradeS
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Rewrote Setup Networks operation logic
..
Patch Set 6: (9 inline comments)
Nice!
File
frontend/we
Alon Bar-Lev has posted comments on this change.
Change subject: Renamed engine-iso-uploader in ovirt-iso-uploader
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14133
Sandro Bonazzola has posted comments on this change.
Change subject: Renamed engine-iso-uploader in ovirt-iso-uploader
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/14133
To unsubscribe, visit http://gerrit
Sandro Bonazzola has posted comments on this change.
Change subject: Renamed engine-iso-uploader in ovirt-iso-uploader
..
Patch Set 3: (1 inline comment)
File src/Makefile.am
Allon Mureinik has posted comments on this change.
Change subject: findbugs: Method invokes inefficient Number constructor
..
Patch Set 1: I would prefer that you didn't submit this
(11 inline comments)
...
Alon Bar-Lev has posted comments on this change.
Change subject: Renamed engine-iso-uploader in ovirt-iso-uploader
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Allon Mureinik has submitted this change and it was merged.
Change subject: core: add repo_file_id to repo_file_meta_data
..
core: add repo_file_id to repo_file_meta_data
In order to support image repositories that define an id
Allon Mureinik has posted comments on this change.
Change subject: core: add repo_file_id to repo_file_meta_data
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13958
To unsubscrib
Ravi Nori has posted comments on this change.
Change subject: cli: Error in "update network --cluster-identifier
--usages-usage"
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/14060
To unsubscribe, visit ht
Allon Mureinik has posted comments on this change.
Change subject: core: move findActiveISODomain to IsoDomainListSyncronizer (2)
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Omer Frenkel has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (3)
..
Patch Set 9: (1 inline comment)
File
backend/manager/modules/b
Laszlo Hornyak has submitted this change and it was merged.
Change subject: engine: unit test for isCpuPinningValid
..
engine: unit test for isCpuPinningValid
Adds a negative test for the case when there is pinning but no pinne
Laszlo Hornyak has posted comments on this change.
Change subject: engine: unit test for isCpuPinningValid
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13991
To unsubscribe, vis
Sandro Bonazzola has posted comments on this change.
Change subject: Renamed engine-iso-uploader in ovirt-iso-uploader
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14133
To unsubscribe, visit http://gerrit
Omer Frenkel has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (3)
..
Patch Set 9: (1 inline comment)
File
backend/manager/modules/b
Laszlo Hornyak has posted comments on this change.
Change subject: engine: watchdog - DB changes [wip]
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/dal/sr
Martin Sivák has uploaded a new change for review.
Change subject: [WIP] engine: Save VDSM information about HAB devices
..
[WIP] engine: Save VDSM information about HAB devices
This patch adds the necessary infrastructure for
g
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: List/Show suggests parent+child as single param #950398
..
cli: List/Show suggests parent+child as single param #950398
Change-Id: Ice679b53fdb
Michael Pasternak has posted comments on this change.
Change subject: cli: List/Show suggests parent+child as single param #950398
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1
Michael Pasternak has posted comments on this change.
Change subject: cli: List/Show suggests parent+child as single param #950398
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: List/Show suggests parent+child as single param #950398
..
cli: List/Show suggests parent+child as single param #950398
Change-Id: Ice679b53fdb
Ravi Nori has posted comments on this change.
Change subject: cli: List/Show suggests parent+child as single param #950398
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Martin Beták has posted comments on this change.
Change subject: restapi: Added VmPool.max_assigned_vms_per_user
..
Patch Set 3: (1 inline comment)
File
backend/manager/modu
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/879/
Build Number: 879
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Michael Pasternak has uploaded a new change for review.
Change subject: cli: List/Show suggests parent+child as single param #950398
..
cli: List/Show suggests parent+child as single param #950398
Change-Id: Ice679b53fdbb2495721
Gilad Chaplik has posted comments on this change.
Change subject: engine: Propagate error message when quering for LDAP
users/groups
..
Patch Set 2: (6 inline comments)
File
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Introduction of command entity dao
..
Patch Set 4:
Rebase against -
95d2c0ee5485ecaff41464b6c4422d45cca4d370
--
To view, visit http://gerrit.ovirt.or
Allon Mureinik has submitted this change and it was merged.
Change subject: core: PerformImagesChecks no check for no disks
..
core: PerformImagesChecks no check for no disks
Removed the check for no image disks from PerfomImag
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove ImagesHandler.PerformImagesChecks
..
core: Remove ImagesHandler.PerformImagesChecks
After the recent changes, PerformImagesChecks had the
Allon Mureinik has posted comments on this change.
Change subject: core: PerformImagesChecks no check for no disks
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no code changes.
Addresses issues in the commit me
Allon Mureinik has posted comments on this change.
Change subject: core: Remove ImagesHandler.PerformImagesChecks
..
Patch Set 4: Verified; Looks good to me, approved
Rebased, no code changes.
Addresses issues in the commit mes
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Block external network for legacy network commands
..
engine: Block external network for legacy network commands
Since external networks are provisioned
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Block hot updating external networks
..
engine: Block hot updating external networks
Hot update of external network on a vNIC is not supported, so block
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Block external networks in Setup Networks
..
engine: Block external networks in Setup Networks
Since external networks are provisioned by the provider,
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Add Quantum dependency
..
engine: Add Quantum dependency
Added dependency on Quantum Java SDK for communicating with Quantum
servers.
Change-Id: I5ad2c
Noam Slomianko has uploaded a new change for review.
Change subject: engine: engine: add comment field to cluster
..
engine: engine: add comment field to cluster
Part of the adding a comment field to many parts of the system
-
Alon Bar-Lev has posted comments on this change.
Change subject: Renamed engine-iso-uploader in ovirt-iso-uploader
..
Patch Set 2: (1 inline comment)
I think that man page link should be provided...
...
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Propagate error message when quering for LDAP
users/groups
..
Patch Set 2: (2 inline comments)
Fil
Eli Mesika has submitted this change and it was merged.
Change subject: core: we are fencing a host when putting it in...
..
core: we are fencing a host when putting it in...
core: we are fencing a host when putting it in maint
Eli Mesika has posted comments on this change.
Change subject: core: we are fencing a host when putting it in...
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14127
To unsubscrib
Michael Pasternak has uploaded a new change for review.
Change subject: cli: List/Show suggests parent+child as single param #950398
..
cli: List/Show suggests parent+child as single param #950398
Change-Id: Ice679b53fdbb2495721
Libor Spevak has posted comments on this change.
Change subject: core: Update VM status if host is not available
..
Patch Set 2: (1 inline comment)
File
backend/manager/modu
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Propagate error message when quering for LDAP
users/groups
..
Patch Set 2: (3 inline comments)
Fil
Alon Bar-Lev has posted comments on this change.
Change subject: Renamed engine-iso-uploader in ovirt-iso-uploader
..
Patch Set 1:
I think you should keep same binary name for backward compatibility, symlink is
good.
Or... yo
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: New Network dialog checks system tree DC
..
webadmin: New Network dialog checks system tree DC
The dialog now looks at the selected item in the
Alona Kaplan has posted comments on this change.
Change subject: webadmin: New Network dialog checks system tree DC
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14085
To unsubsc
Sandro Bonazzola has posted comments on this change.
Change subject: Renamed engine-iso-uploader in ovirt-iso-uploader
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14133
To unsubscribe, visit http://gerrit
Sandro Bonazzola has uploaded a new change for review.
Change subject: Renamed engine-iso-uploader in ovirt-iso-uploader
..
Renamed engine-iso-uploader in ovirt-iso-uploader
The package should have the same name of the applicati
Yair Zaslavsky has posted comments on this change.
Change subject: core: we are fencing a host when putting it in...
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14127
To unsubscribe, vis
Omer Frenkel has posted comments on this change.
Change subject: core: Update VM status if host is not available
..
Patch Set 2: (1 inline comment)
File
backend/manager/modu
Libor Spevak has posted comments on this change.
Change subject: core: Update VM status if host is not available
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13706
To unsubscribe, visit http://gerrit.ovirt
Alona Kaplan has submitted this change and it was merged.
Change subject: userportal: Fix tooltip localization
..
userportal: Fix tooltip localization
Tooltip of quota status bar included unlocalized text.
Change-Id: I6398f3c6
Alona Kaplan has posted comments on this change.
Change subject: userportal: Fix tooltip localization
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14115
To unsubscribe, visit ht
Alona Kaplan has posted comments on this change.
Change subject: userportal: Fix tooltip localization
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14115
To unsubscribe, visit http://gerri
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Color Setup Networks label when operation invalid
..
webadmin: Color Setup Networks label when operation invalid
To make the status label more
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Color Setup Networks label when operation invalid
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14038
T
1 - 100 of 218 matches
Mail list logo
