Yair Zaslavsky has posted comments on this change.
Change subject: engine: Propagate error message when quering for LDAP
users/groups
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java
Line 67: LdapCredentials ldapCredentials = new
LdapCredentials(loginNameForKerberos, getPassword());
Line 68: DirectorySearcher directorySearcher = new
DirectorySearcher(ldapCredentials);
Line 69: executeQuery(directorySearcher);
Line 70: } catch (RuntimeException e) {
Line 71: String msg = String.format("Failed to run command %s.
Domain is %s. User is %s.",
Asaf - I would suggest in that case to add a TODO comment + of course the
localization fix should be done in this patchset (in a future patch)
Line 72: getClass().getSimpleName(), getDomain(),
getLoginName());
Line 73: log.errorFormat(msg);
Line 74: _ldapReturnValue.setExceptionString(msg);
Line 75: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
Line 200: LdapReturnValueBase returnValue =
Line 201:
getLdapFactory(data.getDomain()).RunAdAction(adActionType,
Line 202: new
LdapSearchByQueryParameters(data.getDomain(), ldapQueryData));
Line 203:
getQueryReturnValue().setSucceeded(returnValue.getSucceeded());
Line 204:
getQueryReturnValue().setExceptionString(returnValue.getExceptionString());
+1 on Asaf's - canDoAction messages are on Commands, not Queries, Sorry for
missing that.
Line 205: @SuppressWarnings("unchecked")
Line 206: List<T> result = (List<T>) returnValue.getReturnValue();
Line 207:
Line 208: return (result != null) ? result : new ArrayList<T>();
--
To view, visit http://gerrit.ovirt.org/11893
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50da72d12c6d60642ad5e65b9376efc49e4ef699
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
