Allon Mureinik has posted comments on this change.
Change subject: findbugs: Method invokes inefficient Number constructor
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(11 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java
Line 43: info.append(sep);
Line 44: info.append(o);
Line 45: info.append(EQUAL);
Line 46: info.append(createInfo.get(o));
Line 47: sep = (Character.valueOf(SEP)).toString();
Just define SEP as final string "," instead of a character...
Line 48: }
Line 49: log.infoFormat("{0} {1}", getClass().getName(),
info.toString());
Line 50: }
Line 51:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DestroyVDSCommand.java
Line 12: @Override
Line 13: protected void ExecuteVdsBrokerCommand() {
Line 14: if (getParameters().getGracefully()) {
Line 15: status =
getBroker().shutdown(getParameters().getVmId().toString(),
Line 16:
(Integer.valueOf(getParameters().getSecondsToWait())).toString(),
Instead of Integer.valueOf(int).toString(), just use String.valueOf(int)
Line 17: Config.<String>
GetValue(ConfigValues.VmGracefulShutdownMessage));
Line 18: } else {
Line 19: status =
getBroker().destroy(getParameters().getVmId().toString());
Line 20: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/EditNetworkVDSCommand.java
Line 56: // options[VdsProperties.force] = "true";
Line 57: if (getParameters().getCheckConnectivity()) {
Line 58: options.put(VdsProperties.CONNECTIVITY_CHECK, "true");
Line 59: options.put(VdsProperties.CONNECTIVITY_TIMEOUT,
Line 60:
(Integer.valueOf(getParameters().getConnectionTimeout())).toString());
Instead of Integer.valueOf(int).toString(), just use String.valueOf(int)
Line 61: }
Line 62:
Line 63: status = getBroker().editNetwork(oldNetwork, networkName,
vlanId, bond, nics, options);
Line 64: ProceedProxyReturnValue();
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java
Line 27:
getVds().getVdsGroupCompatibilityVersion().toString())) {
Line 28: Map<String, String> params = new HashMap<String, String>();
Line 29: params.put("userName", getParameters().getUserName());
Line 30: params.put("userId",
getParameters().getUserId().toString());
Line 31: status = getBroker().setVmTicket(mVmId.toString(),
mTicket, (Integer.valueOf(mValidTime)).toString(),
Instead of Integer.valueOf(int).toString(), just use String.valueOf(int)
Line 32: connectionAction, params);
Line 33: }
Line 34: else {
Line 35: status = getBroker().setVmTicket(mVmId.toString(),
mTicket, (Integer.valueOf(mValidTime)).toString());
Line 31: status = getBroker().setVmTicket(mVmId.toString(),
mTicket, (Integer.valueOf(mValidTime)).toString(),
Line 32: connectionAction, params);
Line 33: }
Line 34: else {
Line 35: status = getBroker().setVmTicket(mVmId.toString(),
mTicket, (Integer.valueOf(mValidTime)).toString());
Instead of Integer.valueOf(int).toString(), just use String.valueOf(int)
Line 36: }
Line 37:
Line 38: ProceedProxyReturnValue();
Line 39: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
Line 44: createInfo.put(VdsProperties.vm_name, vm.getName());
Line 45: createInfo.put(VdsProperties.mem_size_mb, vm.getVmMemSizeMb());
Line 46: createInfo.put(VdsProperties.smartcardEnabled,
Boolean.toString(vm.isSmartcardEnabled()));
Line 47: createInfo.put(VdsProperties.num_of_cpus,
Line 48: (Integer.valueOf(vm.getNumOfCpus())).toString());
Instead of Integer.valueOf(int).toString(), just use String.valueOf(int)
Line 49: if (Config.<Boolean> GetValue(ConfigValues.SendSMPOnRunVm)) {
Line 50: createInfo.put(VdsProperties.cores_per_socket,
Line 51: (Integer.toString(vm.getCpuPerSocket())));
Line 52: }
Line 81: createInfo.put(VdsProperties.cpuType,
Line 82: vm.getVdsGroupCpuFlagsData());
Line 83: }
Line 84: createInfo.put(VdsProperties.niceLevel,
Line 85: (Integer.valueOf(vm.getNiceLevel())).toString());
Instead of Integer.valueOf(int).toString(), just use String.valueOf(int)
Line 86: if (vm.getStatus() == VMStatus.Suspended
Line 87: && !StringUtils.isEmpty(vm.getHibernationVolHandle()))
{
Line 88: createInfo.put(VdsProperties.hiberVolHandle,
Line 89: vm.getHibernationVolHandle());
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 439: addDevice(struct, vmDevice, vm.getFloppyPath());
Line 440: }
Line 441:
Line 442: private static void addBootOrder(VmDevice vmDevice, Map<String,
Object> struct) {
Line 443: String s =
Integer.valueOf(vmDevice.getBootOrder()).toString();
Instead of Integer.valueOf(int).toString(), just use String.valueOf(int)
Line 444: if (!org.apache.commons.lang.StringUtils.isEmpty(s) &&
!s.equals("0")) {
Line 445: struct.put(VdsProperties.BootOrder, s);
Line 446: }
Line 447: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java
Line 789: break;
Line 790: }
Line 791:
Line 792: if (i > 0) {
Line 793: commonName = getCommonName() +
(Integer.valueOf(i)).toString();
Instead of Integer.valueOf(int).toString(), just use String.valueOf(int)
Line 794: }
Line 795:
Line 796: return commonName;
Line 797: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
Line 1751: ArrayList<BootSequence> items = new
ArrayList<BootSequence>();
Line 1752: for (char a : value.toString().toCharArray())
Line 1753: {
Line 1754:
items.add(BootSequence.valueOf((Character.valueOf(a)).toString()));
Line 1755: }
Instead of Character.valueOf(char).toString(), just use String.valueOf(char)
Line 1756:
Line 1757: Object firstBootDevice = null;
Line 1758: for (Object item : getFirstBootDevice().getItems())
Line 1759: {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
Line 358: for (EntityModel item : items)
Line 359: {
Line 360: int val1 = (Integer) item.getEntity();
Line 361: int val2 = (Integer) oldPriority.getEntity();
Line 362: if ((Integer.valueOf(val1)).equals(val2))
Just define val1 and val2 as integers instead of ints.
This with also solve the possible NPE if item or oldPriority ever become nulls.
Line 363: {
Line 364: getModel().getPriority().setSelectedItem(item);
Line 365: break;
Line 366: }
--
To view, visit http://gerrit.ovirt.org/14128
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id868d7fe02fde3af616cef32328a3a893582f4e9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
