Allon Mureinik has posted comments on this change.
Change subject: core: Remove checkIsValid from PerformImagesChecks
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Tal.
--
To view, visit
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove ImagesHandler.PerformImagesChecks
..
core: Remove ImagesHandler.PerformImagesChecks
After the recent changes, PerformImagesChecks had the followin
Allon Mureinik has uploaded a new change for review.
Change subject: core: PerformImagesChecks no check for no disks
..
core: PerformImagesChecks no check for no disks
Removed the check for no image disks from PerfomImagesChecks
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] core: Introducing findbugs filter to bll module
..
Patch Set 3:
Correction -
We should run with mvn findbugs:findbugs
--
To view, visit http://gerrit.ovi
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: Disable Gluster hooks
..
webadmin: Disable Gluster hooks
Disable action added for Gluster Hooks sub tab in cluster.
Change-Id: I18d86bf20931482
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Disable Gluster hooks
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13574
To unsubscribe, visit http://g
Yair Zaslavsky has posted comments on this change.
Change subject: core: avoid logging in ERROR on cancelled event.
..
Patch Set 3: (1 inline comment)
File
backend/manager/m
Michael Kublin has posted comments on this change.
Change subject: core: avoid logging in ERROR on cancelled event.
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Fix quota not counted when run VM from pool
..
core: Fix quota not counted when run VM from pool
When running VM from a VM-pool the quota (CPU, Me
Gilad Chaplik has posted comments on this change.
Change subject: core: Fix quota not counted when run VM from pool
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14098
To unsubscribe, visi
ofri masad has posted comments on this change.
Change subject: core: Fix quota not counted when run VM from pool
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/14098
To unsubscribe, visit http://gerrit.ovirt
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] core: Introducing findbugs filter to bll module
..
Patch Set 3:
Oved,
I am running mvn site from root pom now -
It does pass the execution to the sub modu
ofri masad has posted comments on this change.
Change subject: webadmin: Auto update quota by template
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14112
To unsubscribe, visit http://gerrit.ovirt.org/setti
ofri masad has uploaded a new change for review.
Change subject: webadmin: Auto update quota by template
..
webadmin: Auto update quota by template
In the VM popup - when a template is selected, update the quota to the
quota of
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] core: Introducing findbugs filter to bll module
..
Patch Set 3:
Oved- meaning?
Why introduce all filters , unrelated to bll on root pom?
--
To view, vis
Oved Ourfali has posted comments on this change.
Change subject: [WIP] core: Introducing findbugs filter to bll module
..
Patch Set 3:
what happens if you do that on the root pom.xml?
--
To view, visit http://gerrit.ovirt.org/
Sahina Bose has posted comments on this change.
Change subject: engine: VDS command - gluster hooks list
..
Patch Set 5:
@Shireesh - The entries are present in
org/ovirt/engine/ui/frontend/VdsmErrors.java. The VdsmErrors.prope
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Introducing findbugs filter to bll module
..
core: Introducing findbugs filter to bll module
Introducing findbugs to bll module.
In order to generate fin
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing wrong instanceof usage at SrvRecord
..
Patch Set 1: Verified
Ran manually findbugs on utils jar
--
To view, visit http://gerrit.ovirt.org/14108
To
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Fixing wrong instanceof usage at SrvRecord
..
core: Fixing wrong instanceof usage at SrvRecord
The following fix fixes wrong usage of instanceof
Change-
Yair Zaslavsky has abandoned this change.
Change subject: Revert "findbugs: When implementing compareTo implement
Object.equals as well"
..
Patch Set 1: Abandoned
dont need this
--
To view, visit http://gerrit.ovirt.org/14107
Yair Zaslavsky has reverted this change.
Change subject: Revert "findbugs: When implementing compareTo implement
Object.equals as well"
..
Patch Set 6: Reverted
This patchset was reverted in change: I40f7a786934080f7df57e0007d
Tal Nisan has posted comments on this change.
Change subject: core: Remove checkIsValid from PerformImagesChecks
..
Patch Set 1: Looks good to me, approved
Joyfull.
--
To view, visit http://gerrit.ovirt.org/14106
To unsubscrib
Allon Mureinik has posted comments on this change.
Change subject: core: move findActiveISODomain to IsoDomainListSyncronizer (2)
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: Remove checkIsValid from PerformImagesChecks
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14106
To unsubscribe, visit http://gerrit.
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused ImagesHandlerActionParameters
..
core: Remove unused ImagesHandlerActionParameters
Change-Id: I15e2ed654331b812a41c6bd68d4a42d4f307
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove image status check from ImagesHandler
..
core: Remove image status check from ImagesHandler
Extracted all image status checks from ImagesH
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove checkImagesLocked(vmId, messages)
..
core: Remove checkImagesLocked(vmId, messages)
Removed ImagesHandler.checkImagesLocked(Guid vmId, Lis
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused ImagesHandlerActionParameters
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Daniel.
--
To view, visi
Allon Mureinik has posted comments on this change.
Change subject: core: Remove checkImagesLocked(vmId, messages)
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Tal, +1 by Daniel.
--
To vi
Allon Mureinik has posted comments on this change.
Change subject: core: Remove image status check from ImagesHandler
..
Patch Set 4: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Tal.
--
To view, visit
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove checkIsValid from PerformImagesChecks
..
core: Remove checkIsValid from PerformImagesChecks
The recent changes to ImagesHandler.PerformImagesCheck
Allon Mureinik has submitted this change and it was merged.
Change subject: spelling: s/clsuter/cluster
..
spelling: s/clsuter/cluster
Change-Id: Icc54bd40f76037c3c58dca8da35d14a69f89283f
Signed-off-by: Itamar Heim
---
M
back
Allon Mureinik has posted comments on this change.
Change subject: spelling: s/clsuter/cluster
..
Patch Set 3: Verified; Looks good to me, approved
Well, it's so easy to make me happy :-)
--
To view, visit http://gerrit.ovirt.
Laszlo Hornyak has posted comments on this change.
Change subject: restapi: make cpu-mode enumerable values lower-case #915042
..
Patch Set 3: Looks good to me, approved
perfectly fine for me
--
To view, visit http://gerrit.ov
Itamar Heim has posted comments on this change.
Change subject: spelling: s/clsuter/cluster
..
Patch Set 2: Verified
just to make you happy...
verified by compilation again
--
To view, visit http://gerrit.ovirt.org/14080
To un
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: DataCenters - sub-tabs resizable columns (WIP)
..
webadmin: DataCenters - sub-tabs resizable columns (WIP)
Sub-tabs under DataCenters main-tab now suppo
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Introduction of Poller, CommandEntity and Ehcache
..
Patch Set 12:
Changes at CommandEntity:
1. Moved to common
2. Introduced hashCode and equals
3. Ch
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Introduction of command entity dao
..
Patch Set 3:
DAO tests are passing.
--
To view, visit http://gerrit.ovirt.org/14104
To unsubscribe, visit http://
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Introduction of command entity dao
..
Patch Set 3:
Rebased the entire patchset against commit hash -
9b5b13a5a84fa000572ab1605e9389bcca9d069d
--
To vi
Yair Zaslavsky has abandoned this change.
Change subject: engine : Introduction of Poller, CommandEntity and Ehcache
..
Patch Set 1: Abandoned
not needed
--
To view, visit http://gerrit.ovirt.org/14103
To unsubscribe, visit ht
Hello Ravi Nori,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/14103
to review the following change.
Change subject: engine : Introduction of Poller, CommandEntity and Ehcache
..
engine : Introduc
Yair Zaslavsky has uploaded a new change for review.
Change subject: engine: Introduction of command entity dao
..
engine: Introduction of command entity dao
Introduction of command entity database support
(upgrade script, store
Tal Nisan has posted comments on this change.
Change subject: core: Remove image status check from ImagesHandler
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14101
To unsubscribe, visit h
Allon Mureinik has posted comments on this change.
Change subject: spelling: s/clsuter/cluster
..
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments)
...
Daniel Erez has submitted this change and it was merged.
Change subject: core: use DiskImage.copyOf in getAllDisks query
..
core: use DiskImage.copyOf in getAllDisks query
GetAllDisksByStorageDomainIdQuery:
add a copy of the ac
Daniel Erez has posted comments on this change.
Change subject: core: use DiskImage.copyOf in getAllDisks query
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14102
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: use DiskImage.copyOf in getAllDisks query
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14102
To unsubscribe, visit
Liron Ar has posted comments on this change.
Change subject: core: avoid logging in ERROR on cancelled event.
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/13311
To unsubscribe, visit http://gerrit.ovirt.or
Michael Pasternak has posted comments on this change.
Change subject: restapi: Throw exception if setting lower VM pool size
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
...
Michael Pasternak has posted comments on this change.
Change subject: restapi: Apply template on VmPool creation using REST API
..
Patch Set 1:
Thanks Martin,
Could you please add a test verifying this flow?!
--
To view, visi
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/869/
Build Number: 869
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Daniel Erez has uploaded a new change for review.
Change subject: core: use DiskImage.copyOf in getAllDisks query
..
core: use DiskImage.copyOf in getAllDisks query
GetAllDisksByStorageDomainIdQuery:
add a copy of the active Dis
Gilad Chaplik has posted comments on this change.
Change subject: core: runVmCommand.canDoAction clean up (13)
..
Patch Set 5: (1 inline comment)
File
backend/manager/module
Gilad Chaplik has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (1)
..
Patch Set 4: (2 inline comments)
File
backend/manager/modules
Allon Mureinik has posted comments on this change.
Change subject: core: Remove image status check from ImagesHandler
..
Patch Set 3: Verified
Removed comment left in the code by mistake
--
To view, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: Remove image status check from ImagesHandler
..
Patch Set 2: (1 inline comment)
File
backend/manager
Tal Nisan has posted comments on this change.
Change subject: core: Remove image status check from ImagesHandler
..
Patch Set 2: (1 inline comment)
File
backend/manager/modu
Michael Pasternak has posted comments on this change.
Change subject: restapi: make cpu-mode enumerable values lower-case #915042
..
Patch Set 2: (1 inline comment)
File
bac
Tal Nisan has posted comments on this change.
Change subject: core: Remove checkImagesLocked(vmId, messages)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14100
To unsubscribe, visit http:
Allon Mureinik has posted comments on this change.
Change subject: core: Remove image status check from ImagesHandler
..
Patch Set 2: Verified
Fixed commit message of previous patch, no changes to this one.
--
To view, visit h
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: wrong quota(s) in dc-quota subtab
..
webadmin: wrong quota(s) in dc-quota subtab
Caused by a call to super.syncSearch(), which created a
wrong
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: wrong quota(s) in dc-quota subtab
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/14050
To unsu
Allon Mureinik has posted comments on this change.
Change subject: core: Remove checkImagesLocked(vmId, messages)
..
Patch Set 2: Verified
Fixed typo in commit message as per Daniel's review.
--
To view, visit http://gerrit.ov
Arik Hadas has posted comments on this change.
Change subject: frontend: reduce duplicate code related to run-once capability
- cont
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13904
To unsubscribe, visi
Arik Hadas has posted comments on this change.
Change subject: frontend: fluent API instead of temporary fields
..
Patch Set 10: Verified
--
To view, visit http://gerrit.ovirt.org/13246
To unsubscribe, visit http://gerrit.ovirt
Arik Hadas has posted comments on this change.
Change subject: frontend: reduce duplicate code related to run-once capability
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/13207
To unsubscribe, visit http:
Daniel Erez has posted comments on this change.
Change subject: webadmin: wrong quota(s) in dc-quota subtab
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14050
To unsubscribe, visit http:/
Daniel Erez has posted comments on this change.
Change subject: core: Remove checkImagesLocked(vmId, messages)
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Gilad Chaplik has posted comments on this change.
Change subject: restapi: disabling POST & DELETE implementations for quota
..
Patch Set 2:
there weren't any messages :-) I was a bit surprised (probably a gerrit bug)
--
To vi
Daniel Erez has posted comments on this change.
Change subject: core: Remove unused ImagesHandlerActionParameters
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14099
To unsubscribe, visit
Shahar Havivi has submitted this change and it was merged.
Change subject: findbugs: When implementing compareTo implement Object.equals
as well
..
findbugs: When implementing compareTo implement Object.equals as well
Change-I
Shahar Havivi has posted comments on this change.
Change subject: findbugs: When implementing compareTo implement Object.equals
as well
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt
Laszlo Hornyak has posted comments on this change.
Change subject: restapi: make cpu-mode enumerable values lower-case #915042
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
one minor commen
Mike Kolesnik has submitted this change and it was merged.
Change subject: restapi: Don't mandate a network when adding a template NIC
..
restapi: Don't mandate a network when adding a template NIC
In template context, it shoul
Mike Kolesnik has posted comments on this change.
Change subject: restapi: Don't mandate a network when adding a template NIC
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, only commit message was fixed after mpa
Mike Kolesnik has posted comments on this change.
Change subject: restapi: Don't mandate a network when adding a template NIC
..
Patch Set 1: (1 inline comment)
Commit Messag
Michael Pasternak has posted comments on this change.
Change subject: restapi: disabling POST & DELETE implementations for quota
..
Patch Set 2:
Gilad,
-1 was not because of commit message ..., please review
my comments on pat
Arik Hadas has posted comments on this change.
Change subject: core: Fix quota not counted when run VM from pool
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14098
To
Michael Pasternak has posted comments on this change.
Change subject: restapi: Fix NICs in template context
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
+2 (tiny comment inline)
..
Mike Kolesnik has posted comments on this change.
Change subject: findbugs: When implementing compareTo implement Object.equals
as well
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14039
Allon Mureinik has posted comments on this change.
Change subject: findbugs: When implementing compareTo implement Object.equals
as well
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://
Allon Mureinik has posted comments on this change.
Change subject: core: Remove image status check from ImagesHandler
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14101
To unsubscribe, visit http://gerrit.
Allon Mureinik has posted comments on this change.
Change subject: core: Remove checkImagesLocked(vmId, messages)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14100
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused ImagesHandlerActionParameters
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14099
To unsubscribe, visit http://gerrit.o
Daniel Erez has submitted this change and it was merged.
Change subject: userportal: resources->quota updating
..
userportal: resources->quota updating
- Fixed resources quota class cast exception causing
quota not to update.
Daniel Erez has posted comments on this change.
Change subject: userportal: resources->quota updating
..
Patch Set 4: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/14062
To unsubscribe,
Daniel Erez has posted comments on this change.
Change subject: userportal: resources->quota updating
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14062
To unsubscribe, visit http://gerri
Omer Frenkel has posted comments on this change.
Change subject: core: Fix quota not counted when run VM from pool
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14098
ofri masad has posted comments on this change.
Change subject: userportal: resources->quota updating
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14062
To unsubscribe, visit http://gerrit.ovirt.org/setting
Gilad Chaplik has posted comments on this change.
Change subject: core: Fix quota not counted when run VM from pool
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14098
Lior Vernia has posted comments on this change.
Change subject: webadmin: New Network dialog checks system tree DC
..
Patch Set 1: (1 inline comment)
Commit Message
Line 11:
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated running taskcleaner utility
..
Patch Set 1: (1 inline comment)
Commit Message
Line 6:
Lin
ofri masad has posted comments on this change.
Change subject: core: Fix quota not counted when run VM from pool
..
Patch Set 1: (3 inline comments)
File
backend/manager/mod
Lior Vernia has posted comments on this change.
Change subject: webadmin: New Network dialog checks system tree DC
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/
ofri masad has posted comments on this change.
Change subject: core: Fix quota not counted when run VM from pool
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14098
To unsubscribe, visit http://gerrit.ovirt
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove checkImagesLocked(vmId, messages)
..
core: Remove checkImagesLocked(vmId, messages)
Removed ImagesHandler.checkImagesLocked(Guid vmId, List
---
M
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove unused ImagesHandlerActionParameters
..
core: Remove unused ImagesHandlerActionParameters
Change-Id: I15e2ed654331b812a41c6bd68d4a42d4f3077961
Sig
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove image status check from ImagesHandler
..
core: Remove image status check from ImagesHandler
Extracted all image status checks from ImagesHandler a
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Disable Gluster hooks
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13574
To unsubscribe, visit http://gerrit.ov
1 - 100 of 197 matches
Mail list logo
