Daniel Erez has uploaded a new change for review.
Change subject: webadmin: DataCenters - sub-tabs resizable columns (WIP)
......................................................................
webadmin: DataCenters - sub-tabs resizable columns (WIP)
Sub-tabs under DataCenters main-tab now support
resizable columns.
* Invoked enableColumnResizing() on each sub-tab.
* Added a static width value for each column.
Change-Id: I71465d36e5c18ecb8eb6dbca436feaeea1c902a9
Signed-off-by: Daniel Erez <de...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/events/EventListModelTable.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionWithInheritedPermissionListModelTable.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterClusterView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterNetworkView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterQuotaView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterStorageView.java
7 files changed, 29 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/05/14105/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/events/EventListModelTable.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/events/EventListModelTable.java
index 4ec68bd..e1b64e9 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/events/EventListModelTable.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/events/EventListModelTable.java
@@ -30,6 +30,8 @@
@Override
public void initTable(CommonApplicationConstants constants) {
+ getTable().enableColumnResizing();
+
getTable().addColumn(new AuditLogSeverityColumn(), constants.empty(),
"20px"); //$NON-NLS-1$
TextColumnWithTooltip<AuditLog> logTimeColumn = new
FullDateTimeColumn<AuditLog>() {
@@ -46,7 +48,7 @@
return object.getmessage();
}
};
- getTable().addColumn(messageColumn, constants.messageEvent());
+ getTable().addColumn(messageColumn, constants.messageEvent(),
"600px"); //$NON-NLS-1$
TextColumnWithTooltip<AuditLog> correlationIdColumn = new
TextColumnWithTooltip<AuditLog>() {
@Override
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java
index 4ba69d4..0533752 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java
@@ -23,6 +23,8 @@
@Override
public void initTable(CommonApplicationConstants constants) {
+ getTable().enableColumnResizing();
+
getTable().addColumn(new PermissionTypeColumn(), constants.empty(),
"30px"); //$NON-NLS-1$
TextColumnWithTooltip<permissions> userColumn = new
TextColumnWithTooltip<permissions>() {
@@ -31,7 +33,7 @@
return object.getOwnerName();
}
};
- getTable().addColumn(userColumn, constants.userPermission());
+ getTable().addColumn(userColumn, constants.userPermission(), "300px");
//$NON-NLS-1$
TextColumnWithTooltip<permissions> roleColumn = new
TextColumnWithTooltip<permissions>() {
@Override
@@ -39,7 +41,7 @@
return object.getRoleName();
}
};
- getTable().addColumn(roleColumn, constants.rolePermission());
+ getTable().addColumn(roleColumn, constants.rolePermission(), "300px");
//$NON-NLS-1$
getTable().addActionButton(new
UiCommandButtonDefinition<permissions>(getEventBus(),
constants.addPermission()) {
@Override
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionWithInheritedPermissionListModelTable.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionWithInheritedPermissionListModelTable.java
index a130704..2c3354b 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionWithInheritedPermissionListModelTable.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionWithInheritedPermissionListModelTable.java
@@ -30,7 +30,7 @@
};
}
};
- getTable().addColumn(permissionColumn,
constants.inheritedPermission());
+ getTable().addColumn(permissionColumn,
constants.inheritedPermission(), "300px"); //$NON-NLS-1$
}
}
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterClusterView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterClusterView.java
index fdc817b..835296c 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterClusterView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterClusterView.java
@@ -23,13 +23,15 @@
}
void initTable(ApplicationConstants constants) {
+ getTable().enableColumnResizing();
+
TextColumnWithTooltip<VDSGroup> nameColumn = new
TextColumnWithTooltip<VDSGroup>() {
@Override
public String getValue(VDSGroup object) {
return object.getname();
}
};
- getTable().addColumn(nameColumn, constants.nameCluster());
+ getTable().addColumn(nameColumn, constants.nameCluster(), "300px");
//$NON-NLS-1$
TextColumnWithTooltip<VDSGroup> versionColumn = new
TextColumnWithTooltip<VDSGroup>() {
@Override
@@ -37,7 +39,7 @@
return object.getcompatibility_version().getValue();
}
};
- getTable().addColumn(versionColumn, constants.comptVersCluster());
+ getTable().addColumn(versionColumn, constants.comptVersCluster(),
"300px"); //$NON-NLS-1$
TextColumnWithTooltip<VDSGroup> descColumn = new
TextColumnWithTooltip<VDSGroup>() {
@Override
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterNetworkView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterNetworkView.java
index 9fcfbe4..f46ea3a 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterNetworkView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterNetworkView.java
@@ -33,13 +33,15 @@
}
void initTable(ApplicationConstants constants) {
+ getTable().enableColumnResizing();
+
TextColumnWithTooltip<Network> nameColumn = new
TextColumnWithTooltip<Network>() {
@Override
public String getValue(Network object) {
return object.getName();
}
};
- getTable().addColumn(nameColumn, constants.nameNetwork());
+ getTable().addColumn(nameColumn, constants.nameNetwork(), "400px");
//$NON-NLS-1$
TextColumnWithTooltip<Network> typeColumn = new
TextColumnWithTooltip<Network>() {
@Override
@@ -47,7 +49,7 @@
return object.getDescription();
}
};
- getTable().addColumn(typeColumn, constants.descriptionNetwork());
+ getTable().addColumn(typeColumn, constants.descriptionNetwork(),
"400px"); //$NON-NLS-1$
getTable().addActionButton(new
WebAdminButtonDefinition<Network>(constants.newNetwork()) {
@Override
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterQuotaView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterQuotaView.java
index 26803ab..e2b5870 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterQuotaView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterQuotaView.java
@@ -33,6 +33,8 @@
}
void initTable(ApplicationConstants constants) {
+ getTable().enableColumnResizing();
+
getTable().addColumn(new QuotaDcStatusColumn(), constants.empty(),
"30px"); //$NON-NLS-1$
getTable().addColumn(new TextColumnWithTooltip<Quota>() {
@@ -40,14 +42,14 @@
public String getValue(Quota object) {
return object.getQuotaName() == null ? "" :
object.getQuotaName(); //$NON-NLS-1$
}
- }, constants.nameQuota());
+ }, constants.nameQuota(), "400px"); //$NON-NLS-1$
getTable().addColumn(new TextColumnWithTooltip<Quota>() {
@Override
public String getValue(Quota object) {
return object.getDescription() == null ? "" :
object.getDescription(); //$NON-NLS-1$
}
- }, constants.descriptionQuota());
+ }, constants.descriptionQuota(), "400px"); //$NON-NLS-1$
getTable().addActionButton(new
WebAdminButtonDefinition<Quota>(constants.addQuota()) {
@Override
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterStorageView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterStorageView.java
index 3b7e5c7..bc2fd76 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterStorageView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterStorageView.java
@@ -39,6 +39,8 @@
}
void initTable(ApplicationConstants constants) {
+ getTable().enableColumnResizing();
+
getTable().addColumn(new StorageDomainStatusColumn(),
constants.empty(), "30px"); //$NON-NLS-1$
TextColumnWithTooltip<StorageDomain> nameColumn = new
TextColumnWithTooltip<StorageDomain>() {
@@ -47,7 +49,7 @@
return object.getStorageName();
}
};
- getTable().addColumn(nameColumn, constants.domainNameStorage());
+ getTable().addColumn(nameColumn, constants.domainNameStorage(),
"160px"); //$NON-NLS-1$
TextColumnWithTooltip<StorageDomain> typeColumn = new
EnumColumn<StorageDomain, StorageDomainType>() {
@Override
@@ -55,7 +57,7 @@
return object.getStorageDomainType();
}
};
- getTable().addColumn(typeColumn, constants.domainTypeStorage());
+ getTable().addColumn(typeColumn, constants.domainTypeStorage(),
"160px"); //$NON-NLS-1$
TextColumnWithTooltip<StorageDomain> statusColumn = new
EnumColumn<StorageDomain, StorageDomainStatus>() {
@Override
@@ -63,7 +65,7 @@
return object.getStatus();
}
};
- getTable().addColumn(statusColumn, constants.statusStorage());
+ getTable().addColumn(statusColumn, constants.statusStorage(),
"160px"); //$NON-NLS-1$
DiskSizeColumn<StorageDomain> freeColumn = new
DiskSizeColumn<StorageDomain>(DiskSizeUnit.GIGABYTE) {
@Override
@@ -72,7 +74,7 @@
return (long) availableDiskSize;
}
};
- getTable().addColumn(freeColumn, constants.freeSpaceStorage());
+ getTable().addColumn(freeColumn, constants.freeSpaceStorage(),
"160px"); //$NON-NLS-1$
DiskSizeColumn<StorageDomain> usedColumn = new
DiskSizeColumn<StorageDomain>(DiskSizeUnit.GIGABYTE) {
@Override
@@ -81,7 +83,7 @@
return (long) usedDiskSize;
}
};
- getTable().addColumn(usedColumn, constants.usedSpaceStorage());
+ getTable().addColumn(usedColumn, constants.usedSpaceStorage(),
"160px"); //$NON-NLS-1$
DiskSizeColumn<StorageDomain> totalColumn = new
DiskSizeColumn<StorageDomain>(DiskSizeUnit.GIGABYTE) {
@Override
@@ -90,7 +92,7 @@
return (long) totalDiskSize;
}
};
- getTable().addColumn(totalColumn, constants.totalSpaceStorage());
+ getTable().addColumn(totalColumn, constants.totalSpaceStorage(),
"160px"); //$NON-NLS-1$
TextColumnWithTooltip<StorageDomain> descriptionColumn = new
TextColumnWithTooltip<StorageDomain>() {
@Override
@@ -98,7 +100,7 @@
return object.getDescription();
}
};
- getTable().addColumn(descriptionColumn,
constants.domainDescriptionStorage());
+ getTable().addColumn(descriptionColumn,
constants.domainDescriptionStorage(), "160px"); //$NON-NLS-1$
getTable().addActionButton(new
WebAdminButtonDefinition<StorageDomain>(constants.attachDataStorage()) {
@Override
--
To view, visit http://gerrit.ovirt.org/14105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I71465d36e5c18ecb8eb6dbca436feaeea1c902a9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
