Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: stricter FQDN validation
..
packaging: stricter FQDN validation
common_utils.getConfiguredIps now returns only Ips configured on
non loopbac
Juan Hernandez has posted comments on this change.
Change subject: packaging: stricter FQDN validation
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13933
To unsubscribe, visit http://gerr
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: refactored firewalld support
..
Patch Set 6:
Any comment from other reviewers?
--
To view, visit http://gerrit.ovirt.org/13638
To unsubscribe, vis
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: stricter FQDN validation
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13933
To unsubscribe
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: stricter FQDN validation
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/13933
To unsubscribe, visit http://gerrit.ovirt.org/set
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: refactored firewalld support
..
Patch Set 6: Looks good to me, but someone else must approve
Thanks!
--
To view, visit http://gerrit.ovirt.org/13638
T
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: stricter FQDN validation
..
Patch Set 5: (1 inline comment)
File packaging/fedora/setup/common
Laszlo Hornyak has posted comments on this change.
Change subject: engine: remove unused roles_relations
..
Patch Set 1:
Eli, Yair, can you look into this patch?
--
To view, visit http://gerrit.ovirt.org/13940
To unsubscribe,
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Log stacktrace when VDS command execution failed
..
core: Log stacktrace when VDS command execution failed
Added stacktrace to debug log when an
Yair Zaslavsky has posted comments on this change.
Change subject: core: Log stacktrace when VDS command execution failed
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14049
To u
Yair Zaslavsky has posted comments on this change.
Change subject: core: Log stacktrace when VDS command execution failed
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14049
To unsubscribe, visit http://ger
Yair Zaslavsky has posted comments on this change.
Change subject: core: Log stacktrace when VDS command execution failed
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14049
To unsubscribe
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Host General sub-tab unlocalized strings found
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14059
To unsubscri
Sahina Bose has posted comments on this change.
Change subject: core,webadmin: Host reboot false for gluster only host
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/13384
To unsubscribe, visit http://gerrit
Sahina Bose has posted comments on this change.
Change subject: core,webadmin: Host reboot false for gluster only host
..
Patch Set 2: (3 inline comments)
File
frontend/weba
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: findbugs + improving code
..
core: findbugs + improving code
Fixing findbugs issue + improving code
readability
1. Removed dictemp + assigntmet
Yair Zaslavsky has posted comments on this change.
Change subject: core: findbugs + improving code
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14065
To unsubscribe, visit http:
Allon Mureinik has posted comments on this change.
Change subject: core: findbugs + improving code
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14065
To unsubscribe, visit http://gerrit.o
Alon Bar-Lev has posted comments on this change.
Change subject: userportal, webadmin: branding support[WIP].
..
Patch Set 6: (2 inline comments)
File
frontend/webadmin/modu
Alexander Wels has posted comments on this change.
Change subject: userportal, webadmin: branding support[WIP].
..
Patch Set 6: (3 inline comments)
File
frontend/webadmin/mo
Yair Zaslavsky has posted comments on this change.
Change subject: core: findbugs + improving code
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: findbugs + improving code
..
core: findbugs + improving code
Fixing findbugs issue + improving code
readability
Change-Id: Icc7794df32b8d0f4cf08f7c5259b
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: truncated text in Storage-Disks sub-tab
..
webadmin: truncated text in Storage-Disks sub-tab
Fixed truncated headers in Storage -> Disks sub-tab.
Chang
Kanagaraj M has uploaded a new change for review.
Change subject: engine: adding vds_gluster table and dao operations
..
engine: adding vds_gluster table and dao operations
A new table 'vds_gluster' is added. Currently this will
Michael Pasternak has posted comments on this change.
Change subject: restapi: disabling POST implementation for quota
..
Patch Set 1: (1 inline comment)
Commit Message
Line
Federico Simoncelli has posted comments on this change.
Change subject: core: add repo_file_id to repo_file_meta_data
..
Patch Set 4: Verified
Re-verified only with the tests and a database upgrade.
--
To view, visit http://ge
Alexander Wels has uploaded a new change for review.
Change subject: userportal: resources->quota updating
..
userportal: resources->quota updating
- Fixed resources quota class cast exception causing
quota not to update.
Chang
Michael Pasternak has posted comments on this change.
Change subject: restapi: disabling POST implementation for quota
..
Patch Set 1:
in RESTful application this is done via (HTTP Error 405 Method not allowed)
when no POST/DE
Michael Pasternak has posted comments on this change.
Change subject: restapi: disabling POST implementation for quota
..
Patch Set 1: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/14046
T
Michael Pasternak has posted comments on this change.
Change subject: restapi: disabling POST implementation for quota
..
Patch Set 1:
throwing UnsupportedOperationException exception in production
environment not commonly used
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: truncated text in Disks main-tab
..
webadmin: truncated text in Disks main-tab
Fixed truncated headers in Disks main-tab.
Change-Id: I2d8a8e939e4f1b09f
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/856/
Build Number: 856
Build Status: Failure
Triggered By: Started by an SCM change, Started by an SCM change
-
Changes Since Last Succ
Allon Mureinik has submitted this change and it was merged.
Change subject: core: unify GetImagesList using ImageFileType.All
..
core: unify GetImagesList using ImageFileType.All
It is possible to unify the two separate request
Allon Mureinik has submitted this change and it was merged.
Change subject: core: remove redundant image listing by pool
..
core: remove redundant image listing by pool
There is no need for a specific procedure (and specific DA
Allon Mureinik has posted comments on this change.
Change subject: core: remove redundant image listing by pool
..
Patch Set 6: Verified; Looks good to me, approved
Rebased, no chages
--
To view, visit http://gerrit.ovirt.org/
Allon Mureinik has posted comments on this change.
Change subject: core: unify GetImagesList using ImageFileType.All
..
Patch Set 7: Verified; Looks good to me, approved
Rebased, no changes
--
To view, visit http://gerrit.ovir
Ravi Nori has abandoned this change.
Change subject: restapi : Error concerning "update network --cluster-identifier
--usages-usage"
..
Patch Set 1: Abandoned
Will submit cli fix
--
To view, visit http://gerrit.ovirt.org/1386
Ravi Nori has posted comments on this change.
Change subject: cli: Error in "update network --cluster-identifier
--usages-usage"
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14060
To unsubscribe, visit ht
Ravi Nori has uploaded a new change for review.
Change subject: cli: Error in "update network --cluster-identifier
--usages-usage"
..
cli: Error in "update network --cluster-identifier --usages-usage"
When running update networ
Barak Azulay has submitted this change and it was merged.
Change subject: pki: update POSIX sh compatibility
..
pki: update POSIX sh compatibility
Change-Id: I3ae7b6a9d88b87d134676acbd216a075bbad76f8
Signed-off-by: Alon Bar-Lev
Barak Azulay has posted comments on this change.
Change subject: pki: update POSIX sh compatibility
..
Patch Set 3: Verified; Looks good to me, approved
Verified by: Alon
Reviewed by: Sandro
--
To view, visit http://gerrit.ovi
Barak Azulay has posted comments on this change.
Change subject: pki: update POSIX sh compatibility
..
Patch Set 2: Verified
Verified by: Alon bl
Reviewed by: Sandro
--
To view, visit http://gerrit.ovirt.org/13901
To unsubscri
Barak Azulay has posted comments on this change.
Change subject: pki: update POSIX sh compatibility
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13901
To unsubscribe, visit http://gerrit.
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: Host General sub-tab unlocalized strings found
..
webadmin: Host General sub-tab unlocalized strings found
changes are described in bugzilla.
Chang
Alex Lourie has posted comments on this change.
Change subject: packaging: stricter FQDN validation
..
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
...
Doron Fediuck has submitted this change and it was merged.
Change subject: webadmin: Fix the phrasing of error message
..
webadmin: Fix the phrasing of error message
message was: Cannot edit VM. Dedicated Host Cluster is not id
Doron Fediuck has posted comments on this change.
Change subject: webadmin: Fix the phrasing of error message
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14054
To unsubscribe,
Doron Fediuck has posted comments on this change.
Change subject: webadmin: Fix the phrasing of error message
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14054
To unsubscribe, visit http
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: re-use external gettext
..
build: re-use external gettext
Change-Id: Ie10b6003d1c5ebb32e9c6cea216a56c9b5422e15
Signed-off-by: Alon Bar-Lev
---
M
Alon Bar-Lev has posted comments on this change.
Change subject: build: re-use external gettext
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14057
To unsubscribe, visit http://g
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: re-use external gettext
..
build: re-use external gettext
Change-Id: Ie10b6003d1c5ebb32e9c6cea216a56c9b5422e15
Signed-off-by: Alon Bar-Lev
---
M .gitigno
Maor Lipchuk has submitted this change and it was merged.
Change subject: core : fix message when removing template from export domain
..
core : fix message when removing template from export domain
Change-Id: I44b8f026bf381c11
Maor Lipchuk has posted comments on this change.
Change subject: core : fix message when removing template from export domain
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14056
To unsubsc
Maor Lipchuk has posted comments on this change.
Change subject: core: Extract SD validations from ImagesHandler
..
Patch Set 10: Looks good to me, approved
(2 inline comments)
.
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: re-use external gettext
..
build: re-use external gettext
Change-Id: Ic124ffe0e24eb9b469535db221f64bdce2ff0351
Signed-off-by: Alon Bar-Lev
---
M
Alon Bar-Lev has posted comments on this change.
Change subject: build: re-use external gettext
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14036
To unsubscribe, visit http://g
Alon Bar-Lev has posted comments on this change.
Change subject: build: use external gettext
..
Patch Set 2: Looks good to me, but someone else must approve
OK... no need for more acks, just merge this to all.
--
To view, visi
Alon Bar-Lev has posted comments on this change.
Change subject: Remove sh bang from ovfenvelope.py.
..
Patch Set 2: I would prefer that you didn't submit this
This source is also used for testing, so it is a script. The shbang
Alon Bar-Lev has posted comments on this change.
Change subject: Package must own all directories that it creates.
..
Patch Set 1: (1 inline comment)
File ovirt-image-uploade
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Element IDs in Assign Tags and Role dialogs
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14055
To unsubscribe, visit http://gerri
Liron Ar has posted comments on this change.
Change subject: core : fix message when removing template from export domain
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14056
To unsubscribe, visit http://ger
Liron Ar has uploaded a new change for review.
Change subject: core : fix message when removing template from export domain
..
core : fix message when removing template from export domain
Change-Id: I44b8f026bf381c114157f5573753
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: Element IDs in Assign Tags and Role dialogs
..
webadmin: Element IDs in Assign Tags and Role dialogs
1. Assign Tags dialog (Users main tab) now suppor
ofri masad has posted comments on this change.
Change subject: webadmin: Fix the phrasing of error message
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14054
To unsubscribe, visit http://gerrit.ovirt.org/s
ofri masad has uploaded a new change for review.
Change subject: webadmin: Fix the phrasing of error message
..
webadmin: Fix the phrasing of error message
message was: Cannot edit VM. Dedicated Host Cluster is not identical to
Alon Bar-Lev has submitted this change and it was merged.
Change subject: gluster: starting glusterd after install
..
gluster: starting glusterd after install
glusterd service was not started after installing. Added an event
wh
Alexander Wels has posted comments on this change.
Change subject: webadmin: User Event Notification dialog element IDs
..
Patch Set 2: (2 inline comments)
File
frontend/web
Doron Fediuck has posted comments on this change.
Change subject: engine: watchdog - DB changes [wip]
..
Patch Set 4: (1 inline comment)
Agree with Omer on the fixtures.
Also missing some event details (see inline).
..
Arik Hadas has uploaded a new change for review.
Change subject: core: [WIP] add memory volume column to the snapshots table
..
core: [WIP] add memory volume column to the snapshots table
Change-Id: Iecda4c491fe6e207386edf2a9bf2
Doron Fediuck has posted comments on this change.
Change subject: restapi: disabling POST implementation for quota
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14046
Sandro Bonazzola has posted comments on this change.
Change subject: build: use external gettext
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14051
To unsubscribe, vi
Allon Mureinik has posted comments on this change.
Change subject: core: Remove get image info call before images commands
..
Patch Set 3: I would prefer that you didn't submit this
As far as I could understand from Einav, you
Sandro Bonazzola has posted comments on this change.
Change subject: build: use external gettext
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14022
To unsubscribe, vi
Federico Simoncelli has uploaded a new change for review.
Change subject: build: use external gettext
..
build: use external gettext
To avoid a prartial redistribution of gettext, the macro AM_GNU_GETTEXT
has been configured wit
Sandro Bonazzola has posted comments on this change.
Change subject: build: use external gettext
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14020
To unsubscribe, vi
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: wrong quota(s) in dc-quota subtab
..
webadmin: wrong quota(s) in dc-quota subtab
Caused by a call to super.syncSearch(), which created a
wrong (anothe
Omer Frenkel has posted comments on this change.
Change subject: core: prevent create snapshot when the vm has illegal disks.
..
Patch Set 1: (1 inline comment)
File
backend
Mike Kolesnik has posted comments on this change.
Change subject: findbugs: When implementing compareTo implement Object.equals
as well
..
Patch Set 2: (3 inline comments)
Please see my comments on NetworkStatistics class and
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Auto recovery ignores hosts with problematic NICs
..
engine: Auto recovery ignores hosts with problematic NICs
Such hosts cannot be automatically
Moti Asayag has posted comments on this change.
Change subject: engine: Auto recovery ignores hosts with problematic NICs
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14047
To unsubscribe
Mike Kolesnik has posted comments on this change.
Change subject: engine: Auto recovery ignores hosts with problematic NICs
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14047
To unsubscribe, visit http://g
Mike Kolesnik has posted comments on this change.
Change subject: engine: Auto recovery ignores hosts with problematic NICs
..
Patch Set 1: (2 inline comments)
File
backend/
Martin Peřina has uploaded a new change for review.
Change subject: core: Log stacktrace when VDS command execution failed
..
core: Log stacktrace when VDS command execution failed
Added stacktrace to debug log when an exception
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: User Event Notification dialog element IDs
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14048
To unsubscribe, visit http://gerrit
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Introduction of Poller, CommandEntity and Ehcache
..
Patch Set 4:
Changed command entity to hold a "data" field instead of parameters.
This is done to
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: User Event Notification dialog element IDs
..
Patch Set 1: (1 inline comment)
File frontend/webadm
Moti Asayag has posted comments on this change.
Change subject: engine: Auto recovery ignores hosts with problematic NICs
..
Patch Set 1: (2 inline comments)
File
backend/ma
Roy Golan has posted comments on this change.
Change subject: core: Remove get image info call before images commands
..
Patch Set 3: Verified
comments addressed
--
To view, visit http://gerrit.ovirt.org/13994
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: findbugs: When implementing compareTo implement Object.equals
as well
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: User Event Notification dialog element IDs
..
webadmin: User Event Notification dialog element IDs
1. UI infrastructure changes
- created ElementI
Tomas Jelinek has posted comments on this change.
Change subject: userportal,webadmin: implement VM builder
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/13915
To unsubscribe, visit http://gerrit.ovirt.org/
Mike Kolesnik has posted comments on this change.
Change subject: engine: Auto recovery ignores hosts with problematic NICs
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14047
To unsubscribe, visit http://g
Shahar Havivi has submitted this change and it was merged.
Change subject: findbugs: Method fail to close stream
..
findbugs: Method fail to close stream
Change-Id: I5bea678c1aaeeb6dfe92b16e380e4bc631e3d09c
Signed-off-by: Shaha
Shahar Havivi has posted comments on this change.
Change subject: findbugs: Method fail to close stream
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14037
To unsubscribe, visit
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Auto recovery ignores hosts with problematic NICs
..
engine: Auto recovery ignores hosts with problematic NICs
Such hosts cannot be automatically recove
Shahar Havivi has posted comments on this change.
Change subject: findbugs: Method fail to close stream
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14037
To unsubscribe, visit http://gerrit.ovirt.org/sett
Gilad Chaplik has posted comments on this change.
Change subject: core: NPE in add quota via rest
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14028
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gilad Chaplik has posted comments on this change.
Change subject: core: NPE in add quota via rest
..
Patch Set 2:
currently this code is unreachable, but it will be in use (and needed) once
implementing quota in rest api.
--
Gilad Chaplik has uploaded a new change for review.
Change subject: restapi: disabling POST implementation for quota
..
restapi: disabling POST implementation for quota
It is not fully implemented, therefore disabling it.
Chang
Kiril Nesenko has submitted this change and it was merged.
Change subject: packaging: post ovirt-image-uploader-3.2.2
..
packaging: post ovirt-image-uploader-3.2.2
Change-Id: I174d8008553764953b19727b3223eb809322aa99
Signed-off
1 - 100 of 424 matches
Mail list logo
