Doron Fediuck has posted comments on this change.

Change subject: engine: watchdog - DB changes [wip]
......................................................................


Patch Set 4: (1 inline comment)

Agree with Omer on the fixtures.
Also missing some event details (see inline).

....................................................
File 
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 598: GLUSTER_VOLUME_STOPPED_FROM_CLI=Detected that Volume 
${glusterVolumeName} of Cluster ${VdsGroupName} was stopped, and updated engine 
DB with it's new status.
Line 599: GLUSTER_HOOK_ENABLE=Gluster Hook ${GlusterHookName} enabled on 
cluster ${VdsGroupName}.
Line 600: GLUSTER_HOOK_ENABLE_PARTIAL=Gluster Hook ${GlusterHookName} enabled 
on some of the servers on cluster ${VdsGroupName}. ${FailureMessage}
Line 601: GLUSTER_HOOK_ENABLE_FAILED=Failed to enable Gluster Hook 
${GlusterHookName} on cluster ${VdsGroupName}. ${FailureMessage}
Line 602: WATCHDOG_EVENT=Watchdog event triggered on ${VmName}.
Yes and which action was taken.


--
To view, visit http://gerrit.ovirt.org/13057
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I813a6f97e23008d15446285998a4e9b50b456040
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to