Mike Kolesnik has posted comments on this change.

Change subject: engine: Auto recovery ignores hosts with problematic NICs
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 713:         }
Line 714:     }
Line 715: 
Line 716:     /**
Line 717:      * Determine which of the given NICs is problematic - there's a 
network that is required and down on the NIC or
Done
Line 718:      * bond.
Line 719:      *
Line 720:      * @param interfaces
Line 721:      *            The NICs to check.


Line 746:                 populate(bondsWithStatus, interfaces, 
clusterNetworks, networks, bondsWithListOfNics, iface);
Line 747:             }
Line 748:         }
Line 749: 
Line 750:         // check the bond statuses, if one is down we set the host to 
down
Done
Line 751:         // only if we didn't already set the host to down
Line 752:         if (brokenNics.isEmpty()) {
Line 753:             for (String key : bondsWithStatus.keySet()) {
Line 754:                 if (!bondsWithStatus.get(key)) {


--
To view, visit http://gerrit.ovirt.org/14047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70bff4ba5541156c31fb8afdd38ff6f706c0d869
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to