Tomas Jelinek has posted comments on this change.
Change subject: userportal,webadmin: disable SPICE proxy has no effect
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13937
To unsubscribe, visit http://gerr
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal,webadmin: disable SPICE proxy has no effect
..
userportal,webadmin: disable SPICE proxy has no effect
Edit console dialog -> enable SPICE proxy -> co
Laszlo Hornyak has posted comments on this change.
Change subject: engine: test for AddVdsCommand
..
Patch Set 8:
anyone against this patch? It is only two months old but we it could go
--
To view, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: core: Unused field from SimpleAuthenticationCheck
..
Patch Set 2: Verified
Rebased, no code changes
--
To view, visit http://gerrit.ovirt.org/13870
To unsubscr
Allon Mureinik has posted comments on this change.
Change subject: core: DLS in OvfLogEventHandler.addValueForAlias
..
Patch Set 4: Verified
Rebased, no code changes
--
To view, visit http://gerrit.ovirt.org/13650
To unsubscri
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: Unused field in ConfigureLocalStorageModel
..
webadmin: Unused field in ConfigureLocalStorageModel
Removed the unused field
ConfigureLocalSto
Allon Mureinik has posted comments on this change.
Change subject: webadmin: Unused field in ConfigureLocalStorageModel
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
Fixed commit msg as per Tal'
Allon Mureinik has posted comments on this change.
Change subject: core, webadmin: unify and move Disk Comparators
..
Patch Set 3: Verified
A more comprehensive patch, including frontend
--
To view, visit http://gerrit.ovirt.o
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove GetAgentFenceOptions2Query
..
core: Remove GetAgentFenceOptions2Query
GetAgentFenceOptionsQuery and GetAgentFenceOptions2Query are complet
Allon Mureinik has posted comments on this change.
Change subject: core: Remove GetAgentFenceOptions2Query
..
Patch Set 4: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by mkublin.
--
To view, visit http://
Allon Mureinik has posted comments on this change.
Change subject: core: Move Disk comperators to the right package
..
Patch Set 2:
After looking a bit deeper, we seem to have half a dozen comperators for disks,
all over the s
Allon Mureinik has posted comments on this change.
Change subject: engine: VmTemplate cleanup (2/3)
..
Patch Set 3:
@Laszlo - looks great to me.
I'd like Omer or Roy to ack it, just to be on the safe side, though
--
To view, v
Allon Mureinik has posted comments on this change.
Change subject: engine: Remove DbUser.iconPath property
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13705
To unsub
Allon Mureinik has posted comments on this change.
Change subject: engine: hashcode method simplification [wip]
..
Patch Set 3:
I don't understand why this patch was abandoned.
There are three engine-core reviewers assigned to
Allon Mureinik has posted comments on this change.
Change subject: engine: test for AddVdsCommand
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12193
To unsubscribe, v
Allon Mureinik has posted comments on this change.
Change subject: engine: Do not add disk in snapshot preview
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13327
To u
Allon Mureinik has posted comments on this change.
Change subject: engine: remove DBUser.desktopDevice
..
Patch Set 4: Looks good to me, but someone else must approve
Please also remove BusinessEntitiesDefinitions.USER_DESKTOP_
Allon Mureinik has posted comments on this change.
Change subject: wip: core: RemoveImage as sync operation
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13611
To unsu
Allon Mureinik has posted comments on this change.
Change subject: core: Add VDSM error message for local directory not found
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: Use name groups for ISO tools
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13899
To unsubscri
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused shutdown commands.
..
Patch Set 3: I would prefer that you didn't submit this
Much better!
You forgot, however, to remove the method from V
Allon Mureinik has posted comments on this change.
Change subject: core: CreateAllSnapshots..Command#executeVmCommand cleanup
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: prevent create snapshot when the vm has illegal disks.
..
Patch Set 1: Looks good to me, but someone else must approve
@Maor - not being able to run a sta
Allon Mureinik has posted comments on this change.
Change subject: core: Mount options not sent when adding POSIX domain
..
Patch Set 1: I would prefer that you didn't submit this
I don't understand this patch at all.
First, m
Allon Mureinik has posted comments on this change.
Change subject: engine: AssingQuota button under disks refresh bug
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
The database changes seem
Laszlo Hornyak has posted comments on this change.
Change subject: core: clarify conditional expression in checkImageValidity
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9089
T
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: clarify conditional expression in checkImageValidity
..
core: clarify conditional expression in checkImageValidity
Add indentation and parenthesi
Ravi Nori has uploaded a new change for review.
Change subject: restapi : Add brick operation fails from ovirt-shell(#923169)
..
restapi : Add brick operation fails from ovirt-shell(#923169)
add brick operation fails from ovirt-
Ravi Nori has posted comments on this change.
Change subject: cli: Error type "brick" does not exist." on replace brick
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13935
To unsubscribe, visit http://gerri
Ravi Nori has uploaded a new change for review.
Change subject: cli: Error type "brick" does not exist." on replace brick
..
cli: Error type "brick" does not exist." on replace brick
When trying to perform replace-brick operatio
Allon Mureinik has submitted this change and it was merged.
Change subject: core: prevent performing preview when the vm has illegal disks
..
core: prevent performing preview when the vm has illegal disks
When attempting to pre
Allon Mureinik has posted comments on this change.
Change subject: core: prevent performing preview when the vm has illegal disks
..
Patch Set 4: Verified; Looks good to me, approved
Rebased, no code changes.
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Update maven-war-plugin and maven-ear-plugin
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13908
To unsubscribe, vi
Allon Mureinik has posted comments on this change.
Change subject: core: prevent performing preview when the vm has illegal disks
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13896
To uns
Laszlo Hornyak has posted comments on this change.
Change subject: engine: VmTemplate cleanup (2/3)
..
Patch Set 3:
anyone agains this patch?
--
To view, visit http://gerrit.ovirt.org/13433
To unsubscribe, visit http://gerrit.
Laszlo Hornyak has posted comments on this change.
Change subject: engine: VmTemplate cleanup (1/3)
..
Patch Set 3:
anyone against this patch?
--
To view, visit http://gerrit.ovirt.org/13432
To unsubscribe, visit http://gerrit
Laszlo Hornyak has posted comments on this change.
Change subject: engine: remove DBUser.desktopDevice
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/13531
To unsubscribe, visit http://gerrit.ovirt.org/setti
Laszlo Hornyak has posted comments on this change.
Change subject: engine: remove DBUser.desktopDevice
..
Patch Set 3: (2 inline comments)
File backend/manager/dbscripts/crea
Laszlo Hornyak has abandoned this change.
Change subject: engine: hashcode method simplification [wip]
..
Patch Set 3: Abandoned
this conversation is stuck
--
To view, visit http://gerrit.ovirt.org/13385
To unsubscribe, visit
Laszlo Hornyak has posted comments on this change.
Change subject: engine: test for AddVdsCommand
..
Patch Set 7: (2 inline comments)
File
backend/manager/modules/bll/src/ma
Laszlo Hornyak has posted comments on this change.
Change subject: core: Move Disk comperators to the right package
..
Patch Set 2: Looks good to me, but someone else must approve
I think it is a good idea to move these classes
Laszlo Hornyak has posted comments on this change.
Change subject: core: move findActiveISODomain to IsoDomainListSyncronizer (2)
..
Patch Set 5: (1 inline comment)
File
bac
Laszlo Hornyak has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (1)
..
Patch Set 4: (2 inline comments)
File
backend/manager/module
Laszlo Hornyak has posted comments on this change.
Change subject: core: removing canRunVm helper compat method
..
Patch Set 3: (1 inline comment)
File
backend/manager/modul
Laszlo Hornyak has posted comments on this change.
Change subject: core: initial module commit (4/15)
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13114
To unsubscrib
Sandro Bonazzola has posted comments on this change.
Change subject: pki: update POSIX sh compatibility
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13901
To unsubscr
Laszlo Hornyak has posted comments on this change.
Change subject: core: removing org.apache.commons.lang dependency (5/15)
..
Patch Set 4: (2 inline comments)
File
backend/
Sandro Bonazzola has posted comments on this change.
Change subject: pki: update POSIX sh compatibility
..
Patch Set 1: (1 inline comment)
File backend/manager/conf/ca/Create
Einav Cohen has submitted this change and it was merged.
Change subject: userportal, weadmin: fix root pom
..
userportal, weadmin: fix root pom
- fixed backend root pom, by removed extra dependency
that is not needed as commons
Einav Cohen has posted comments on this change.
Change subject: userportal, weadmin: fix root pom
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13932
To unsubscribe, visit http:/
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: stricter FQDN validation
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13933
To unsubscribe, visit http://gerrit.ovirt.org/set
Lior Vernia has posted comments on this change.
Change subject: webadmin: Removed unused import
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13934
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: VdsDAO.getAllWithName now returns instance
..
core: VdsDAO.getAllWithName now returns instance
List VdsDAO.getAllWithName(String) has been change
Laszlo Hornyak has posted comments on this change.
Change subject: core: VdsDAO.getAllWithName now returns instance
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13827
To unsubsc
Lior Vernia has uploaded a new change for review.
Change subject: webadmin: Removed unused import
..
webadmin: Removed unused import
Added accidentally by me in the past, doesn't break builds but needed to
be cleaned.
Change-Id
Sandro Bonazzola has uploaded a new change for review.
Change subject: packaging: stricter FQDN validation
..
packaging: stricter FQDN validation
common_utils.getConfiguredIps now returns only Ips configured on
non loopback devi
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: refactored firewalld support
..
Patch Set 2: (2 inline comments)
File packaging/fedora/setup/plugi
Alexander Wels has posted comments on this change.
Change subject: userportal, weadmin: fix root pom
..
Patch Set 1: Verified
Removed extra dependency that was defined in one of the parent poms already.
This one caused extra f
Alon Bar-Lev has posted comments on this change.
Change subject: pki: update POSIX sh compatibility
..
Patch Set 2: Verified
Remove die from CreateCA
--
To view, visit http://gerrit.ovirt.org/13901
To unsubscribe, visit http:/
Alon Bar-Lev has posted comments on this change.
Change subject: pki: update POSIX sh compatibility
..
Patch Set 1: (1 inline comment)
File backend/manager/conf/ca/CreateCA.s
Alexander Wels has uploaded a new change for review.
Change subject: userportal, weadmin: fix root pom
..
userportal, weadmin: fix root pom
- fixed backend root pom, by removed extra dependency
that is not needed as commons-logg
Alon Bar-Lev has posted comments on this change.
Change subject: pki: update POSIX sh compatibility
..
Patch Set 1: (3 inline comments)
File backend/manager/conf/ca/CreateCA.
Frank Kobzik has posted comments on this change.
Change subject: engine: Integrate noVNC support
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13931
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Frank Kobzik has uploaded a new change for review.
Change subject: engine: Integrate noVNC support
..
engine: Integrate noVNC support
This patch integrates noVNC support in the engine.
For this to work, there must be oVirt webso
Maor Lipchuk has posted comments on this change.
Change subject: core: Remove unused shutdown commands.
..
Patch Set 1:
Translations should be updated in another process
--
To view, visit http://gerrit.ovirt.org/13889
To unsub
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: quota: general subtab: set empty label
..
webadmin: quota: general subtab: set empty label
In case quota is enforced, and not configured per vm/templa
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: AssingQuota button under disks refresh bug
..
webadmin: AssingQuota button under disks refresh bug
In case a quota mode set to !Disabled (or vice-vers
Liron Ar has posted comments on this change.
Change subject: core: prevent performing preview when the vm has illegal disks
..
Patch Set 3: Verified
preview with legal disk - worked.
preview illegal disks - CDA message.
--
To
Tal Nisan has posted comments on this change.
Change subject: webadmin: Remove deprecated CopyTemplate logic
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13907
To unsubscribe, visit http:
Tal Nisan has posted comments on this change.
Change subject: webadmin: Remove deprecated MoveVm logic
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13906
To unsubscribe, visit http://gerr
Juan Hernandez has posted comments on this change.
Change subject: Add support for OpenLDAP as domain provider
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Giuseppe Vallarelli has posted comments on this change.
Change subject: engine: send nic parameter in vmUpdateDevice [wip]
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: fix volume labels in ja and fr locale
..
webadmin: fix volume labels in ja and fr locale
Increased the width of Gluster Volume column in events
Kanagaraj M has posted comments on this change.
Change subject: webadmin: fix volume labels in ja and fr locale
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13919
To unsubscribe
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: fix volume labels in ja and fr locale
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13919
To unsubscribe, visit
Libor Spevak has posted comments on this change.
Change subject: engine: Do not add disk in snapshot preview
..
Patch Set 9:
Rebased.
--
To view, visit http://gerrit.ovirt.org/13327
To unsubscribe, visit http://gerrit.ovirt.or
Libor Spevak has posted comments on this change.
Change subject: engine,webadmin: Run and pause action enabled
..
Patch Set 4:
Roy, please look at newly overridden method:
- RunVmCommand.reportCompleted
Now the Task events look
Libor Spevak has posted comments on this change.
Change subject: engine,webadmin: Run and pause action enabled
..
Patch Set 3: (1 inline comment)
File
frontend/webadmin/modu
Laszlo Hornyak has uploaded a new change for review.
Change subject: engine: send nic parameter in vmUpdateDevice [wip]
..
engine: send nic parameter in vmUpdateDevice [wip]
vdsm has some problem with the missing nic parameters
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: fix volume labels in ja and fr locale
..
webadmin: fix volume labels in ja and fr locale
Increased the width of Gluster Volume column in events tab
to a
Tomas Jelinek has uploaded a new change for review.
Change subject: webadmin: Network builders
..
webadmin: Network builders
Instance types Phase 1: extract and merge common code
as builders from models.
This will be needed by
Ori Liel has posted comments on this change.
Change subject: restapi: #920483 - Group Wrongly Displayed as User (within
permission)
..
Patch Set 1: (1 inline comment)
Answered your question about the tests - same answer applie
Juan Hernandez has posted comments on this change.
Change subject: core: Remove unused LoginUserParameters fields
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13916
To unsubscribe, visit http://gerrit.ovir
Juan Hernandez has uploaded a new change for review.
Change subject: core: Remove unused LoginUserParameters fields
..
core: Remove unused LoginUserParameters fields
The os, browser and clientType fields of this parameter class
Omer Frenkel has posted comments on this change.
Change subject: core: fix single sign on for all guests
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13667
To unsubscribe, visit http://ge
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: refactored firewalld support
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/13638
To unsubscribe, visit http://gerrit.ovirt.org
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: refactored firewalld support
..
Patch Set 2: (3 inline comments)
File Makefile
Line 273:
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal,webadmin: implement VM builder
..
userportal,webadmin: implement VM builder
Instance types Phase 1: extract and merge common code
as builders from li
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Remove deprecated MoveVm logic
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13906
To unsubscribe, visit http://
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Remove deprecated CopyTemplate logic
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13907
To unsubscribe, visit h
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-upgrade - log DB upgrade in the right place
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: [ja_JP] Networks Tab - Clusters Sub-tab column
headers truncated
..
webadmin: [ja_JP] Networks Tab - Clusters Sub-tab column headers truncated
Column
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: [ja_JP] Vms-Network Interfaces Sub-tab column headers
truncated
..
webadmin: [ja_JP] Vms-Network Interfaces Sub-tab column headers truncated
Link Stat
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: [ja_JP] Networks Tab - Hosts Sub Tab column headers
truncated
..
webadmin: [ja_JP] Networks Tab - Hosts Sub Tab column headers truncated
Column head
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Remove unused manifest from root webapp
..
core: Remove unused manifest from root webapp
The file src/resources/META-INF/MANIFEST.MF is not used,
Juan Hernandez has posted comments on this change.
Change subject: core: Remove unused manifest from root webapp
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13910
To unsubscrib
Juan Hernandez has uploaded a new change for review.
Change subject: core: Remove unused manifest from root webapp
..
core: Remove unused manifest from root webapp
The file src/resources/META-INF/MANIFEST.MF is not used, it is t
Omer Frenkel has posted comments on this change.
Change subject: core: CreateAllSnapshots..Command#executeVmCommand cleanup
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13897
To unsubscri
Laszlo Hornyak has posted comments on this change.
Change subject: engine: watchdog - DB changes [wip]
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/dal/sr
Laszlo Hornyak has posted comments on this change.
Change subject: engine: watchdog - restapi support [wip]
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/r
1 - 100 of 111 matches
Mail list logo
