Laszlo Hornyak has posted comments on this change. Change subject: core: move findActiveISODomain to IsoDomainListSyncronizer (2) ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java Line 73: /** Line 74: * private constructor to initialize the quartz scheduler Line 75: */ Line 76: private IsoDomainListSyncronizer() { Line 77: init(); why do you move it to another method? Will you override it somewhere as well? Line 78: } Line 79: Line 80: protected void init() { Line 81: log.info("Start initializing " + getClass().getSimpleName()); -- To view, visit http://gerrit.ovirt.org/13398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icce0924f3b7875752b4ff1df7b55d9e293da5cd6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: ofri masad <oma...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches