Laszlo Hornyak has posted comments on this change.
Change subject: core: removing org.apache.commons.lang dependency (5/15)
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
Line 420: found = true;
Line 421: } else {
Line 422: for (final VdsNetworkInterface vdsIf :
allInterfacesForVds) {
Line 423: if (!networkRequiredOnVds(vmIf, networksByName,
onlyRequiredNetworks)
Line 424: || (vmIf.getNetworkName() ==
vdsIf.getNetworkName()
why do you want to have a string == string comparison here?
Line 425: || (vmIf.getNetworkName() == null
&& vdsIf.getNetworkName() == null)
Line 426: || (vmIf.getNetworkName() != null
&& vmIf.getNetworkName()
Line 427:
.equals(vdsIf.getNetworkName())))) {
Line 428: found = true;
....................................................
Commit Message
Line 6:
Line 7: core: removing org.apache.commons.lang dependency (5/15)
Line 8:
Line 9: motivation: VdsSelector will move to sla package, hence
Line 10: removing !must dependencies.
why not just move the dependency as well?
Line 11: using native code for StringUtils.equals
Line 12:
Line 13: Change-Id: If5ae48b1cc36f466e43fec1e8f66aa96e6f5fb5f
--
To view, visit http://gerrit.ovirt.org/13115
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ae48b1cc36f466e43fec1e8f66aa96e6f5fb5f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
