[Engine-patches] Change in ovirt-engine[master]: packaging: less intrusive method for httpd integration

2013-04-07 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: less intrusive method for httpd integration .. Patch Set 20: Anyone, is there any comment? I would like this to be merged. Thanks! -- To view, visit

[Engine-patches] Change in ovirt-engine[master]: engine : ovirt-node enter installing status when the install...

2013-04-07 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine : ovirt-node enter installing status when the install fails .. Patch Set 5: (2 inline comments) Fil

[Engine-patches] Change in ovirt-engine[master]: userportal: UnitVmModel - subscribe GetHostsByClusterId

2013-04-07 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: userportal: UnitVmModel - subscribe GetHostsByClusterId .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13676 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: restapi : don't set jsessionid cookie when authentication fa...

2013-04-07 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: restapi : don't set jsessionid cookie when authentication fails(#927140) .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: Remove LdapSeachGroupsByQuery.initFromDb

2013-04-07 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: Remove LdapSeachGroupsByQuery.initFromDb .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13649 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: major cleanup

2013-04-07 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: major cleanup .. packaging: engine-service: major cleanup Last patch in series of engine-service, after all core issues merg

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: major cleanup

2013-04-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: engine-service: major cleanup .. Patch Set 4: Verified; Looks good to me, approved Merging based on previous ack and verification. -- To view, visit

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: fix systemd packaging per fedora ...

2013-04-07 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: fix systemd packaging per fedora requirements .. packaging: engine-service: fix systemd packaging per fedora requirements C

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: fix systemd packaging per fedora ...

2013-04-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: engine-service: fix systemd packaging per fedora requirements .. Patch Set 2: Verified; Looks good to me, approved Merging based on previous ack and

[Engine-patches] Change in ovirt-engine[master]: core: Remove not used powerDownVDSCommand.

2013-04-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: Remove not used powerDownVDSCommand. .. Patch Set 7: Just asked if we can remove ShutdownVdsCommand as well. -- To view, visit http://gerrit.ovirt.org/13514

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: move service to backend subpackag...

2013-04-07 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: move service to backend subpackage .. packaging: engine-service: move service to backend subpackage Change-Id: I3df9c0f0d221

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: move service to backend subpackag...

2013-04-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: engine-service: move service to backend subpackage .. Patch Set 2: Verified; Looks good to me, approved Merging based on previous ack and verificatio

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: remove unused tmpfiles config

2013-04-07 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: remove unused tmpfiles config .. packaging: engine-service: remove unused tmpfiles config Change-Id: I81175c21f018be180157ff

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: remove unused tmpfiles config

2013-04-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: engine-service: remove unused tmpfiles config .. Patch Set 2: Verified; Looks good to me, approved Merging based on previous ack and verification. -

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: do not clean environment

2013-04-07 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: do not clean environment .. packaging: engine-service: do not clean environment the init system may put important variables

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: do not clean environment

2013-04-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: engine-service: do not clean environment .. Patch Set 2: Verified; Looks good to me, approved Merging based on previous ack and verification. -- To

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: do not clean environment

2013-04-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: engine-service: do not clean environment .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13643 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: major cleanup

2013-04-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: engine-service: major cleanup .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13628 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix VM pop-up Host tab

2013-04-07 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Fix VM pop-up Host tab .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13546 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix VM pop-up Host tab

2013-04-07 Thread omasad
ofri masad has posted comments on this change. Change subject: webadmin: Fix VM pop-up Host tab .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/13546 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

[Engine-patches] Change in ovirt-engine[master]: core:restore.sh fails to drop existing database...

2013-04-07 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core:restore.sh fails to drop existing database... .. core:restore.sh fails to drop existing database... restore.sh fails to drop existing database and

[Engine-patches] Change in ovirt-engine[master]: core:restore.sh fails to drop existing database...

2013-04-07 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core:restore.sh fails to drop existing database... .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13498 To unsub

[Engine-patches] Change in ovirt-engine[master]: core:restore.sh fails to drop existing database...

2013-04-07 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core:restore.sh fails to drop existing database... .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13498 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: core: Remove not used powerDownVDSCommand.

2013-04-07 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove not used powerDownVDSCommand. .. Patch Set 7: @Daniel - gerrit has an annoying bug about displaying comments on deleted files. We can't see your co

[Engine-patches] Change in ovirt-engine[master]: core: Fix charge double quota for move disk

2013-04-07 Thread omasad
ofri masad has posted comments on this change. Change subject: core: Fix charge double quota for move disk .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/13559 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine-cli[master]: cli: connect --help will log the user out of the disconnecte...

2013-04-07 Thread rnori
Ravi Nori has posted comments on this change. Change subject: cli: connect --help will log the user out of the disconnected cli .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/13494 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: Remove GetEventSubscribersBySubscriberId

2013-04-07 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: Remove GetEventSubscribersBySubscriberId .. Patch Set 1: never mind - seems only the parameters class is shared, but its another query (the Grouped one) --

[Engine-patches] Change in ovirt-engine[master]: core: Remove GetEventSubscribersBySubscriberId

2013-04-07 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: Remove GetEventSubscribersBySubscriberId .. Patch Set 1: how can this not break: frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uico

[Engine-patches] Change in ovirt-engine[master]: core: fix overriding placeholder val in audit log

2013-04-07 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: fix overriding placeholder val in audit log .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13691 To

[Engine-patches] Change in ovirt-engine[master]: core: fix overriding placeholder val in audit log

2013-04-07 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: fix overriding placeholder val in audit log .. Patch Set 1: Verified verified now the problematic placeholder is populated -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: fix overriding placeholder val in audit log

2013-04-07 Thread abonas
Alissa Bonas has uploaded a new change for review. Change subject: core: fix overriding placeholder val in audit log .. core: fix overriding placeholder val in audit log Fix overriding placeholder value set in AugitLogableBase.c

[Engine-patches] Change in otopi[master]: core: use single function for early debug

2013-04-07 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: core: use single function for early debug .. core: use single function for early debug Change-Id: I246b1602fa51bb005925b0dca0dc505849bc221f Signed-off-by

[Engine-patches] Change in otopi[master]: core: use single function for early debug

2013-04-07 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: use single function for early debug .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13690 To unsubscribe, vis

[Engine-patches] Change in otopi[master]: core: support more complex sequence relationships

2013-04-07 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: support more complex sequence relationships .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13689 To unsubscr

[Engine-patches] Change in otopi[master]: core: support more complex sequence relationships

2013-04-07 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: core: support more complex sequence relationships .. core: support more complex sequence relationships perform before/after multiple times to allow list

[Engine-patches] Change in otopi[master]: core: support more complex sequence relationships

2013-04-07 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: core: support more complex sequence relationships .. core: support more complex sequence relationships perform before/after multiple times to allow list to be sy

[Engine-patches] Change in otopi[master]: core: use single function for early debug

2013-04-07 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: core: use single function for early debug .. core: use single function for early debug Change-Id: I246b1602fa51bb005925b0dca0dc505849bc221f Signed-off-by: Alon B

[Engine-patches] Change in otopi[master]: doc: ChangeLog: fix spelling

2013-04-07 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: doc: ChangeLog: fix spelling .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13688 To unsubscribe, visit http://ger

[Engine-patches] Change in otopi[master]: doc: ChangeLog: fix spelling

2013-04-07 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: ChangeLog: fix spelling .. doc: ChangeLog: fix spelling Change-Id: Ib98caa8fc026c47199dfbdfe6b304005a319f074 Signed-off-by: Alon Bar-Lev --- M Chan

[Engine-patches] Change in otopi[master]: doc: ChangeLog: fix spelling

2013-04-07 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: doc: ChangeLog: fix spelling .. doc: ChangeLog: fix spelling Change-Id: Ib98caa8fc026c47199dfbdfe6b304005a319f074 Signed-off-by: Alon Bar-Lev --- M ChangeLog 1

[Engine-patches] Change in otopi[otopi-1.0]: doc: ChangeLog: fix spelling

2013-04-07 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: ChangeLog: fix spelling .. doc: ChangeLog: fix spelling Change-Id: Ia5f17b396e329771e7f4c38a9b1b86084a7b1c2a Signed-off-by: Alon Bar-Lev --- M Chan

[Engine-patches] Change in otopi[otopi-1.0]: doc: ChangeLog: fix spelling

2013-04-07 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: doc: ChangeLog: fix spelling .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13687 To unsubscribe, visit http://ger

[Engine-patches] Change in otopi[otopi-1.0]: doc: ChangeLog: fix spelling

2013-04-07 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: doc: ChangeLog: fix spelling .. doc: ChangeLog: fix spelling Change-Id: Ia5f17b396e329771e7f4c38a9b1b86084a7b1c2a Signed-off-by: Alon Bar-Lev --- M ChangeLog 1

[Engine-patches] Change in ovirt-engine[master]: webadmin: Guard against premature CommonModel nullification

2013-04-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Guard against premature CommonModel nullification .. Patch Set 2: Looks good to me, approved (1 inline comment)

[Engine-patches] Change in ovirt-engine[master]: core: Remove not used powerDownVDSCommand.

2013-04-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: Remove not used powerDownVDSCommand. .. Patch Set 7: Looks good to me, but someone else must approve (1 inline comment)

[Engine-patches] Change in ovirt-engine[master]: core: Remove unused command VmPoolToAdGroupBaseCommand

2013-04-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: Remove unused command VmPoolToAdGroupBaseCommand .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13

[Engine-patches] Change in ovirt-engine[master]: userportal: UnitVmModel - subscribe GetHostsByClusterId

2013-04-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal: UnitVmModel - subscribe GetHostsByClusterId .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/13676 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: webadmin: NewEditStorageModelBehavior refactor

2013-04-07 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: webadmin: NewEditStorageModelBehavior refactor .. webadmin: NewEditStorageModelBehavior refactor - Refactor items availability logic in NewEditStorageModelBehavio

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3898 - Fixed!

2013-04-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3898/ Build Number: 3898 Build Status: Fixed Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 3906 - Fixed!

2013-04-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/3906/ Build Number: 3906 Build Status: Fixed Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 3749 - Fixed!

2013-04-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/ Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3749/ Build Number: 3749 Build Status: Fixed Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: core: clean RemoveStorageDomainCommand

2013-04-07 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: clean RemoveStorageDomainCommand .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13683 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix VM pop-up Host tab

2013-04-07 Thread omasad
ofri masad has posted comments on this change. Change subject: webadmin: Fix VM pop-up Host tab .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/13546 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

[Engine-patches] Change in ovirt-engine[master]: core: fix build error

2013-04-07 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: core: fix build error .. core: fix build error Change-Id: I669480a591095e84ebdb0b4624424bd3ba177ac6 Bug-Url: http://bugzilla.redhat.com/922490 Signed-off-by

[Engine-patches] Change in ovirt-engine[master]: core: fix build error

2013-04-07 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: fix build error .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13684 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: fix build error

2013-04-07 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: fix build error .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13684 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: core: fix build error

2013-04-07 Thread rgolan
Roy Golan has uploaded a new change for review. Change subject: core: fix build error .. core: fix build error Change-Id: I669480a591095e84ebdb0b4624424bd3ba177ac6 Bug-Url: http://bugzilla.redhat.com/922490 Signed-off-by: Roy Go

[Engine-patches] Change in ovirt-engine[master]: core: clean RemoveStorageDomainCommand

2013-04-07 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: clean RemoveStorageDomainCommand .. Patch Set 1: Verified compilation + unitests pass -- To view, visit http://gerrit.ovirt.org/13683 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: clean RemoveStorageDomainCommand

2013-04-07 Thread abonas
Alissa Bonas has uploaded a new change for review. Change subject: core: clean RemoveStorageDomainCommand .. core: clean RemoveStorageDomainCommand Renamed connect/disconnect methods to start with lowercase (java convention) and

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 3748 - Failure!

2013-04-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/ Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3748/ Build Number: 3748 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3897 - Failure!

2013-04-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3897/ Build Number: 3897 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user - Build # 3727 - Failure!

2013-04-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/3727/ Build Number: 3727 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 3905 - Failure!

2013-04-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/3905/ Build Number: 3905 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms - Build # 769 - Failure!

2013-04-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/769/ Build Number: 769 Build Status: Failure Triggered By: Started by an SCM change, Started by an SCM change - Changes Since Last Succ

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 3904 - Fixed!

2013-04-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/3904/ Build Number: 3904 Build Status: Fixed Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3896 - Fixed!

2013-04-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3896/ Build Number: 3896 Build Status: Fixed Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: core: monitoring - don't handle devices for MigratingTo VMs

2013-04-07 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: core: monitoring - don't handle devices for MigratingTo VMs .. core: monitoring - don't handle devices for MigratingTo VMs There is no point of trying to up

[Engine-patches] Change in ovirt-engine[master]: core: monitoring - don't handle devices for MigratingTo VMs

2013-04-07 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: monitoring - don't handle devices for MigratingTo VMs .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13352 To u

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 3747 - Fixed!

2013-04-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/ Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3747/ Build Number: 3747 Build Status: Fixed Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: engine: Compare and set instead of updateVdsDynamic in VM sc...

2013-04-07 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Compare and set instead of updateVdsDynamic in VM scenarious .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/13682 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: engine: Compare and set instead of updateVdsDynamic in VM sc...

2013-04-07 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: engine: Compare and set instead of updateVdsDynamic in VM scenarious .. engine: Compare and set instead of updateVdsDynamic in VM scenarious The following pat

[Engine-patches] Change in ovirt-engine[master]: webadmin: Display correct error when adding new storage

2013-04-07 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: webadmin: Display correct error when adding new storage .. webadmin: Display correct error when adding new storage When adding a new Storage Domain (of NFS/Local ty

[Engine-patches] Change in ovirt-engine[master]: restapi: Removed unused import that broke the build

2013-04-07 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Removed unused import that broke the build .. restapi: Removed unused import that broke the build Not sure how it got there... Change-Id:

[Engine-patches] Change in ovirt-engine[master]: restapi: Removed unused import that broke the build

2013-04-07 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: Removed unused import that broke the build .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13680 To u

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 3903 - Failure!

2013-04-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/3903/ Build Number: 3903 Build Status: Failure Triggered By: Started by an SCM change, Started by an SCM change - Changes Since Last Succes

[Engine-patches] Change in ovirt-engine[master]: restapi: Removed unused import that broke the build

2013-04-07 Thread lvernia
Lior Vernia has posted comments on this change. Change subject: restapi: Removed unused import that broke the build .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/13680 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: restapi: Removed unused import that broke the build

2013-04-07 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: Removed unused import that broke the build .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13680 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: restapi: Removed unused import that broke the build

2013-04-07 Thread lvernia
Lior Vernia has posted comments on this change. Change subject: restapi: Removed unused import that broke the build .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/13680 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: restapi: Removed unused import that broke the build

2013-04-07 Thread lvernia
Lior Vernia has uploaded a new change for review. Change subject: restapi: Removed unused import that broke the build .. restapi: Removed unused import that broke the build Not sure how it got there... Change-Id: I71d6c34cdf29a

[Engine-patches] Change in ovirt-engine[master]: webadmin: Console connect button availability fix

2013-04-07 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: webadmin: Console connect button availability fix .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/13343 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3895 - Failure!

2013-04-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3895/ Build Number: 3895 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 3746 - Failure!

2013-04-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/ Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3746/ Build Number: 3746 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user - Build # 3725 - Failure!

2013-04-07 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/3725/ Build Number: 3725 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: restapi: Added mapping to derived classes of VdsNetworkInter...

2013-04-07 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Added mapping to derived classes of VdsNetworkInterface .. restapi: Added mapping to derived classes of VdsNetworkInterface The mapping now

[Engine-patches] Change in ovirt-engine[master]: restapi: Added mapping to derived classes of VdsNetworkInter...

2013-04-07 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: Added mapping to derived classes of VdsNetworkInterface .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: webadmin: Changed bond list models to hold String

2013-04-07 Thread lvernia
Lior Vernia has posted comments on this change. Change subject: webadmin: Changed bond list models to hold String .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/13679 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: webadmin: Created class hierarchy for bond popups

2013-04-07 Thread lvernia
Lior Vernia has posted comments on this change. Change subject: webadmin: Created class hierarchy for bond popups .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/13678 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: Added validation for bond name format

2013-04-07 Thread lvernia
Lior Vernia has posted comments on this change. Change subject: core: Added validation for bond name format .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/13480 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: Added validation for host NIC name length

2013-04-07 Thread lvernia
Lior Vernia has posted comments on this change. Change subject: core: Added validation for host NIC name length .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/13479 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: restapi: Added mapping to derived classes of VdsNetworkInter...

2013-04-07 Thread lvernia
Lior Vernia has posted comments on this change. Change subject: restapi: Added mapping to derived classes of VdsNetworkInterface .. Patch Set 2: Verified Rebased, and moved it to the back of the dependency list. Michael, feel f

[Engine-patches] Change in ovirt-engine[master]: webadmin: Created class hierarchy for bond popups

2013-04-07 Thread lvernia
Lior Vernia has uploaded a new change for review. Change subject: webadmin: Created class hierarchy for bond popups .. webadmin: Created class hierarchy for bond popups Created a class hierarchy for bond popup windows to replace

[Engine-patches] Change in ovirt-engine[master]: webadmin: Changed bond list models to hold String

2013-04-07 Thread lvernia
Lior Vernia has uploaded a new change for review. Change subject: webadmin: Changed bond list models to hold String .. webadmin: Changed bond list models to hold String The models all used to hold VdsNetworkInterface entities, b

[Engine-patches] Change in ovirt-engine[master]: core: AddVmCommand - add all SDs to permList

2013-04-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: AddVmCommand - add all SDs to permList .. Patch Set 1: (1 inline comment) File backend/manager/modules/

[Engine-patches] Change in ovirt-engine[master]: core: AddVmCommand - add all SDs to permList

2013-04-07 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: AddVmCommand - add all SDs to permList .. Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) ...

[Engine-patches] Change in ovirt-engine[master]: core: Remove StringHelper usages in types module

2013-04-07 Thread amureini
Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove StringHelper usages in types module .. core: Remove StringHelper usages in types module Removed all the usages of the deprecated StringHel

[Engine-patches] Change in ovirt-engine[master]: core: Remove StringHelper usages in types module

2013-04-07 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove StringHelper usages in types module .. Patch Set 2: Verified; Looks good to me, approved Rebased, no code changes. Merged based on Michael Pasterna

[Engine-patches] Change in ovirt-engine[master]: core: Remove StringHelper usages in jaxrs module

2013-04-07 Thread amureini
Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove StringHelper usages in jaxrs module .. core: Remove StringHelper usages in jaxrs module Removed all the usages of the deprecated StringHel

[Engine-patches] Change in ovirt-engine[master]: core: Remove StringHelper usages in jaxrs module

2013-04-07 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove StringHelper usages in jaxrs module .. Patch Set 2: Verified; Looks good to me, approved Rebased, no code changes. Merged based on Michael Pasterna

[Engine-patches] Change in ovirt-engine[master]: restapi: Use DbUser.isGroup() properly

2013-04-07 Thread amureini
Allon Mureinik has submitted this change and it was merged. Change subject: restapi: Use DbUser.isGroup() properly .. restapi: Use DbUser.isGroup() properly Replaced an explicit string check on DbUser's user name with the BE's

[Engine-patches] Change in ovirt-engine[master]: restapi: Use DbUser.isGroup() properly

2013-04-07 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: restapi: Use DbUser.isGroup() properly .. Patch Set 2: Verified; Looks good to me, approved Rebased, no code changes. Merged based on Michael Pasternak's +2. -

  1   2   3   >