Michael Kublin has posted comments on this change.
Change subject: engine : ovirt-node enter installing status when the install
fails
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
Line 33: @NonTransactiveCommandAttribute(forceCompensation = true)
Line 34: public class UpdateVdsCommand<T extends UpdateVdsActionParameters>
extends VdsCommand<T> implements RenamedEntityInfoProvider{
Line 35:
Line 36: private VDS _oldVds;
Line 37: private static final List<String> UPDATE_FIELDS_VDS_BROKER =
Arrays.asList("host_name", "ip", "vds_unique_id", "port", "vds_group_id");
can u please add constructor protected UpdateVdsCommand(Guid commandId) {}
with out this constructor a compensation will not work after restart, this is
not directly related to your patch, but if your already here...
Line 38:
Line 39: public UpdateVdsCommand(T parameters) {
Line 40: super(parameters);
Line 41: }
Line 199: getCompensationContext().stateChanged();
Line 200: return null;
Line 201: }
Line 202: });
Line 203:
The status of host is changed here, so I think that create compensation context
is better here, also it is better to use
getCompensationContext().snapshotEntityStatus()
Line 204: if (getParameters().getInstallVds()) {
Line 205: runVdsCommand(VDSCommandType.SetVdsStatus,
Line 206: new SetVdsStatusVDSCommandParameters(getVdsId(),
VDSStatus.Installing));
Line 207: }
--
To view, visit http://gerrit.ovirt.org/13622
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d74e946cb68d2b9dbc11fc5c6bed9f63ba35fe2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
