Allon Mureinik has posted comments on this change.
Change subject: core: AddVmCommand - add all SDs to permList
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 712: if (getVmTemplate() != null &&
!getVmTemplate().getDiskList().isEmpty()) {
Line 713: for (DiskImage disk :
getParameters().getDiskInfoDestinationMap().values()) {
Line 714: addStoragePermissionByQuotaMode(permissionList,
Line 715: GuidUtils.getGuidValue(getStoragePoolId()),
Line 716:
GuidUtils.getGuidValue(disk.getStorageIds().get(0)));
why only the 1st one?
Line 717: }
Line 718: }
Line 719: addPermissionSubjectForAdminLevelProperties(permissionList);
Line 720: return permissionList;
--
To view, visit http://gerrit.ovirt.org/13669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b942af8b5093848922f060c6be44e8a69374634
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
