Alon Bar-Lev has posted comments on this change.
Change subject: core: Compatibility of db scripts with MacOS.
..
Patch Set 2: (1 inline comment)
Although I agree that shell script should be indent using tabs... there is no
re
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: reimplemented engine_firewalld
..
Patch Set 1:
I thought that[1] fixed it. But I guess there is more the API does not handle.
I am fine with dropping
Alon Bar-Lev has posted comments on this change.
Change subject: tools: engine-setup - Fixed memory requirements
..
Patch Set 1: Looks good to me, but someone else must approve
I am not sure this worth for z stream.
--
To view
Alon Bar-Lev has posted comments on this change.
Change subject: tools: engine-setup - fixed installation messages
..
Patch Set 2:
Besides:
I am not sure that display the example files for all services (iptables,
firewalld) is
Alon Bar-Lev has posted comments on this change.
Change subject: tools: engine-setup - fixed installation messages
..
Patch Set 2:
I don't think this should go into z of 3.2
--
To view, visit http://gerrit.ovirt.org/13321
To u
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Added generic checking DB state before upgrade
..
Patch Set 8: (2 inline comments)
File packaging/
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: reimplemented engine_firewalld
..
Patch Set 1:
Any reason why we need it at 3.2?
--
To view, visit http://gerrit.ovirt.org/13609
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: refactored firewalld support
..
Patch Set 1: (2 inline comments)
File packaging/fedora/setup/http.
Alon Bar-Lev has abandoned this change.
Change subject: packaging: engine-service: fixup systemd packaging
..
Patch Set 1: Abandoned
Split into two other
--
To view, visit http://gerrit.ovirt.org/13644
To unsubscribe, visit ht
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: major cleanup
..
Patch Set 3: Verified
Rebase minor fixups.
--
To view, visit http://gerrit.ovirt.org/13628
To unsubscribe, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: fix systemd packaging per fedora
requirements
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13647
To unsubscribe,
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: move service to backend subpackage
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13646
To unsubscribe, visit http:
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: remove unused tmpfiles config
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13645
To unsubscribe, visit http://ger
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: fix systemd packaging per fedora
requirements
..
packaging: engine-service: fix systemd packaging per fedora requirements
Change-Id:
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: move service to backend subpackage
..
packaging: engine-service: move service to backend subpackage
Change-Id: I3df9c0f0d221d883c7a49b
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: remove unused tmpfiles config
..
packaging: engine-service: remove unused tmpfiles config
Change-Id: I81175c21f018be180157ffcaadef1dd2
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: major cleanup
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13628
To unsubscribe, visit http://gerrit.ovirt.org/se
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: fixup systemd packaging
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13644
To unsubscribe, visit http://gerrit.ov
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: do not clean environment
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13643
To unsubscribe, visit http://gerrit.o
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: do not clean environment
..
packaging: engine-service: do not clean environment
the init system may put important variables in environ
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: fixup systemd packaging
..
packaging: engine-service: fixup systemd packaging
Change-Id: Iad20fb41030644f32673922e85234b540b68f14f
Sig
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: major cleanup
..
Patch Set 1: (1 inline comment)
File packaging/fedora/engine-serv
Alissa Bonas has posted comments on this change.
Change subject: webadmin,core: WIP edit Posix storage connection
..
Patch Set 1: Fails
fails on vdsm side due to known issue with posix connect.
--
To view, visit http://gerrit.
Alissa Bonas has uploaded a new change for review.
Change subject: webadmin,core: WIP edit Posix storage connection
..
webadmin,core: WIP edit Posix storage connection
please don't review yet
Change-Id: I8904ffab80e9d6e6bfdee4b
Martin Beták has posted comments on this change.
Change subject: restapi: Apply template on VmPool creation using REST API
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13639
To unsubscribe, visit http://ge
Martin Beták has uploaded a new change for review.
Change subject: restapi: Apply template on VmPool creation using REST API
..
restapi: Apply template on VmPool creation using REST API
The BackendVmPoolsResource.mapToVM method
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: refactored firewalld support
..
Patch Set 1: Verified
Verified in a f18 VM, without enabling AIO. Appreciate any review and testing.
--
To view, v
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: refactored firewalld support
..
Patch Set 1:
Just verified that the package build. Needs more testing.
--
To view, visit http://gerrit.ovirt.org/1
Sandro Bonazzola has uploaded a new change for review.
Change subject: packaging: refactored firewalld support
..
packaging: refactored firewalld support
Added one service configuration template file for each service
that should
Ravi Nori has posted comments on this change.
Change subject: restapi : don't set jsessionid cookie when authentication
fails(#927140)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13371
To unsubscribe, vi
Tomas Jelinek has posted comments on this change.
Change subject: engine,webadmin: Run and pause action enabled
..
Patch Set 2: (2 inline comments)
If I understand correctly, the isRunAndPauseEditor is visible in new/edit pool,
Ravi Nori has posted comments on this change.
Change subject: engine : ovirt-node enter installing status when the install
fails
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/13622
To unsubscribe, visit ht
Ravi Nori has posted comments on this change.
Change subject: restapi: ProductInfo use ProductRPMVersion
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
...
Ravi Nori has posted comments on this change.
Change subject: restapi: ProductInfo use ProductRPMVersion
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/rest
Daniel Erez has submitted this change and it was merged.
Change subject: userportal, webadmin: i18n refresh 'sec'
..
userportal, webadmin: i18n refresh 'sec'
- Fixed 'sec' not being i18ned on the refresh panel
drop down.
- Rena
Daniel Erez has posted comments on this change.
Change subject: userportal, webadmin: i18n refresh 'sec'
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13525
To unsubscribe, visit
Einav Cohen has submitted this change and it was merged.
Change subject: core: provided cleared frontend logging
..
core: provided cleared frontend logging
- Added code to display better debug messages for
-- RunQuery
-- RunPub
Einav Cohen has posted comments on this change.
Change subject: core: provided cleared frontend logging
..
Patch Set 7: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/12559
To unsubscrib
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Move scheduler to modules
..
core: Move scheduler to modules
The scheduler component used to be into a "beans" folder, but it is not
different fr
Juan Hernandez has posted comments on this change.
Change subject: core: Move scheduler to modules
..
Patch Set 3: Verified; Looks good to me, approved
Merging based on previous approval.
--
To view, visit http://gerrit.ovirt.
Deepak C Shetty has posted comments on this change.
Change subject: core: WIP: Add support for backup/restore API for ISVs
..
Patch Set 1: (2 inline comments)
my 2 cents :)
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: build: support subst more than once in line
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: build: support subst more than once in line
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13630
To unsubscribe, visit http://gerri
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: build: support subst more than once in line
..
packaging: build: support subst more than once in line
Change-Id: Ie91ea6bb2765825c022ba699ddf1d7660298
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: major cleanup
..
Patch Set 1: (1 inline comment)
File packaging/fedora/engine-serv
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: major cleanup
..
Patch Set 1: (1 inline comment)
File packaging/fedora/engine-
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: major cleanup
..
Patch Set 1: (1 inline comment)
File packaging/fedora/engine-serv
Shireesh Anjal has submitted this change and it was merged.
Change subject: restapi: Refactored BackendGlusterBrickResource
..
restapi: Refactored BackendGlusterBrickResource
Refactored BackendGlusterBrickResource to use parent
Shireesh Anjal has posted comments on this change.
Change subject: restapi: Refactored BackendGlusterBrickResource
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13120
To unsubscr
Vinzenz Feenstra has posted comments on this change.
Change subject: agent: Ignore usbfs filesystems'
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13629
To
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup plugins should not be executable
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Vinzenz Feenstra has uploaded a new change for review.
Change subject: agent: Ignore usbfs filesystems'
..
agent: Ignore usbfs filesystems'
Change-Id: Iee799b05f3c700e8e3912305e2984dad6e049f7d
Bug-Url: https://bugzilla.redhat.co
Frank Kobzik has posted comments on this change.
Change subject: webadmin: Console connect button availability fix
..
Patch Set 2: No score
--
To view, visit http://gerrit.ovirt.org/13343
To unsubscribe, visit http://gerrit.ovi
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-service: major cleanup
..
Patch Set 1: (1 inline comment)
File packaging/fedora/engine-se
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: major cleanup
..
Patch Set 1: (1 inline comment)
File packaging/fedora/engine-serv
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: major cleanup
..
Patch Set 1: (1 inline comment)
File packaging/fedora/engine-
56 matches
Mail list logo
