Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Added generic checking DB state before upgrade
......................................................................
Patch Set 8: (2 inline comments)
....................................................
File packaging/fedora/setup/dbvalidations.py
Line 107: '''
Line 108: # Check that db is not clean first
Line 109: if dbValidationFails():
Line 110: cmd = [
Line 111: basedefs.EXEC_FKVALIDATOR,
Again, this is not generic if it is written in setup.
We need to execute SINGLE script dba provide, this script can execute 1000000
different scripts to perform validation.
Bottom line: when a new validation is to be added, the setup should not be
changed. This is the meaning of being generic.
Line 112: "-u", SERVER_ADMIN,
Line 113: "-s", SERVER_NAME,
Line 114: "-p", SERVER_PORT,
Line 115: "-d", basedefs.DB_NAME,
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 562:
Line 563: # Python scripts:
Line 564: %{engine_data}/scripts/basedefs.py*
Line 565: %{engine_data}/scripts/engine_validators.py*
Line 566: %{engine_data}/scripts/dbvalidations.py
missing *
Line 567: %{engine_data}/scripts/engine_firewalld.py*
Line 568: %{engine_data}/scripts/setup_params.py*
Line 569: %{engine_data}/scripts/setup_sequences.py*
Line 570: %{engine_data}/scripts/setup_controller.py*
--
To view, visit http://gerrit.ovirt.org/12512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief0e65231bb42b569734cdd2fa6491b645491f98
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
