Alon Bar-Lev has posted comments on this change.
Change subject: core: Compatibility of db scripts with MacOS.
......................................................................
Patch Set 2: (1 inline comment)
Although I agree that shell script should be indent using tabs... there is no
reason to mix tabs/spaces indents...
Also, where are the functions? mkTempFile and md5calc?
....................................................
File backend/manager/dbscripts/dbfunctions.sh
Line 269: files=$(get_files "upgrade" 3)
Line 270: md5sum_file=.${DATABASE}.scripts.md5
Line 271: md5sum_tmp_file=${md5sum_file}.tmp
Line 272: md5sumResult=$(md5calc $files create_*views.sql *_sp.sql)
Line 273: echo $md5sumResult > ${md5sum_tmp_file}
md5calc $files create_*views.sql *_sp.sql > ${md5sum_tmp_file}
?
Line 274: diff -s -q ${md5sum_file} ${md5sum_tmp_file} >& /dev/null
Line 275: result=$?
Line 276:
Line 277: # 0 - identical , 1 - differ , 2 - error
--
To view, visit http://gerrit.ovirt.org/13233
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97df4a9c8ea0c2ca0fdf861932a97afb978e56c4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
