Yair Zaslavsky has posted comments on this change.
Change subject: webadmin: Wrong error message is shown, when SuperUser
permissions are removing from admin internal
..
Patch Set 1: Looks good to me, approved
--
To view, visi
ofri masad has posted comments on this change.
Change subject: core+webadmin: Fix aggregate unlimited quota
..
Patch Set 1: (3 inline comments)
File
backend/manager/modules/
Sandro Bonazzola has posted comments on this change.
Change subject: pki: cleanup configuration file format
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13501
To unsu
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
..
Patch Set 19: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Super audit log improvement
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13425
To unsubscribe, visit http://gerr
Alon Bar-Lev has uploaded a new change for review.
Change subject: pki: cleanup configuration file format
..
pki: cleanup configuration file format
optional patch to cleanup the configuration
files into something more consistent
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: use simplified template when handling
ovirt-engine-proxy.conf.in
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit
Gilad Chaplik has posted comments on this change.
Change subject: core: Fix unpermitted Move-Disk in Audit mode
..
Patch Set 1: (1 inline comment)
Commit Message
Line 5: Comm
Sandro Bonazzola has posted comments on this change.
Change subject: pki: cleanup: dos2unix
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13438
To unsubscribe, visit h
Sandro Bonazzola has posted comments on this change.
Change subject: pki: do not override ca database in packaging
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13440
Alon Bar-Lev has posted comments on this change.
Change subject: pki: cleanup: dos2unix
..
Patch Set 1: (1 inline comment)
File backend/manager/conf/ca/openssl.conf
Line 1: R
Sandro Bonazzola has posted comments on this change.
Change subject: pki: cleanup: use .keep convention
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13439
To unsubscr
Sandro Bonazzola has posted comments on this change.
Change subject: pki: cleanup: dos2unix
..
Patch Set 1: (1 inline comment)
File backend/manager/conf/ca/openssl.conf
Line
Oved Ourfali has posted comments on this change.
Change subject: core: Removed unused Roles queries
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13442
To unsubscribe,
Sandro Bonazzola has posted comments on this change.
Change subject: pki: remove unused files
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13437
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: remove limits.d file
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1349
Oved Ourfali has posted comments on this change.
Change subject: engine,webdmin: Restrict destination host parameter for
administrator roles
..
Patch Set 6: No score
(1 inline comment)
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: set default service mode to
foreground
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://ge
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: remove dead code
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13496
To
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Added colon and space after new password prompt in
engine-config
..
Patch Set 1:
Martin, commit message should include Bug-Url:
https://bugzilla.redhat
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: downstream infrastructure usage
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: error in custom properties sheet
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/module
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: remove limits.d file
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13495
To unsubscribe, visit http://gerrit.ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: remove limits.d file
..
Patch Set 1: (1 inline comment)
Commit Message
Line 7: pac
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: rework start pid file handling
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: add options for wrappers
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: use python daemon instead of own
implementation
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: allow service user customization
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: remove limits.d file
..
Patch Set 1: (1 inline comment)
Commit Message
Line 7:
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: recover from corrupted pid file
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Gilad Chaplik has posted comments on this change.
Change subject: core+webadmin: Fix aggregate unlimited quota
..
Patch Set 1: (3 inline comments)
File
backend/manager/modul
Mike Kolesnik has posted comments on this change.
Change subject: engine: adding "NetworkMigrationEnabled" to vdc_options.
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13369
To unsubscrib
Daniel Erez has posted comments on this change.
Change subject: frontend: reduce duplicate code related to run-once capability
..
Patch Set 9: (2 inline comments)
File
front
Vered Volansky has posted comments on this change.
Change subject: core: Extract SD validations from ImagesHandler
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12249
Mark Wu has posted comments on this change.
Change subject: core: Allow creating ISO domain on other file-based storages
except nfs
..
Patch Set 5:
@Einav, I get it now. Many thanks for your explanation. I didn't know Zanata
Asaf Shakarchi has posted comments on this change.
Change subject: WIP: working CDI solution for backend
..
Patch Set 4:
Adding myself into this:
This is good stuff, I personally would love to see DI/IOC inside backend (btw,
Eli Mesika has posted comments on this change.
Change subject: ensure restored engine db objects are owned by engine user
..
Patch Set 1: (4 inline comments)
File backend/man
Eli Mesika has posted comments on this change.
Change subject: gluster: Introducing GlusterFeatureSupported
..
Patch Set 1: (3 inline comments)
File
backend/manager/modules/
Eli Mesika has posted comments on this change.
Change subject: core:restore.sh fails to drop existing database...
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13498
To unsubscribe, visit http://gerrit.ovir
Eli Mesika has uploaded a new change for review.
Change subject: core:restore.sh fails to drop existing database...
..
core:restore.sh fails to drop existing database...
restore.sh fails to drop existing database and continues r
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: set default service mode to
foreground
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13497
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: remove dead code
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13496
To unsubscribe, visit http://gerrit.ovirt.org
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: downstream infrastructure usage
..
Patch Set 4: Verified
Tested using systemd, openrc, and sysv (on fedora).
Next patch removes dead c
Einav Cohen has posted comments on this change.
Change subject: core: provided cleared frontend logging
..
Patch Set 5:
>> Yair - patch is pending only on your re-review. thanks.
> Yair - still pending... thanks.
Yair?
--
To
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: rework start pid file handling
..
Patch Set 4: Verified
Under discussion I guess.
--
To view, visit http://gerrit.ovirt.org/13415
To u
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: add options for wrappers
..
Patch Set 3: Verified
Added: in foreground do not redirect stdout/stderr, this is good for systemd,
openrc
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: use python daemon instead of own
implementation
..
Patch Set 2: Verified
Rebase
--
To view, visit http://gerrit.ovirt.org/13435
To un
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: allow service user customization
..
Patch Set 3:
Rebased.
--
To view, visit http://gerrit.ovirt.org/13485
To unsubscribe, visit http:/
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: Application continue polling after logout
..
webadmin: Application continue polling after logout
- Fixed queries to BookMarks not stopping when
Einav Cohen has posted comments on this change.
Change subject: webadmin: Application continue polling after logout
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10895
To unsubs
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: allow service user customization
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/13485
To unsubscribe, visit http://
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: remove limits.d file
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13495
To unsubscribe, visit http://gerrit.ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: recover from corrupted pid file
..
Patch Set 3: Verified
Reordered, first in set, can be merged.
--
To view, visit http://gerrit.ovirt
Alon Bar-Lev has abandoned this change.
Change subject: packaging: engine-service: remove setrlimit nofile
..
Patch Set 1: Abandoned
Squashed into systemd patch.
--
To view, visit http://gerrit.ovirt.org/13484
To unsubscribe,
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: remove limits.d file
..
packaging: engine-service: remove limits.d file
the limits.d file is not used as service applies rlimit on its
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: remove dead code
..
packaging: engine-service: remove dead code
Change-Id: Id520a0ff33e797b2995fb217754605c219f6a922
Signed-off-by: Al
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: set default service mode to
foreground
..
packaging: engine-service: set default service mode to foreground
this will ease developer
Douglas Schilling Landgraf has posted comments on this change.
Change subject: restapi: ProductInfo use ProductRPMVersion
..
Patch Set 3: (1 inline comment)
File
backend/man
Einav Cohen has posted comments on this change.
Change subject: core: Allow creating ISO domain on other file-based storages
except nfs
..
Patch Set 5:
Hi Mark, translation for ovirt-engine text is managed via the Zanata syste
Ravi Nori has posted comments on this change.
Change subject: cli: connect --help will log the user out of the disconnected
cli
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13494
To unsubscribe, visit htt
Asaf Shakarchi has posted comments on this change.
Change subject: core: Compatibility of db scripts with MacOS.
..
Patch Set 2: (2 inline comments)
File backend/manager/dbsc
Ravi Nori has uploaded a new change for review.
Change subject: cli: connect --help will log the user out of the disconnected
cli
..
cli: connect --help will log the user out of the disconnected cli
Running connect --help in a
Ravi Nori has posted comments on this change.
Change subject: restapi : Add /applications sub-collection under vm(#926928)
..
Patch Set 4:
if applist is a, b vms/9c6e826b-2ee2-4c58-a834-38108acf356b/applications returns
Ravi Nori has posted comments on this change.
Change subject: restapi : Add /applications sub-collection under vm(#926928)
..
Patch Set 4: Verified
if applist is a, b vms/9c6e826b-2ee2-4c58-a834-38108acf356b/applications return
Ravi Nori has posted comments on this change.
Change subject: restapi : Add /applications sub-collection under vm(#926928)
..
Patch Set 3: Verified
if applist is a, b vms/9c6e826b-2ee2-4c58-a834-38108acf356b/applications return
Douglas Schilling Landgraf has abandoned this change.
Change subject: Makefile: target clean add $(TARBALL)
..
Patch Set 1: Abandoned
It won't happen.
--
To view, visit http://gerrit.ovirt.org/13487
To unsubscribe, visit http:
Daniel Erez has submitted this change and it was merged.
Change subject: userportal,webadmin: fix dtd check
..
userportal,webadmin: fix dtd check
In another patch we added set-property-fallback which is
not defined in the GWT d
Daniel Erez has posted comments on this change.
Change subject: userportal,webadmin: fix dtd check
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13492
To unsubscribe, visit http:
Ravi Nori has uploaded a new change for review.
Change subject: restapi : Add /applications sub-collection under vm(#926928)
..
restapi : Add /applications sub-collection under vm(#926928)
Add /applications sub-collection under
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: use simplified template when handling
ovirt-engine-proxy.conf.in
..
Patch Set 5: Verified
Please merge this unless some comments.
Thanks!
--
To view
Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: fix dtd check
..
Patch Set 1:
> It fixes the issue for me obviously otherwise I wouldn't have pushed the
> patch.
obviously :) just wanted D
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
..
Patch Set 19: Verified
It would nice if people actually test this... but I think this is good enough
fo
Alexander Wels has posted comments on this change.
Change subject: userportal,webadmin: fix dtd check
..
Patch Set 1:
It fixes the issue for me obviously otherwise I wouldn't have pushed the patch.
--
To view, visit http://ger
Alon Bar-Lev has posted comments on this change.
Change subject: Makefile: target clean add $(TARBALL)
..
Patch Set 1:
I usually follow the gnu guys of automake, unless there is a very good reason
per target behavior.
automak
Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: fix dtd check
..
Patch Set 1:
derez - any chance that you can verify that this patch indeed eliminates the
problem in eclipse?
--
To view, v
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Makefile: target clean add $(TARBALL)
..
Patch Set 1:
Hi Alon,
Thanks for clarification. I don't think it hurts to have removing .tar.gz
inside cl
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
..
Patch Set 18: (3 inline comments)
File packaging/fe
Alexander Wels has posted comments on this change.
Change subject: userportal,webadmin: fix dtd check
..
Patch Set 1: Verified
I did a full compile, and a quick smoke test of web admin and user portal and
could not find anythi
Juan Hernandez has posted comments on this change.
Change subject: userportal,webadmin: fix dtd check
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13492
To unsubscrib
Alexander Wels has uploaded a new change for review.
Change subject: userportal,webadmin: fix dtd check
..
userportal,webadmin: fix dtd check
In another patch we added set-property-fallback which is
not defined in the GWT dtd be
Shireesh Anjal has posted comments on this change.
Change subject: webadmin: Fix gluster host force detach message
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13335
Shireesh Anjal has posted comments on this change.
Change subject: engine: Unit test cases for create gluster volume command
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
Thanks for the initiative :)
One minor
Ravi Nori has posted comments on this change.
Change subject: engine : User can see events which don't belong to him
..
Patch Set 1:
I have verified for ovirt-3.2 and it had the same issue. So submitted a patch
for 3.2.
--
To
Ravi Nori has posted comments on this change.
Change subject: restapi: ProductInfo use ProductRPMVersion
..
Patch Set 3: (2 inline comments)
File
backend/manager/modules/res
Shireesh Anjal has uploaded a new change for review.
Change subject: gluster: Introducing GlusterFeatureSupported
..
gluster: Introducing GlusterFeatureSupported
This class provides methods to check compatibility of various glus
Shireesh Anjal has uploaded a new change for review.
Change subject: engine: Refactoring FeatureSupported
..
engine: Refactoring FeatureSupported
At present, FeatureSupported primarily contains a set of methods to
check if a giv
Alexander Wels has posted comments on this change.
Change subject: webadmin: Guard against premature CommonModel nullification
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Greg Padgett has posted comments on this change.
Change subject: engine: hashcode method simplification [wip]
..
Patch Set 2: Looks good to me, but someone else must approve
I like it. Allon, I looked into this and iirc common
Sahina Bose has posted comments on this change.
Change subject: webadmin: Fix gluster host force detach message
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13335
To
Sahina Bose has posted comments on this change.
Change subject: engine: Fix brick validation during create volume
..
Patch Set 1:
You could add a test with duplicate bricks in
CreateGlusterVolumeCommandTest.java
--
To view, v
Sahina Bose has posted comments on this change.
Change subject: engine: Unit test cases for create gluster volume command
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: remove setrlimit nofile
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/13484
To unsubscribe, visit http://gerrit.ov
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: remove setrlimit nofile
..
Patch Set 1:
OK... so we should remove this limits file. will do.
--
To view, visit http://gerrit.ovirt.org
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-service: remove setrlimit nofile
..
Patch Set 1:
The /etc/security/limits.d/whatever.conf files only affect programs that use
PAM to start se
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: remove setrlimit nofile
..
Patch Set 1:
> You checked it incorrectly
What do you mean? the /etc/security/limits.d/10-ovirt-engine.conf
Alon Bar-Lev has posted comments on this change.
Change subject: pki: do not override ca database in packaging
..
Patch Set 1:
There is a difference between component maintainer and commit access.
This is a core issue in ovirt
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-service: remove setrlimit nofile
..
Patch Set 1:
You checked it incorrectly, or maybe together with
http://gerrit.ovirt.org/13488 .
--
To vi
Alon Bar-Lev has abandoned this change.
Change subject: packaging: engine-service: remove %config from limits.d file
..
Patch Set 2: Abandoned
This file is to be removed as:
1. systemd can put rlimit on specific services.
2. o
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: remove %config from limits.d file
..
Patch Set 2:
program settings that can be overridden without overriding files should not be
overr
Juan Hernandez has posted comments on this change.
Change subject: pki: do not override ca database in packaging
..
Patch Set 1:
Then, in my humble opinion, you should request commit permissions and merge it
yourself.
--
To v
1 - 100 of 134 matches
Mail list logo
