Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: set default service mode to
foreground
......................................................................
packaging: engine-service: set default service mode to foreground
this will ease developer when executing the service.
Change-Id: Ib7e5ffe4e104d2c3a0c931f3f344f7c3c12eb57f
Signed-off-by: Alon Bar-Lev <alo...@redhat.com>
---
M packaging/fedora/engine-service.py.in
M packaging/fedora/engine-service.systemd.in
M packaging/fedora/engine-service.sysv.in
3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/97/13497/1
diff --git a/packaging/fedora/engine-service.py.in
b/packaging/fedora/engine-service.py.in
index bf2a7c4..3e3f2b2 100644
--- a/packaging/fedora/engine-service.py.in
+++ b/packaging/fedora/engine-service.py.in
@@ -627,11 +627,11 @@
help="pid file to use",
)
parser.add_option(
- "-f", "--foreground",
- dest="foreground",
+ "--background",
+ dest="background",
action="store_true",
default=False,
- help="Do not go into background",
+ help="Go into the background",
)
global options
(options, args) = parser.parse_args()
@@ -642,7 +642,7 @@
if options.pidfile is not None:
enginePidFile = options.pidfile
- foreground = options.foreground
+ foreground = not options.background
if foreground:
enginePidFile = None
engineConsoleLogFile = None
diff --git a/packaging/fedora/engine-service.systemd.in
b/packaging/fedora/engine-service.systemd.in
index fef2af5..fa96f58 100644
--- a/packaging/fedora/engine-service.systemd.in
+++ b/packaging/fedora/engine-service.systemd.in
@@ -7,7 +7,7 @@
User=@ENGINE_USER@
Group=@ENGINE_GROUP@
LimitNOFILE=65535
-ExecStart=/usr/bin/engine-service --foreground start
+ExecStart=/usr/bin/engine-service start
[Install]
WantedBy=multi-user.target
diff --git a/packaging/fedora/engine-service.sysv.in
b/packaging/fedora/engine-service.sysv.in
index 618c18a..57900e0 100755
--- a/packaging/fedora/engine-service.sysv.in
+++ b/packaging/fedora/engine-service.sysv.in
@@ -33,7 +33,7 @@
ulimit -n ${FILENO:-65535}
touch "${PIDFILE}"
chown "${USER}" "${PIDFILE}"
- daemon --user "${USER}" --pidfile="${PIDFILE}" /usr/bin/engine-service
--pidfile="${PIDFILE}" start
+ daemon --user "${USER}" --pidfile="${PIDFILE}" /usr/bin/engine-service
--pidfile="${PIDFILE}" --background start
RETVAL=$?
echo
if [ $RETVAL -eq 0 ]; then
--
To view, visit http://gerrit.ovirt.org/13497
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7e5ffe4e104d2c3a0c931f3f344f7c3c12eb57f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
