Oved Ourfali has posted comments on this change.
Change subject: engine,webdmin: Restrict destination host parameter for
administrator roles
......................................................................
Patch Set 6: No score
(1 inline comment)
....................................................
File backend/manager/dbscripts/upgrade/03_02_0510_add_edit_admin_vm_props.sql
Line 18: id,
Line 19: 205 -- EDIT_ADMIN_TEMPLATE_PROPERTIES
Line 20: from roles
Line 21: where
Line 22: name in ('SuperUser', 'ClusterAdmin', 'DataCenterAdmin',
'TemplateAdmin')
TemplateOwner is a user role, so it shouldn't be there.
Line 23: and not exists (
Line 24: select 1 from roles_groups rg
Line 25: where
Line 26: rg.role_id in (select id from roles where name in
('SuperUser', 'ClusterAdmin', 'DataCenterAdmin', 'TemplateAdmin')
--
To view, visit http://gerrit.ovirt.org/11303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5294854d24b235f2c50fa7f3d4e7472cf7598b53
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
