Shireesh Anjal has posted comments on this change.
Change subject: restapi: Refactored BackendGlusterBrickResource
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13120
Oved Ourfali has posted comments on this change.
Change subject: engine : User can see events which don't belong to him
..
Patch Set 3:
The new view you created is a direct view, which means it only returns direct
permissions.
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: removing deprecated AboutModel
..
webadmin: removing deprecated AboutModel
Removing deprecated AboutModel and all its references
(dead-code clea
Daniel Erez has posted comments on this change.
Change subject: webadmin: removing deprecated AboutModel
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13026
To unsubscribe, visit
Shireesh Anjal has posted comments on this change.
Change subject: gluster: added cluster level check
..
Patch Set 6: (2 inline comments)
Response to Yair's comments in-line. Regarding Omer's comments,
1. Config sql is not req
Laszlo Hornyak has posted comments on this change.
Change subject: engine: use autoclose to clean up vdsdeploy
..
Patch Set 1:
Alon, blocking the GC thread for up to 20 seconds will not save the engine from
the leak caused by
Sahina Bose has uploaded a new change for review.
Change subject: restapi: Refactored BackendGlusterBrickResource
..
restapi: Refactored BackendGlusterBrickResource
Refactored BackendGlusterBrickResource to use parent's
populate
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Adding port column to brick clients details
..
webadmin: Adding port column to brick clients details
'Port' column is added to the 'Clients' section of
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Fix brick advanced details close button
..
webadmin: Fix brick advanced details close button
Brick advanced details popup's close button was
not working
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Gluster Hooks sub tab in Cluster
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/11235
To unsubscribe, visit http://gerrit.ovirt.org/
Ravi Nori has posted comments on this change.
Change subject: core: rename FileTypeExtension to ImageType
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13067
To unsubs
Ravi Nori has posted comments on this change.
Change subject: core: unify the GetAllImagesList queries
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13066
To unsubscri
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/675/
Build Number: 675
Build Status: Still Failing
Triggered By: Started by an SCM change, Started by an SCM change
-
Changes Since Las
Tal Nisan has posted comments on this change.
Change subject: core: rename FileTypeExtension to ImageType
..
Patch Set 2:
Fede, you did also git grep on the project to see that there are no more
reference to change in non java
Alissa Bonas has posted comments on this change.
Change subject: core: Extract SD validations from ImagesHandler
..
Patch Set 6: (5 inline comments)
File
backend/manager/mod
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/674/
Build Number: 674
Build Status: Still Failing
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Fix host approval audit log message
..
core: Fix host approval audit log message
The event text should include the approving user.
Change-Id: I52378029b
Alissa Bonas has posted comments on this change.
Change subject: core: Unfilter ImagesHandler.PerformImagesChecks
..
Patch Set 6: (3 inline comments)
File
backend/manager/mo
Gilad Chaplik has posted comments on this change.
Change subject: core: Remove unused GetDisksForQuotaIdQuery
..
Patch Set 2:
I don't mind, let's see what Ofri thinks.
--
To view, visit http://gerrit.ovirt.org/13108
To unsubsc
Allon Mureinik has submitted this change and it was merged.
Change subject: core: import cleanup in VDSCommand parameters
..
core: import cleanup in VDSCommand parameters
Cleaned up the imports in the org.ovirt.engine.core.comm
Allon Mureinik has posted comments on this change.
Change subject: core: import cleanup in VDSCommand parameters
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Tal.
--
To view, visit http:
Gilad Chaplik has uploaded a new change for review.
Change subject: core: moving sla logic to sla package (6/X)
..
core: moving sla logic to sla package (6/X)
+ doing whats needed in oreder it to compile
Change-Id: I6fdc1c0809d
Gilad Chaplik has uploaded a new change for review.
Change subject: sla: initial module commit (4/X)
..
sla: initial module commit (4/X)
Adding sla module to the server modules
Change-Id: I634d2e44c09b730f4fb3598667ffa11adecea4
Gilad Chaplik has uploaded a new change for review.
Change subject: core: removing org.apache.commons.lang dependency (5/X)
..
core: removing org.apache.commons.lang dependency (5/X)
motivation: VdsSelector will move to sla pack
Gilad Chaplik has uploaded a new change for review.
Change subject: core: runVmCommandParams: remove get/setInternalExecution (3/X)
..
core: runVmCommandParams: remove get/setInternalExecution (3/X)
AuditLogableBase.isInternalEx
Gilad Chaplik has uploaded a new change for review.
Change subject: core: Move RunVm validation logic to RunVmCommand (1/X)
..
core: Move RunVm validation logic to RunVmCommand (1/X)
Curretly RunVm canDoAction logic is located b
Gilad Chaplik has uploaded a new change for review.
Change subject: core: clean-up RunVmCommand.CanDoAction (2/X)
..
core: clean-up RunVmCommand.CanDoAction (2/X)
better readability.
Change-Id: I87ce576fbf82ad5b1f677d3cef7113b4
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused GetDisksForQuotaIdQuery
..
Patch Set 2:
So why leave this floating in the codebase?
Why not remove it, and resubmit the patch to gerrit, so
Gilad Chaplik has posted comments on this change.
Change subject: core: Remove unused GetDisksForQuotaIdQuery
..
Patch Set 2:
@Allon, we first want to get a feedback on quota, then we will decide whether
to implement it/or not
Alissa Bonas has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
..
Patch Set 7: Verified
Added lock on old path to protect race between remove storage server connection
command and
Eli Mesika has posted comments on this change.
Change subject: core: Cannot confirm Host has been rebooted when..
..
Patch Set 1: (2 inline comments)
Allon asked
See inline some implementation considerations.
Also, according
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Stopped using backup.sh script for DB backup
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused GetDisksForQuotaIdQuery
..
Patch Set 2:
@Gilad - I think leaving dead code in the codebase is a bad practice. That
query has been there for
Allon Mureinik has posted comments on this change.
Change subject: core: Unfilter ImagesHandler.PerformImagesChecks
..
Patch Set 6: Verified
Fixed commit message as per Vered's comment, no code changes
--
To view, visit http:/
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add getMessage to VdcBLLException
..
core: Add getMessage to VdcBLLException
Adding getMessage method to VdcBLLException, to provide better
informa
Maor Lipchuk has posted comments on this change.
Change subject: core: Add getMessage to VdcBLLException
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13099
To unsubscribe, visit http://gerrit.ovirt.org/set
Daniel Erez has posted comments on this change.
Change subject: core: Add getMessage to VdcBLLException
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13099
To unsubscribe, visit http://ger
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use one line error log instead stack trace.
..
core: Use one line error log instead stack trace.
Instead logging all the stack trace when failing t
Maor Lipchuk has posted comments on this change.
Change subject: core: Use one line error log instead stack trace.
..
Patch Set 6: Verified; Looks good to me, approved
Acked by mkublin
--
To view, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core: Unfilter ImagesHandler.PerformImagesChecks
..
Patch Set 5: (3 inline comments)
File
backend/manager/
Eli Mesika has submitted this change and it was merged.
Change subject: core:remove storage pool is failing in Psql exception...
..
core:remove storage pool is failing in Psql exception...
ovirt-engine: remove storage pool is f
Eli Mesika has posted comments on this change.
Change subject: core:remove storage pool is failing in Psql exception...
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13110
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: core:remove storage pool is failing in Psql exception...
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13110
To
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: use conf.d notation for setup settings
..
Patch Set 5:
Juan, any more insights?
--
To view, visit http://gerrit.ovirt.org/12666
To unsubscribe, visit
Eli Mesika has posted comments on this change.
Change subject: core:remove storage pool is failing in Psql exception...
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13110
To unsubscribe, visit http://gerri
Eli Mesika has uploaded a new change for review.
Change subject: core:remove storage pool is failing in Psql exception...
..
core:remove storage pool is failing in Psql exception...
ovirt-engine: remove storage pool is failing i
Doron Fediuck has posted comments on this change.
Change subject: core: Fix empty quota events tab
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src/ma
Tal Nisan has posted comments on this change.
Change subject: core: import cleanup in VDSCommand parameters
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13097
To unsubscribe, visit http:/
Gilad Chaplik has posted comments on this change.
Change subject: core: Remove unused GetDisksForQuotaIdQuery
..
Patch Set 2:
There is a valid use case for this query in the UI (not yet implemented). I'd
wait with it.
--
To v
Arik Hadas has posted comments on this change.
Change subject: core: add locking groups for resources in export domain
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13102
To unsubscribe, visit http://gerrit
Arik Hadas has posted comments on this change.
Change subject: core: remove read lock of template being exported
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13109
To unsubscribe, visit http://gerrit.ovirt
Arik Hadas has uploaded a new change for review.
Change subject: core: remove read lock of template being exported
..
core: remove read lock of template being exported
Replace the exclusive lock which was taken for a template th
Michael Kublin has posted comments on this change.
Change subject: engine: War aginst long transaction - migration of vms
..
Patch Set 1:
Yair, I want to disable global transaction and not keep it, I don't understand
why I nee
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused GetDisksForQuotaIdQuery
..
Patch Set 2: Verified
Removed the parameters class too.
--
To view, visit http://gerrit.ovirt.org/13108
To unsub
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused GetDisksForQuotaIdQuery
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13108
To unsubscribe, visit http://gerrit.ovirt.o
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove unused GetDisksForQuotaIdQuery
..
core: Remove unused GetDisksForQuotaIdQuery
GetDisksForQuotaIdQuery is not used anywhere in the code, and hence
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated packaging for db utilities
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13107
To unsubscribe, visit http://gerrit.ovirt.or
Ravi Nori has posted comments on this change.
Change subject: engine : User can see events which don't belong to him
..
Patch Set 3:
He will see events for VMs in a cluster if he has permissions on the cluster.
This removes th
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/3736/
Build Number: 3736
Build Status: Fixed
Triggered By: Started by user eyal edri
-
Changes Since Last Success:
Alex Lourie has abandoned this change.
Change subject: packaging: Added checking DB state before upgrade
..
Patch Set 5: Abandoned
Abandoned in favor of http://gerrit.ovirt.org/#/c/13107/ and another patch that
will come on to
Alex Lourie has posted comments on this change.
Change subject: packaging: Stopped using backup.sh script for DB backup
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13106
To unsubscribe, visit http://gerri
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Updated packaging for db utilities
..
packaging: Updated packaging for db utilities
This patch updates the packaging of various DB
utilities within the
Yair Zaslavsky has posted comments on this change.
Change subject: engine: War aginst long transaction - migration of vms
..
Patch Set 1:
I think Arik's idea is interesting (imitate the behavior of
TransactionAttributeType.sup
Yair Zaslavsky has posted comments on this change.
Change subject: engine: War aginst long transaction - migration of vms
..
Patch Set 1:
What Arik is suggesting is similar to TransactionAttributeType.supports (at
Java EE, CMT
Arik Hadas has posted comments on this change.
Change subject: engine: War aginst long transaction - migration of vms
..
Patch Set 1:
Roy - how can I set such kind of scope ? I see 4 options: Suppress, Required
(which is the d
Alon Bar-Lev has posted comments on this change.
Change subject: engine: use autoclose to clean up vdsdeploy
..
Patch Set 1:
the fact that destructors in java has their issues, does not mean that they
should not be used t prev
Laszlo Hornyak has posted comments on this change.
Change subject: engine: use autoclose to clean up vdsdeploy
..
Patch Set 1:
I can hardly believe that doing some trick in the finalize method would be the
right solution for t
Oved Ourfali has posted comments on this change.
Change subject: engine : User can see events which don't belong to him
..
Patch Set 3:
does you patch mean that user will only see events of objects he has direct
permissions on
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Stopped using backup.sh script for DB backup
..
packaging: Stopped using backup.sh script for DB backup
This patch replaces the usage of the backup.sh
Roy Golan has posted comments on this change.
Change subject: engine: War aginst long transaction - migration of vms
..
Patch Set 1:
Arik - I think this will exactly what happens if the current thread is in TX or
not so there
ofri masad has posted comments on this change.
Change subject: core: Fix empty quota events tab
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13104
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Arik Hadas has posted comments on this change.
Change subject: engine: War aginst long transaction - migration of vms
..
Patch Set 1:
to reduce the risk that omer has mentioned maybe we can add new
transaction-scope that do so
ofri masad has uploaded a new change for review.
Change subject: core: Fix empty quota events tab
..
core: Fix empty quota events tab
The Events sub tab under the quota always remained empty.
The reasons for that were:
a. The
ofri masad has posted comments on this change.
Change subject: webadmin: Clean-up for AbstractVmPopupWidget.ui.xml
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12757
To unsubscribe, visit http://gerrit.ovi
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Fixed sorting in Datacenter/Networks subtab
..
Patch Set 1: (1 inline comment)
File
frontend/webad
Allon Mureinik has posted comments on this change.
Change subject: [wip] core: move image group command
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/s
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Fixed sorting in Cluster/Networks subtab
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin
Yair Zaslavsky has posted comments on this change.
Change subject: engine : User can see events which don't belong to him
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Project: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/
Build: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/277/
Build Number: 277
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 4,648
Omer Frenkel has posted comments on this change.
Change subject: engine: War aginst long transaction - migration of vms
..
Patch Set 1:
what happens if this commands are called from withing a transaction? the
concern i have is
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Change to use generic "name exists" message
..
core: Change to use generic "name exists" message
Where applicable, commands were changed to use th
Mike Kolesnik has posted comments on this change.
Change subject: core: Change to use generic "name exists" message
..
Patch Set 5: Verified; Looks good to me, approved
Rebased, addressed Allon's comments, other than that no ch
Moti Asayag has posted comments on this change.
Change subject: core: Added generic message that name is used
..
Patch Set 5:
Allon, smaller patches are easier to review. Combining with the fact that this
patch is a part of a
Liron Ar has posted comments on this change.
Change subject: [wip] core: rename MoveOrCopyImageGroup to CopyImageGroup
..
Patch Set 1:
i preferred to separate them as long as it's wip for better readability, when
merging i can
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Added generic message that name is used
..
core: Added generic message that name is used
A generic message that a name is already used, to replace
Mike Kolesnik has posted comments on this change.
Change subject: core: Added generic message that name is used
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12361
To unsubscribe
Liron Ar has posted comments on this change.
Change subject: [wip] core: move image group command
..
Patch Set 1:
for better readability when reviewing, when merging i can squash them together.
--
To view, visit http://gerrit.
Moti Asayag has posted comments on this change.
Change subject: core: Added generic message that name is used
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12361
To unsubscribe, visit http
Omer Frenkel has submitted this change and it was merged.
Change subject: core: persistent in-memory lock for remove template
..
core: persistent in-memory lock for remove template
This patch replace the existing exclusive lock
Omer Frenkel has posted comments on this change.
Change subject: core: persistent in-memory lock for remove template
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13100
To unsubs
Omer Frenkel has posted comments on this change.
Change subject: core: persistent in-memory lock for remove template
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13100
To unsubscribe, vis
Allon Mureinik has posted comments on this change.
Change subject: [wip] core: rename MoveOrCopyImageGroup to CopyImageGroup
..
Patch Set 1: I would prefer that you didn't submit this
why not squash this to the previous patch?
Allon Mureinik has posted comments on this change.
Change subject: [wip] core: move image group command
..
Patch Set 1:
Just saw the next patch - why not squash them together?
--
To view, visit http://gerrit.ovirt.org/13042
To
Allon Mureinik has posted comments on this change.
Change subject: [wip] core: move image group command
..
Patch Set 1: I would prefer that you didn't submit this
This leaves the code somewhat unclear - why not rename MoveOrCop
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Network validator tests use assertThat
..
engine: Network validator tests use assertThat
Refactored the network validator's tests to use assertT
Mike Kolesnik has posted comments on this change.
Change subject: engine: Network validator tests use assertThat
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no changes since ack by masayag
--
To view, visit h
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Added ValidationResult matchers
..
engine: Added ValidationResult matchers
The matchers can be used for testing that validation result complies
Mike Kolesnik has posted comments on this change.
Change subject: engine: Added ValidationResult matchers
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no changes since ack by masayag
--
To view, visit http://g
Allon Mureinik has posted comments on this change.
Change subject: [wip] core: refactor MoveOrCopy/RemoveImage commands and
parameters
..
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
1. See inli
Doron Fediuck has submitted this change and it was merged.
Change subject: pki: use relative lock file
..
pki: use relative lock file
Current implementation uses /var/lock/ovirt-engine/* to perform lock of
pki operations.
Prob
1 - 100 of 166 matches
Mail list logo
