Doron Fediuck has posted comments on this change.

Change subject: core: Fix empty quota events tab
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
Line 381:         // cache
Line 382:         if(requestIsApproved) {
Line 383:             cacheNewValues(quotaVdsGroup, newMemory, newVcpu);
Line 384:         } else {
Line 385:             auditLogPair.getSecond().setQuotaIdForLog(quota.getId());
Can any of the below be null?

- auditLogPair.getSecond()
- quota.getId()
Line 386:         }
Line 387:         return requestIsApproved;
Line 388:     }
Line 389: 


--
To view, visit http://gerrit.ovirt.org/13104
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I207db27df01705660dc33874cd0e222028c0ff63
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to