Alona Kaplan has posted comments on this change.

Change subject: webadmin: Fixed sorting in Datacenter/Networks subtab
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java
Line 123:         _asyncQuery.asyncCallback = new INewAsyncCallback() {
Line 124:             @Override
Line 125:             public void OnSuccess(Object model, Object ReturnValue)
Line 126:             {
Line 127:                 ArrayList<Network> newItems = (ArrayList<Network>) 
((VdcQueryReturnValue) ReturnValue).getReturnValue();
The same comparator is declared in http://gerrit.ovirt.org/#/c/13049/1.
You can move it to Linq.java and reuse it.
Line 128:                 Collections.sort(newItems, new Comparator<Network>() {
Line 129:                     LexoNumericComparator lexoNumeric = new 
LexoNumericComparator();
Line 130: 
Line 131:                     @Override


--
To view, visit http://gerrit.ovirt.org/13050
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I552af3c1269986f8f2d957b488c7a0358360409e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to