Roy Golan has posted comments on this change.
Change subject: core: introduce osinfo service implementation over RMI
..
Patch Set 2: (1 inline comment)
File
backend/manager/
Mike Kolesnik has posted comments on this change.
Change subject: engine: Prevent management network change
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12909
To unsubscribe, visit http:/
Ravi Nori has posted comments on this change.
Change subject: restapi: #853739 - Actions Should Return Entities In Body
..
Patch Set 4: Fails
Fails Tests, will upload better patch
--
To view, visit http://gerrit.ovirt.org/9466
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remove image when VDSM returns not exist.
..
Patch Set 6: (1 inline comment)
File
backend/manager/mo
Keith Robertson has submitted this change and it was merged.
Change subject: man page: fixed a word repetition
..
man page: fixed a word repetition
Change-Id: I97ed210a016eb04f2b9c865a4aa75ec5c402800f
Signed-off-by: Sandro Bona
Keith Robertson has posted comments on this change.
Change subject: man page: fixed a word repetition
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12750
To unsubscribe, visit http://gerrit.ovirt.org/settin
Keith Robertson has posted comments on this change.
Change subject: man page: fixed a word repetition
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12750
To unsubscribe, visit http://gerri
Keith Robertson has posted comments on this change.
Change subject: man page: fixed a word repetition
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12750
To unsubscribe, visit http://gerri
Keith Robertson has posted comments on this change.
Change subject: tools: fixed --version output
..
Patch Set 5:
Rebase to fix the conflicts and I'll push.
Cheers,
Keith
--
To view, visit http://gerrit.ovirt.org/12735
To uns
Keith Robertson has posted comments on this change.
Change subject: tools: fixed --version output
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12735
To unsubscribe, visit http://gerrit.ov
Keith Robertson has submitted this change and it was merged.
Change subject: tools: fixed command line parser setup
..
tools: fixed command line parser setup
The previous command line parser setup caused the rewrite of the
data
Keith Robertson has posted comments on this change.
Change subject: tools: fixed command line parser setup
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/12729
To unsubscribe, visit http://gerrit.ovirt.org/s
Keith Robertson has posted comments on this change.
Change subject: tools: fixed command line parser setup
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12729
To unsubscribe, visit http://
Keith Robertson has posted comments on this change.
Change subject: tools: fixed command line parser setup
..
Patch Set 2:
Please rebase and I'll push. Cheers.
--
To view, visit http://gerrit.ovirt.org/12729
To unsubscribe, v
Keith Robertson has posted comments on this change.
Change subject: tools: fixed command line parser setup
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12729
To unsubscribe, visit http://
Keith Robertson has posted comments on this change.
Change subject: cleanup: pep8 and pyflakes compliant
..
Patch Set 1:
Please rebase and I'll push it. Cheers.
--
To view, visit http://gerrit.ovirt.org/12708
To unsubscribe,
Keith Robertson has posted comments on this change.
Change subject: cleanup: pep8 and pyflakes compliant
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12708
To unsubscribe, visit http://ge
Keith Robertson has posted comments on this change.
Change subject: cleanup: pep8 compliant
..
Patch Set 1:
You need to rebase it. Unfortunately, gerrit can't do it automagically this
time.
--
To view, visit http://gerrit.ov
Keith Robertson has posted comments on this change.
Change subject: cleanup: pep8 compliant
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12314
To unsubscribe, visit http://gerrit.ovirt.or
Itamar Heim has posted comments on this change.
Change subject: reports: updated localization files (#918075)
..
Patch Set 1: (1 inline comment)
Commit Message
Line 5: Commit
Maor Lipchuk has posted comments on this change.
Change subject: core: Remove image when VDSM returns not exist.
..
Patch Set 6: (1 inline comment)
File
backend/manager/modu
Keith Robertson has submitted this change and it was merged.
Change subject: Added logging of insufficient local space
..
Added logging of insufficient local space
When checking for space availability for decompressing the ovf
Keith Robertson has posted comments on this change.
Change subject: Added logging of insufficient local space
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12688
To unsubscribe, visit http
Keith Robertson has posted comments on this change.
Change subject: engine-log-collector - fix exit value on wrong password
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12403
To
Keith Robertson has submitted this change and it was merged.
Change subject: engine-log-collector - fix exit value on wrong password
..
engine-log-collector - fix exit value on wrong password
Removed too early exception handlin
Keith Robertson has submitted this change and it was merged.
Change subject: engine-iso-uploader - notify the user for started upload process
..
engine-iso-uploader - notify the user for started upload process
In upload_to_stor
Keith Robertson has posted comments on this change.
Change subject: engine-iso-uploader - notify the user for started upload process
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Alon Bar-Lev has posted comments on this change.
Change subject: db: execute privileged upgrade operation only if required
..
Patch Set 1:
I could not actually verify it as I don't have this old database, and I am not
db maste
Alon Bar-Lev has posted comments on this change.
Change subject: db: add create_schema to allow unprivileged schema creation
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12948
To unsubscribe, visit http://
Alon Bar-Lev has uploaded a new change for review.
Change subject: db: execute privileged upgrade operation only if required
..
db: execute privileged upgrade operation only if required
Having a privileged user during installati
Alon Bar-Lev has uploaded a new change for review.
Change subject: db: add create_schema to allow unprivileged schema creation
..
db: add create_schema to allow unprivileged schema creation
This will enable user to create his ow
Daniel Erez has posted comments on this change.
Change subject: webadmin: Vnics statistics are not shown for VM unless VNIC is
selected
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12917
Daniel Erez has posted comments on this change.
Change subject: webadmin: load image refreshing data
..
Patch Set 2:
Why it doesn't have anything to do with it? They both address the exact same
problem: no indication for data
Alexander Wels has posted comments on this change.
Change subject: webadmin: load image refreshing data
..
Patch Set 2:
Well that patch is a generic loading indicator. This is to make the grid behave
more like normal grids. Wi
Daniel Erez has posted comments on this change.
Change subject: webadmin: load image refreshing data
..
Patch Set 2:
We may want to revisit this patch instead/in addition:
http://gerrit.ovirt.org/#/c/7493/
--
To view, visit ht
Alexander Wels has posted comments on this change.
Change subject: webadmin: load image refreshing data
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12946
To unsubscribe, visit http://gerrit.ovirt.org/sett
Sharad Mishra has posted comments on this change.
Change subject: engine: Add glusterfs domain to engine.
..
Patch Set 16: Verified
--
To view, visit http://gerrit.ovirt.org/8834
To unsubscribe, visit http://gerrit.ovirt.org/se
Sharad Mishra has posted comments on this change.
Change subject: webadmin: Add support for gluster storage domain in GUI.
..
Patch Set 18: Verified
--
To view, visit http://gerrit.ovirt.org/8983
To unsubscribe, visit http://ge
Alexander Wels has uploaded a new change for review.
Change subject: webadmin: load image refreshing data
..
webadmin: load image refreshing data
- Fixed when switching main tabs always show 'loading' image
so the user has feedb
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Cluster compatibility check for volume advanced
details
..
webadmin: Cluster compatibility check for volume advanced details
1.Cluster Services sub-tab
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/3492/
Build Number: 3492
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Ravi Nori has abandoned this change.
Change subject: cli: Ping command success message need to be rephrased(#918749)
..
Patch Set 1: Abandoned
Will submit downstream branding patch
--
To view, visit http://gerrit.ovirt.org/128
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Decouple AspectJ config from
gwt-plugin.extraJvmArgs
..
Patch Set 2:
Note to myself: update http://www.ovirt.org/DebugFrontend - add Q/A on
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Upgrade - Error Can't start the ovirt-engine-dwhd service
..
core: Upgrade - Error Can't start the ovirt-engine-dwhd service
Fix column name to _
Yair Zaslavsky has posted comments on this change.
Change subject: core: Upgrade - Error Can't start the ovirt-engine-dwhd service
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/12942
To unsubscribe, visit h
Yair Zaslavsky has posted comments on this change.
Change subject: core: Upgrade - Error Can't start the ovirt-engine-dwhd service
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12942
To un
Yair Zaslavsky has posted comments on this change.
Change subject: core: Upgrade - Error Can't start the ovirt-engine-dwhd service
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12942
To un
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Select english when browser is other locale
..
Patch Set 4:
Some notes on "en" locale & default constant/message handling:
* "en" locale has no propert
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Select english when browser is other locale
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/11047
To unsubscribe, visit http://gerri
Yair Zaslavsky has posted comments on this change.
Change subject: core: Upgrade - Error Can't start the ovirt-engine-dwhd service
..
Patch Set 3: Looks good to me, but someone else must approve
Didn't you say your previous pat
Eli Mesika has posted comments on this change.
Change subject: core: Upgrade - Error Can't start the ovirt-engine-dwhd service
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/12942
To unsubscribe, visit http:
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Use POM_VERSION to locate artifacts
..
packaging: Use POM_VERSION to locate artifacts
We currently use APP_VERSION to locate artifacts in th
Juan Hernandez has posted comments on this change.
Change subject: packaging: Use POM_VERSION to locate artifacts
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12941
To unsubscri
Einav Cohen has posted comments on this change.
Change subject: webadmin: Select english when browser is other locale
..
Patch Set 4:
Alona - any chance that you can re-review the latest version of this patch,
with Vojtech's l
Eli Mesika has posted comments on this change.
Change subject: core: Upgrade - Error Can't start the ovirt-engine-dwhd service
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12942
To unsubscribe, visit http:
Eli Mesika has uploaded a new change for review.
Change subject: core: Upgrade - Error Can't start the ovirt-engine-dwhd service
..
core: Upgrade - Error Can't start the ovirt-engine-dwhd service
Fix column name to _update_date
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Use POM_VERSION to locate artifacts
..
packaging: Use POM_VERSION to locate artifacts
We currently use APP_VERSION to locate artifacts in the direct
Einav Cohen has posted comments on this change.
Change subject: core: provided cleared frontend logging
..
Patch Set 4:
Yair - can you please re-review this patch? thanks.
--
To view, visit http://gerrit.ovirt.org/12559
To uns
Juan Hernandez has posted comments on this change.
Change subject: packaging: Use POM_VERSION to locate artifacts
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12939
To unsubscri
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Use POM_VERSION to locate artifacts
..
packaging: Use POM_VERSION to locate artifacts
We currently use APP_VERSION to locate artifacts in th
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Use POM_VERSION to locate artifacts
..
packaging: Use POM_VERSION to locate artifacts
We currently use APP_VERSION to locate artifacts in the direct
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Select english when browser is other locale
..
Patch Set 3:
Maybe we could include one more change in this patch: instead of hard-coded
"locale" query
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Select english when browser is other locale
..
Patch Set 3: (1 inline comment)
Maybe we could include one more change in this patch: instead of hard-co
Doron Fediuck has posted comments on this change.
Change subject: WIP core: fix businessentity hashCode/equals errors
..
Patch Set 3: (1 inline comment)
File
backend/manager
Gilad Chaplik has posted comments on this change.
Change subject: core: clean up businessentity hashCode() methods [part 1]
..
Patch Set 2:
Actually I'm not a fan of not sorted hashCode; this method is auto generated by
most o
Gilad Chaplik has posted comments on this change.
Change subject: WIP core: fix businessentity hashCode/equals errors
..
Patch Set 3: (2 inline comments)
File
backend/manage
Juan Hernandez has posted comments on this change.
Change subject: core: introduce osinfo service implementation over RMI
..
Patch Set 2: (3 inline comments)
I think it may be worth to reduce the number of classes generated wit
Doron Fediuck has posted comments on this change.
Change subject: core: clean up businessentity hashCode() methods [part 1]
..
Patch Set 2:
Can we have a test which enforces Id.hashCode being first?
Otherwise this may go to wa
Alon Bar-Lev has posted comments on this change.
Change subject: core: introduce osinfo service implementation over RMI
..
Patch Set 2:
Please don't store generated files in source repository, generate them during
build.
--
T
Alon Bar-Lev has posted comments on this change.
Change subject: core: introduce osinfo service instead of Config values
..
Patch Set 1:
I don't like the jboss starting a new jvm, if we go this path we need a
separate service
Alexander Wels has posted comments on this change.
Change subject: core: Locale docs servlet.
..
Patch Set 14: (34 inline comments)
File backend/manager/modules/root/pom.xml
Juan Hernandez has posted comments on this change.
Change subject: core: introduce osinfo service instead of Config values
..
Patch Set 1: (3 inline comments)
File
backend/m
Doron Fediuck has posted comments on this change.
Change subject: WIP core: fix businessentity hashCode/equals errors
..
Patch Set 3: (1 inline comment)
Something which bugs me... see inline.
..
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Try nfs and nfs-server
..
packaging: Try nfs and nfs-server
When configuring the NFS service we need to try with both names, as some
distrib
Juan Hernandez has posted comments on this change.
Change subject: packaging: Try nfs and nfs-server
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12864
To unsubscribe, visit htt
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Use Id=... to check systemd services
..
packaging: Use Id=... to check systemd services
The services managed by systemd can have an unique i
Juan Hernandez has posted comments on this change.
Change subject: packaging: Use Id=... to check systemd services
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12863
To unsubscr
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Enable features according to distribution
..
packaging: Enable features according to distribution
This change introduces two new "install_sy
Juan Hernandez has posted comments on this change.
Change subject: packaging: Enable features according to distribution
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12862
To uns
Eli Mesika has submitted this change and it was merged.
Change subject: core: Upgrade - Error Can't start the ovirt...
..
core: Upgrade - Error Can't start the ovirt...
Upgrade - Error Can't start the ovirt-engine-dwhd service
Eli Mesika has posted comments on this change.
Change subject: core: Upgrade - Error Can't start the ovirt...
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12919
To unsubscribe,
Roy Golan has uploaded a new change for review.
Change subject: core: introduce osinfo service instead of Config values
..
core: introduce osinfo service instead of Config values
osinfo service is a replacement for Config values
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Enable features according to distribution
..
packaging: Enable features according to distribution
This change introduces two new "install_sy
Juan Hernandez has posted comments on this change.
Change subject: packaging: Enable features according to distribution
..
Patch Set 3: Verified; Looks good to me, approved
Rebased and removed the "if centos".
--
To view, visi
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Move passwd encryption script to tools
..
packaging: Move passwd encryption script to tools
This script used to be in the PKI directory, but
Juan Hernandez has posted comments on this change.
Change subject: packaging: Move passwd encryption script to tools
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12861
To unsubs
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Removed the ResXResourceReader class
..
core: Removed the ResXResourceReader class
Removed the class ResXResourceReader from the compat module, t
Juan Hernandez has posted comments on this change.
Change subject: core: Removed the ResXResourceReader class
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12860
To unsubscribe,
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: engine-setup - make firewall checking more robust
..
packaging: engine-setup - make firewall checking more robust
1. Don't execute systemctl
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-setup - make firewall checking more robust
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1285
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Add commons-collections to the dal module
..
core: Add commons-collections to the dal module
Commit 81742e created a module for the DAL, but it i
Juan Hernandez has posted comments on this change.
Change subject: core: Add commons-collections to the dal module
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12858
To unsubscr
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Use context classloader from YAML
..
restapi: Use context classloader from YAML
The YAML library that we use to build load the RSDL metadata a
Juan Hernandez has posted comments on this change.
Change subject: restapi: Use context classloader from YAML
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12857
To unsubscribe,
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Don't resolve plugins
..
packaging: Don't resolve plugins
Now that we have a plugin in the project that is required for the build
(the jboss
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't resolve plugins
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12856
To unsubscribe, visit http
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Move the session cleaner interceptor to bll
..
core: Move the session cleaner interceptor to bll
Commit 028ff6 moved the utils library to a JBoss
Juan Hernandez has posted comments on this change.
Change subject: core: Move the session cleaner interceptor to bll
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12855
To unsubs
Allon Mureinik has submitted this change and it was merged.
Change subject: build: solve m2e manifest problems
..
build: solve m2e manifest problems
The m2e plugin for Eclipse IDE that many developers use is incompatible
with t
Allon Mureinik has posted comments on this change.
Change subject: build: solve m2e manifest problems
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no changes.
+2 by Yair, +1 by Juan.
Verified on RHEL, additiona
1 - 100 of 244 matches
Mail list logo
