Shireesh Anjal has posted comments on this change.
Change subject: engine: Added missing port for Gluster operations.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/118
Michael Pasternak has posted comments on this change.
Change subject: restapi : Add /clusters sub-collection under
/datacenters/xxx(#674521)
..
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
..
Ofer Schreiber has uploaded a new change for review.
Change subject: packaging: engine-setup - Replace IPTables with iptables
..
packaging: engine-setup - Replace IPTables with iptables
Replace "IPTables" with "iptables" as it's
Allon Mureinik has posted comments on this change.
Change subject: core: Fix dao tests not to print lookup error
..
Patch Set 1: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/12176
To unsu
Omer Frenkel has posted comments on this change.
Change subject: webadmin,userportal: set up Proxy property to SPICE
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1209
Selvasundaram has posted comments on this change.
Change subject: engine: Get gluster hooks query
..
Patch Set 11:
Enum added for Gluster Hooks Content type.
--
To view, visit http://gerrit.ovirt.org/10650
To unsubscribe, visi
Vered Volansky has posted comments on this change.
Change subject: core: Remove unused JARs from bll's pom.xml
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Einav Cohen has posted comments on this change.
Change subject: core, webadmin: i18n splash screen.
..
Patch Set 11:
Juan - can you please re-review this patch?
--
To view, visit http://gerrit.ovirt.org/10065
To unsubscribe, v
Einav Cohen has posted comments on this change.
Change subject: webadmin: Select english when browser is other locale
..
Patch Set 2:
Alona - can you please re-review this patch?
--
To view, visit http://gerrit.ovirt.org/11047
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: Added caching
..
Patch Set 12:
Juan - any comment on Alex's answer? Do we have an agreement?
--
To view, visit http://gerrit.ovirt.org/10449
Einav Cohen has posted comments on this change.
Change subject: webadmin: enable gzip compression
..
Patch Set 8:
Michael - can you please clarify your question to Alex?
Vojtech - can you please do the final review for this pat
Chris Morrissey has posted comments on this change.
Change subject: core: Added RegisterDiskCommand and GetUnregisteredDisksQuery
..
Patch Set 2: (19 inline comments)
Responded to comments
.
Ohad Basan has posted comments on this change.
Change subject: packaging: modify ovirt-live to 3.2 stable
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12179
To unsubscribe, visit http://gerrit.ovirt.org/se
Daniel Erez has posted comments on this change.
Change subject: core: Fix Quota accounting for move disk
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12159
To unsubsc
Alexander Wels has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 7: Verified
Fixed the issue where the selected item got reset every refresh for no reason.
--
To view, visit http:
Daniel Erez has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12111
To unsubscribe, visit http://g
Moran Goldboim has posted comments on this change.
Change subject: packaging: modify ovirt-live to 3.2 stable
..
Patch Set 1:
Ohad, please add verification flag to this change. in addition, for building
nightly we'll need to b
Daniel Erez has posted comments on this change.
Change subject: core: Remove JBoss specific logging from bll
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12168
To uns
Ravi Nori has posted comments on this change.
Change subject: tools : taskcleaner.sh utility returns always 0 as return code
..
Patch Set 2: (1 inline comment)
Please see my message
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix dao tests not to print lookup error
..
Patch Set 1: I would prefer that you didn't submit this
I will flag as -1, will get back to this ASAP.
--
To v
Yair Zaslavsky has posted comments on this change.
Change subject: userportal : Events sorting - oldest first
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12181
To un
Ravi Nori has posted comments on this change.
Change subject: userportal : Events sorting - oldest first
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/12181
To unsubscribe, visit http://gerrit.ovirt.org/set
Maor Lipchuk has posted comments on this change.
Change subject: core: Remove JBoss specific logging from bll
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12168
To un
Ravi Nori has uploaded a new change for review.
Change subject: userportal : Events sorting - oldest first
..
userportal : Events sorting - oldest first
Incorrect sorting of events in user portal.
The events are not sorted in an
Alexander Wels has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 6: Fails
Unfortunately this won't be the last version. The optimization does not keep
the current selected VM, sel
Arik Hadas has posted comments on this change.
Change subject: core: patterned pool names support
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/11986
To unsubscribe, visit http://gerrit.ovirt.org/settings
Arik Hadas has posted comments on this change.
Change subject: core: patterned pool names support
..
Patch Set 4: (2 inline comments)
File
backend/manager/modules/bll/src/ma
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: VmGuideModel DirectLUN disk setLunType
..
webadmin: VmGuideModel DirectLUN disk setLunType
VmGuideModel - when adding a DirectLUN disk
set LunType accor
Ohad Basan has uploaded a new change for review.
Change subject: packaging: modify ovirt-live to 3.2 stable
..
packaging: modify ovirt-live to 3.2 stable
*modifies the ovirt-live to base on ovirt 3.2 stable version.
*change admi
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: changed tasks polling in engine-upgrade
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12177
To unsubscribe, visit http://gerri
Sandro Bonazzola has uploaded a new change for review.
Change subject: packaging: changed tasks polling in engine-upgrade
..
packaging: changed tasks polling in engine-upgrade
Modified checkRunningTasks: during engine upgrade, s
Allon Mureinik has posted comments on this change.
Change subject: core: Fix dao tests not to print lookup error
..
Patch Set 1:
flagging as "-1" just so it doesn't keep poping up on my radar - but as said,
the concept is fine
Allon Mureinik has posted comments on this change.
Change subject: core: Fix dao tests not to print lookup error
..
Patch Set 1: (2 inline comments)
like the idea, have issues with the implementation - see inline.
Alon Bar-Lev has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 12:
Yair, please CC me at any host deploy change.
I don't really understand this patch... if I put host1
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Fix dao tests not to print lookup error
..
core: Fix dao tests not to print lookup error
Although this does not break tests, seeing an exception
when run
Yair Zaslavsky has abandoned this change.
Change subject: core: Treat "only in db" zombie tasks
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12175
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Yair Zaslavsky has abandoned this change.
Change subject: core: Fix dao tests not to print lookup error
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/12174
To unsubscribe, visit http://gerrit.ovirt.org/set
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Treat "only in db" zombie tasks
..
core: Treat "only in db" zombie tasks
When system restarts, there may be some tasks
that exist only in the DB (form pr
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Fix dao tests not to print lookup error
..
core: Fix dao tests not to print lookup error
Although this does not break tests, seeing an exception
when run
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: patterned pool names support
..
webadmin: patterned pool names support
This patch contains the frontend part of patterned pool names support.
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: patterned pool names support
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11985
To unsubscribe, visit http://ge
Arik Hadas has posted comments on this change.
Change subject: webadmin: patterned pool names support
..
Patch Set 5: Verified
rebased, verified
--
To view, visit http://gerrit.ovirt.org/11985
To unsubscribe, visit http://gerr
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Optimize extended view VM/Pool grid
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
This patch is now ready for final revie
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove StreamReaderCompat
..
core: Remove StreamReaderCompat
This patch removes the deprecate class StreamReaderCompat and its
ancestor, TextRead
Allon Mureinik has posted comments on this change.
Change subject: core: Remove StreamReaderCompat
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, +2 by Tal, +1 by Alon Bar Lev.
--
To view, visit http://gerrit.ov
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Add test for GetCACertificateQuery
..
core: Add test for GetCACertificateQuery
Added a test case for the GetCACertificateQuery class.
Change-Id:
Allon Mureinik has posted comments on this change.
Change subject: core: Add test for GetCACertificateQuery
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, +2 by Tal.
--
To view, visit http://gerrit.ovirt.org/121
Eli Mesika has uploaded a new change for review.
Change subject: Move fkvalidator.sh to tools/dbutils
..
Move fkvalidator.sh to tools/dbutils
Moving the fkvalidator.sh script to tools/dbutils and make it stand
alone.
Also, defi
Oved Ourfali has uploaded a new change for review.
Change subject: userportal: UserVmManager cannot edit Custom properties
..
userportal: UserVmManager cannot edit Custom properties
This patch hides the custom properties side ta
Allon Mureinik has posted comments on this change.
Change subject: core: Add test for GetCACertificateQuery
..
Patch Set 1:
@Alon - AFIAK, it's used as part of the flow that open a SPICE console (see
SpiceConsoleModel). Run in
Tal Nisan has posted comments on this change.
Change subject: core: Add test for GetCACertificateQuery
..
Patch Set 1:
Removing is always the first priority ;)
--
To view, visit http://gerrit.ovirt.org/12169
To unsubscribe, vi
Alon Bar-Lev has posted comments on this change.
Change subject: core: Add test for GetCACertificateQuery
..
Patch Set 1:
> Cause we are the janitors crew - we clean code ;)
Just removing it will be clear, no? :)
--
To view,
Tal Nisan has posted comments on this change.
Change subject: core: Add test for GetCACertificateQuery
..
Patch Set 1:
Cause we are the janitors crew - we clean code ;)
--
To view, visit http://gerrit.ovirt.org/12169
To unsubs
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 6:
This is (hopefully) the final version of the patch.
--
To view, visit http://gerrit.ovirt.org/10509
To unsubscri
Tal Nisan has posted comments on this change.
Change subject: core: Remove JBoss specific logging from bll
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12168
To unsub
Tal Nisan has posted comments on this change.
Change subject: core: Remove unused JARs from bll's pom.xml
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12167
To unsubs
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10509
To unsu
Vojtech Szocs has posted comments on this change.
Change subject: userportal: stop basic list provider on extended tab
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12
Vojtech Szocs has posted comments on this change.
Change subject: userportal: fix memory leaks
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11975
To unsubscribe, visi
Alon Bar-Lev has posted comments on this change.
Change subject: core: Add test for GetCACertificateQuery
..
Patch Set 1:
And why did you bump into this? what is the trigger?
--
To view, visit http://gerrit.ovirt.org/12169
To
Alon Bar-Lev has posted comments on this change.
Change subject: core: Add test for GetCACertificateQuery
..
Patch Set 1:
I apologize asking... why do we need this query? I don't know it... so probably
never reached to a code/
Alon Bar-Lev has posted comments on this change.
Change subject: core: Remove StreamReaderCompat
..
Patch Set 1: Looks good to me, but someone else must approve
GREAT!
Love to see these cleanups!
--
To view, visit http://gerr
Laszlo Hornyak has submitted this change and it was merged.
Change subject: engine: minor CommandBase change for rename logging
..
engine: minor CommandBase change for rename logging
- catching Exception is removed
- added juni
Laszlo Hornyak has posted comments on this change.
Change subject: engine: minor CommandBase change for rename logging
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11981
To unsu
Tal Nisan has posted comments on this change.
Change subject: core: Add test for GetCACertificateQuery
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12169
To unsubscribe, visit http://gerr
Tal Nisan has posted comments on this change.
Change subject: core: Remove StreamReaderCompat
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12170
To unsubscribe, visit http://gerrit.ovirt.
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Simplify host life cycle - removed unneeded
SetNonOperational
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1216
Ravi Nori has posted comments on this change.
Change subject: restapi : Add /clusters sub-collection under
/datacenters/xxx(#674521)
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/11618
To unsubscribe, visi
Allon Mureinik has posted comments on this change.
Change subject: ovirt:failed to create engine db because of locale
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/120
Allon Mureinik has posted comments on this change.
Change subject: [wip] core: move the storage domain V3 to DC 3.2
..
Patch Set 1:
Fede, is this still relevant?
--
To view, visit http://gerrit.ovirt.org/9197
To unsubscribe, v
Allon Mureinik has posted comments on this change.
Change subject: core: Remove JBoss specific logging from bll
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12168
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: Remove StreamReaderCompat
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12170
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: core: Add test for GetCACertificateQuery
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12169
To unsubscribe, visit http://gerrit.ovirt.org/
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused JARs from bll's pom.xml
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12167
To unsubscribe, visit http://gerrit.ovirt.o
Michael Pasternak has posted comments on this change.
Change subject: restapi: log error only when no InputStream
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12166
To unsubscri
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove JBoss specific logging from bll
..
core: Remove JBoss specific logging from bll
Removed the usage of JBoss specific implementation from bll tests'
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove unused JARs from bll's pom.xml
..
core: Remove unused JARs from bll's pom.xml
Removed a bunch of JAR dependencies from bll's pom.xml file.
These
Allon Mureinik has uploaded a new change for review.
Change subject: core: Add test for GetCACertificateQuery
..
core: Add test for GetCACertificateQuery
Added a test case for the GetCACertificateQuery class.
Change-Id: I508b63
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove StreamReaderCompat
..
core: Remove StreamReaderCompat
This patch removes the deprecate class StreamReaderCompat and its
ancestor, TextReaderCompat
Ori Liel has posted comments on this change.
Change subject: restapi: log error only when no InputStream
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12166
To unsubscribe, visit http://ge
Michael Pasternak has uploaded a new change for review.
Change subject: restapi: log error only when no InputStream
..
restapi: log error only when no InputStream
Change-Id: I179cef646da35ebfbc28d96823f5e4ea7429532f
Signed-off-b
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Cannot add network to VM when dc have bridgeless
mgmnt network
..
webadmin: Cannot add network to VM when dc have bridgeless mgmnt network
If
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Cannot add network to VM when dc have bridgeless
mgmnt network
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://g
Eli Mesika has posted comments on this change.
Change subject: engine: minor CommandBase change for rename logging
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11981
Eli Mesika has posted comments on this change.
Change subject: tools : taskcleaner.sh utility returns always 0 as return code
..
Patch Set 2: (1 inline comment)
File backend/
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3412/
Build Number: 3412
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 4,344
-
Changes Since
Eli Mesika has posted comments on this change.
Change subject: engine: Support for gluster asynchronous tasks(WIP)
..
Patch Set 3: (2 inline comments)
File
backend/manager/m
Shireesh Anjal has submitted this change and it was merged.
Change subject: gluster: resolve hostname before checking ip in db
..
gluster: resolve hostname before checking ip in db
At two places, we are checking if a server wit
Shireesh Anjal has posted comments on this change.
Change subject: gluster: resolve hostname before checking ip in db
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12021
To unsub
Michael Kublin has posted comments on this change.
Change subject: engine: Simplify host life cycle - removed unneeded
SetNonOperational
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12165
To unsubscribe,
Michael Kublin has uploaded a new change for review.
Change subject: engine: Simplify host life cycle - removed unneeded
SetNonOperational
..
engine: Simplify host life cycle - removed unneeded SetNonOperational
The following c
Daniel Erez has posted comments on this change.
Change subject: webadmin: Cannot add network to VM when dc have bridgeless
mgmnt network
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1213
ofri masad has posted comments on this change.
Change subject: webadmin: Add details to general Cluster sub-tab
..
Patch Set 9: (1 inline comment)
File
frontend/webadmin/mod
Shireesh Anjal has submitted this change and it was merged.
Change subject: engine: Changes in VdsStaticDAO
..
engine: Changes in VdsStaticDAO
Since there is a unique constraint on host_name now, the method
getAllForHostname()
Shireesh Anjal has posted comments on this change.
Change subject: engine: Changes in VdsStaticDAO
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12052
To unsubscribe, visit http:
Ravi Nori has posted comments on this change.
Change subject: tools : taskcleaner.sh utility returns always 0 as return code
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12103
To unsubscribe, visit http://
Tomas Jelinek has posted comments on this change.
Change subject: webadmin,userportal: set up Proxy property to SPICE
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/12093
To unsubscribe, visit http://gerrit.
Alona Kaplan has uploaded a new change for review.
Change subject: restapi: Rx and Tx should be displayed as BYTES_PER_SECOND
..
restapi: Rx and Tx should be displayed as BYTES_PER_SECOND
The rx and tx are reported and displayed
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3411/
Build Number: 3411
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 4,343
-
Chang
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Changes in VdsStaticDAO
..
Patch Set 2: Looks good to me, approved
Please follow Sahina's comment. Besides that - looks good.
--
To view, visit http://
1 - 100 of 239 matches
Mail list logo
